"Never include" messaging needs awareness

[jonathansampson]

Test plan

#12960 (comment)

---

Description

When right-clicking a YouTube Channel in Brave Payments, the user is provided the option to Never include this site. Instead, the option should be aware that the user has not selected a site, but a YouTube Channel. Perhaps a general term (Never include this content) should be adopted.

Steps to Reproduce

1. Right-click a YouTube channel in Brave Payments.

Actual result:
Never include this site

Expected result:
Never include this content

Reproduces how often:
100%

Brave Version

0.19.116

[NejcZdovc]

@jonathansampson what if we would say Never include this publisher?

[jonathansampson]

@NejcZdovc That would be better, but I don't think Publisher really describes YouTube Channels very well. I think we should either come up with a single word/phrase that describes both, or conditionally check the type of item before printing the label.

[NejcZdovc]

@jonathansampson yeah we can do type check as well, but why I said publisher is because when communicating to the public we always say publishers and we have publishers.basicattentiontoken.org

[jonathansampson]

@NejcZdovc Publishers was the original term used, when we were supporting only sites. But when we added support for YouTube, we made https://brave.com/creators. It could go either way. To me, "publishers" refers only to text. Something vague like Content Creator can be any type of media and/or format.

[NejcZdovc]

maybe Never include this creator?

[NejcZdovc]

To fix this problem we need to modify string deleteLedgerEntry in menu.properties file.

[MargarytaChepiga]

Hi, I am new to Brave and I would love to work on this if this is still available!

[NejcZdovc]

@MargarytaChepiga yes it's still available. Will assign issue to me, so that no one will take it. If you need any help let me know

[MargarytaChepiga]

@NejcZdovc Great! Thank you so much!

[MargarytaChepiga]

Hello, I am all set to fix this. The only thing is that I am not sure is to which message I should change the existing one. How about Never include this content creator? Or should I stick to the mentioned above Never include this creator ? Thanks!

[MargarytaChepiga]

I know Ukrainian and Russian, so I might as well change the string in those languages as well. Is that okay?

[bsclifton]

@MargarytaChepiga no need to modify Ukrainian or Russian- the process for translations is a little different. In this repo, you only need to update the en-US version

For more information on our translations (and to sign up to help 😄 ), please see:
https://github.com/brave/browser-laptop/blob/master/docs/translations.md

[MargarytaChepiga]

@bsclifton Great! Thank you so much!

[btlechowski]

Verified 0.21.9 Win64

[kjozwiak]

As per our earlier conversation with @NejcZdovc in the #testers channel, ledger functionality won't work until the twitch code is pulled in which includes the updated BAT libraries.

Removed QA/checked-Win64 as we should re-test this just incase once Twitch lands.

[LaurenWags]

Removed QA/checked labels due to changes in milestones. Please recheck with 0.21.15 and higher.

[srirambv]

Reopening based on #12960 (comment)

[srirambv]

Closing the issue as its an issue with missing translations