Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Option to disable promotions #12313

Closed
NejcZdovc opened this issue Dec 18, 2017 · 0 comments
Closed

Option to disable promotions #12313

NejcZdovc opened this issue Dec 18, 2017 · 0 comments
Assignees
@NejcZdovc
Labels
feature/rewards privacy QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include suggestion
Milestone
0.20.x (Release C...

Comments

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Dec 18, 2017 •
edited by luixxiul
Loading

Test plan

#12314 (comment)

Description

We need to add a mechanism to disable promotions, so that users don't see them if they never enable wallet. We don't want to call server in this cases.

based on the conversation with @BrendanEich, suggestion is to add toggle into advance settings. This way user can disable promotions without going into the payments and enabling wallet.

cc @bradleyrichter @davidtemkin
@NejcZdovc NejcZdovc added this to the 0.19.x Hotfix 9 milestone Dec 18, 2017
@NejcZdovc NejcZdovc self-assigned this Dec 18, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Dec 18, 2017
@NejcZdovc
Adds option to disable promotions
9abd9dd 
Resolves brave#12313

Auditors:

Test Plan:
@NejcZdovc NejcZdovc mentioned this issue Dec 18, 2017
Merged
8 tasks
@bsclifton bsclifton modified the milestones: 0.19.x Hotfix 9, 0.21.x (Developer Channel) Dec 20, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Dec 22, 2017
@NejcZdovc
Adds option to disable promotions
6f2bc99 
Resolves brave#12313

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Dec 22, 2017
@NejcZdovc
Adds option to disable promotions
6582ba8 
Resolves brave#12313

Auditors:

Test Plan:
bsclifton added a commit that referenced this issue Dec 22, 2017
@bsclifton
Merge pull request #12314 from NejcZdovc/hotfix/#12313-disable
4028c66 
Adds option to disable promotions
bsclifton added a commit that referenced this issue Dec 22, 2017
@bsclifton
Merge pull request #12314 from NejcZdovc/hotfix/#12313-disable
e84a17e 
Adds option to disable promotions
bsclifton added a commit that referenced this issue Dec 22, 2017
@bsclifton
Merge pull request #12314 from NejcZdovc/hotfix/#12313-disable
8b1a5a8 
Adds option to disable promotions
@bsclifton bsclifton modified the milestones: 0.21.x (Developer Channel), 0.20.x (Beta Channel) Dec 22, 2017
This was referenced Dec 27, 2017
Closed
Closed
Closed
This was referenced Jan 2, 2018
Closed
Closed
@NejcZdovc NejcZdovc mentioned this issue Jan 22, 2018
Closed
@kjozwiak kjozwiak mentioned this issue Jan 31, 2018
Closed
@LaurenWags LaurenWags mentioned this issue Feb 5, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
feature/rewards privacy QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include suggestion
Projects
None yet
Milestone
0.20.x (Release Channel)
Development

No branches or pull requests
6 participants
@tildelowengrimm @luixxiul @bsclifton @NejcZdovc @srirambv @LaurenWags