Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Reload sometimes stops working until browser restart #12333

Closed
riastradh-brave opened this issue Dec 19, 2017 · 2 comments · Fixed by #13234
Closed

Reload sometimes stops working until browser restart #12333

riastradh-brave opened this issue Dec 19, 2017 · 2 comments · Fixed by #13234
Assignees
Labels
misc/button priority/P1 Blocks development or testing. Product cannot run. Must be fixed immediately, shipped next release. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include usability

Comments

@riastradh-brave
Copy link
Contributor

riastradh-brave commented Dec 19, 2017

Test Plan

Description

Sometimes I hit ^R or press the reload button, and nothing happens, whether I do a normal reload or clean reload.

Steps to Reproduce

  1. Use Brave for a while.
  2. Try to reload the page.
  3. Not sure I have any other brilliant ideas for how to reproduce.

Actual result:
Nothing.

Expected result:
Page should reload.

Reproduces how often:
Every hour or so, maybe. Haven't been keeping close track.

Brave Version

about:brave info:

Brave 0.20.6
V8 6.2.414.36
rev 18f7d1e
Muon 4.5.14
OS Release 4.10.0-40-generic
Update Channel Beta
OS Architecture x64
OS Platform Linux
Node.js 7.9.0
Brave Sync v1.4.2
libchromiumcontent 62.0.3202.75

Reproducible on current live release:
Not sure, have not noticed on not-beta.

Additional Information

@kjozwiak kjozwiak added this to the Backlog (Prioritized) milestone Feb 7, 2018
@kjozwiak kjozwiak added the priority/P3 Major loss of function. label Feb 7, 2018
@kjozwiak kjozwiak modified the milestones: Backlog (Prioritized), 0.21.x (Beta Channel) Feb 7, 2018
@kjozwiak kjozwiak added priority/P1 Blocks development or testing. Product cannot run. Must be fixed immediately, shipped next release. and removed priority/P3 Major loss of function. labels Feb 7, 2018
@kjozwiak
Copy link
Member

kjozwiak commented Feb 7, 2018

@bbondy has ran into this several times in the past few days. @riastradh-brave mentioned that it used to happen every ~hour, now it happens every ~day or so. Once you run into the issue, command + r breaks throughout Brave and requires a restart. However, Shift+Command+R seems to always be working.

If this gets reproduced/fixed before 0.20.x Hotfix 2, we should probably uplift.

@bsclifton
Copy link
Member

@riastradh-brave are you still experiencing this with the live release (0.20.30)? I believe this was fixed before we shipped 0.20.x. You can also try the latest Beta (0.21.x) 😄 which I just released (0.21.9)

@bsclifton bsclifton self-assigned this Feb 20, 2018
petemill added a commit that referenced this issue Feb 21, 2018
This was causing an error to be thrown for every subsequent action, and no more state updates to be sent to windows, resulting in multiple issues.
It was also causing an error dump to be generated upon every action, thus halting the browser at those times, including any audio/video (and creating stutters).

Fix #13079 (main test case with STR)
Fix #12333
Fix #12828
Fix #13157
Address #13087 but this is a broad issue - this change will fix a hard issue, whereas that refers to general slowness.
@bsclifton bsclifton assigned petemill and unassigned bsclifton Feb 21, 2018
bsclifton pushed a commit that referenced this issue Feb 21, 2018
This was causing an error to be thrown for every subsequent action, and no more state updates to be sent to windows, resulting in multiple issues.
It was also causing an error dump to be generated upon every action, thus halting the browser at those times, including any audio/video (and creating stutters).

Fix #13079 (main test case with STR)
Fix #12333
Fix #12828
Fix #13157
Address #13087 but this is a broad issue - this change will fix a hard issue, whereas that refers to general slowness.
@bsclifton bsclifton modified the milestones: 0.22.x (Developer Channel), 0.20.x Release 3 (Hotfix) Feb 25, 2018
ryanml pushed a commit to ryanml/browser-laptop that referenced this issue Feb 27, 2018
This was causing an error to be thrown for every subsequent action, and no more state updates to be sent to windows, resulting in multiple issues.
It was also causing an error dump to be generated upon every action, thus halting the browser at those times, including any audio/video (and creating stutters).

Fix brave#13079 (main test case with STR)
Fix brave#12333
Fix brave#12828
Fix brave#13157
Address brave#13087 but this is a broad issue - this change will fix a hard issue, whereas that refers to general slowness.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
misc/button priority/P1 Blocks development or testing. Product cannot run. Must be fixed immediately, shipped next release. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include usability
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants