Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Reload is not working #12375

Closed
bsclifton opened this issue Dec 22, 2017 · 0 comments
Closed

Reload is not working #12375

bsclifton opened this issue Dec 22, 2017 · 0 comments

Comments

@bsclifton
Copy link
Member

Description

Reload in packaged builds is not working

  • Cmd + R
  • Clicking reload button
  • Right click reload button, choose reload context menu
  • etc

(originally captured with #10354)

Root cause can be found here:

reload: function tabActionsReload (tabId, ignoreCache) {
dispatchAction(tabActions.reload.name, {

When packaged build happens, the name is lost and it will try to execute "reload" instead of "tabActionsReload"

Steps to Reproduce

  1. Launch Brave 0.20.9
  2. Load page
  3. Click reload button

Actual result:

Nothing happens

Expected result:
Page should reload

Reproduces how often:

100%

Brave Version

0.20.9

about:brave info:

Reproducible on current live release:

Additional Information

@bsclifton bsclifton added this to the 0.20.x (Beta Channel) milestone Dec 22, 2017
@luixxiul luixxiul added the bug label Dec 22, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Dec 22, 2017
Resolves brave#12375

Auditors:

Test Plan:
@NejcZdovc NejcZdovc mentioned this issue Dec 22, 2017
10 tasks
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Dec 22, 2017
Resolves brave#12375

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Dec 22, 2017
Resolves brave#12375

Auditors:

Test Plan:
bsclifton added a commit that referenced this issue Dec 22, 2017
bsclifton added a commit that referenced this issue Dec 22, 2017
bsclifton added a commit that referenced this issue Dec 22, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.