Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

not prompted to save Contribution Statement #12385

Closed
LaurenWags opened this issue Dec 22, 2017 · 2 comments
Closed

not prompted to save Contribution Statement #12385

LaurenWags opened this issue Dec 22, 2017 · 2 comments
Assignees
@diracdeltas @petemill
Labels
0.20.x issue first seen in 0.20.x bug feature/rewards QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release-notes/exclude
Milestone
0.20.x (Release C...

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Dec 22, 2017 •
edited by srirambv
Loading

Test plan

  1. Add simulated payment history
  2. Open payment history and click on a link
  3. Contribution statement should open in a new tab and should prompt to save it

Description

When clicking on a link for Contribution Statement from Payment History, you are not prompted to save your Contribution Statement.

Steps to Reproduce

  1. Had a profile with 0.20.10 (packaged build) where payments were enabled, closed Brave.
  2. Renamed profile to be brave-development.
  3. Built 0.20.x from source.
  4. Ran npm run add-simulated-payment-history.
  5. Renamed brave-development back to brave-beta.
  6. Opened 0.20.10 (packaged build) again.
  7. Went to about:preferences#payments.
  8. Opened payment history and clicked on a link.
  9. On the new tab that opened with the contribution statement, I was not prompted to save my statement.

Actual result:
I was not prompted to save the statement that opened.

contrib-statement-02010

Expected result:
Should have been prompted to save statement as in 0.19.122

contrib-statement-019122

Reproduces how often:
Easily

Brave Version

about:brave info:
Brave | 0.20.10
V8 | 6.3.292.48
rev | 313dbc6
Muon | 4.5.31

Reproducible on current live release:
no, not on 0.19.122

Additional Information

Maybe similar to #11471 ? Or possibly related to #12381 ?
@LaurenWags LaurenWags added this to the 0.20.x (Beta Channel) milestone Dec 22, 2017
@bsclifton bsclifton changed the title not prompted to save Contribution Satement not prompted to save Contribution Statement Dec 23, 2017
@petemill petemill self-assigned this Dec 27, 2017
@petemill
Copy link
Member

Possibly related to https://github.com/brave/browser-laptop/blob/master/app/pdfJS.js#L55

Should be details.resourceType === 'mainFrame'

@diracdeltas diracdeltas self-assigned this Dec 27, 2017
diracdeltas added a commit that referenced this issue Dec 27, 2017
@diracdeltas
Fix some PDF handing bugs
f0cdf9a 
1. Fix resourceType check for session.webRequest
2. Fix #12385 (due to module path being unresolvable)

Test Plan:
0. Enable payments. Close Brave.
1. npm run add-simulated-payment-history
2. Go to Brave payments, open your contribution history.
3. Click on a PDF file in your contribution history. It should offer to save the file.
@diracdeltas diracdeltas mentioned this issue Dec 27, 2017
Merged
10 tasks
@petemill
Copy link
Member

Fixed by #11531

@LaurenWags LaurenWags mentioned this issue Jan 22, 2018
Closed
34 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@diracdeltas diracdeltas

@petemill petemill

Labels
0.20.x issue first seen in 0.20.x bug feature/rewards QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release-notes/exclude
Projects
None yet
Milestone
0.20.x (Release Channel)
Development

No branches or pull requests
6 participants
@diracdeltas @petemill @kjozwiak @bsclifton @srirambv @LaurenWags