Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

revoked SSL cert not showing cert error for some users #12510

Closed
diracdeltas opened this issue Jan 5, 2018 · 7 comments
Closed

revoked SSL cert not showing cert error for some users #12510

diracdeltas opened this issue Jan 5, 2018 · 7 comments
Assignees
@diracdeltas @bsclifton
Labels
fixed-with-brave-core This issue will automatically resolved with the replacement of Muon with Brave Core. post-v1 We don't expect to be able to resolve this before releasing v1.0 with Brave Core (instead of Muon). priority/P1 Blocks development or testing. Product cannot run. Must be fixed immediately, shipped next release. release/blocking security wontfix

Comments

@diracdeltas
Copy link
Member

https://revoked.badssl.com/ does not show a cert error for me on 0.19.x or master, but it does show an error (expected) for @jumde. I am on El Cap.
@diracdeltas diracdeltas added needs-investigation A bug not 100% confirmed/fixed that needs QA to better audit. security labels Jan 5, 2018
@jumde
Copy link
Contributor

jumde commented Jan 5, 2018 •
edited
Loading

From @petemill :

  • shows error on master / macOS 10.13.2
  • does not show error on master / ubuntu 16.04 and master / win10

@diracdeltas diracdeltas self-assigned this Jan 8, 2018
@diracdeltas diracdeltas added this to the 0.20.x (Beta Channel) milestone Jan 8, 2018
@diracdeltas diracdeltas added release/blocking and removed needs-investigation A bug not 100% confirmed/fixed that needs QA to better audit. labels Jan 8, 2018
@diracdeltas
Copy link
Member Author

waiting on new muon build

diracdeltas added a commit to brave/muon that referenced this issue Jan 9, 2018
@diracdeltas
Allow rev_checking_enabled to be true in muon
bc6bc68 
Needed for brave/browser-laptop#12510
@diracdeltas diracdeltas mentioned this issue Jan 9, 2018
Merged
diracdeltas added a commit to brave/muon that referenced this issue Jan 9, 2018
@diracdeltas
Allow rev_checking_enabled to be true in muon
dc9925d 
Needed for brave/browser-laptop#12510
diracdeltas added a commit to brave/muon that referenced this issue Jan 11, 2018
@diracdeltas
Allow rev_checking_enabled to be true in muon
aae8373 
needed for brave/browser-laptop#12510
@bsclifton
Copy link
Member

Waiting for review / merge via brave/muon#431

@bsclifton
Copy link
Member

bsclifton commented Jan 16, 2018 •
edited
Loading

@diracdeltas the Muon side is tagged for Muon 4.6.x. Should this be moved to a future release? (maybe the tentative 0.20.x hotfix 1 milestone?)

We are pulling in some 4.6 changes for Chromium 64... so we could patch on top of that (which is being tested with 0.19.x at the moment). Would need some help from @bridiver

@diracdeltas
Copy link
Member Author

@bsclifton my local mac muon build hasn't been working in a while but i will try to test out the PR today. moving to hotfix for now

@diracdeltas diracdeltas modified the milestones: 0.20.x (Beta Channel), 0.20.x Hotfix 1 Jan 16, 2018
@alexwykoff alexwykoff added the priority/P1 Blocks development or testing. Product cannot run. Must be fixed immediately, shipped next release. label Jan 30, 2018
@alexwykoff alexwykoff modified the milestones: 0.20.x Hotfix 3 (Ledger improvments), 0.21.x (Beta Channel) Feb 6, 2018
@bsclifton
Copy link
Member

@diracdeltas @jumde the muon PR (brave/muon#431) was merged; anything else needed in browser-laptop for this to be complete?

@diracdeltas
Copy link
Member Author

the Muon PR doesn't actually fix the issue

@diracdeltas diracdeltas modified the milestones: 0.21.x (Beta Channel), 0.22.x (Developer Channel) Feb 20, 2018
@bbondy bbondy modified the milestones: 0.22.x (Developer Channel), 0.23.x (Nightly Channel) Feb 25, 2018
@alexwykoff alexwykoff modified the milestones: 0.23.x (Nightly Channel), Backlog (Prioritized) Mar 13, 2018
@tildelowengrimm tildelowengrimm added the post-v1 We don't expect to be able to resolve this before releasing v1.0 with Brave Core (instead of Muon). label Apr 2, 2018
@diracdeltas diracdeltas mentioned this issue Jul 10, 2018
Closed
@bsclifton bsclifton modified the milestones: Backlog (Prioritized), Triage Backlog Sep 18, 2018
@bsclifton bsclifton added wontfix fixed-with-brave-core This issue will automatically resolved with the replacement of Muon with Brave Core. labels Sep 18, 2018
@bsclifton bsclifton removed this from the Triage Backlog milestone Sep 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@diracdeltas diracdeltas

@bsclifton bsclifton

Labels
fixed-with-brave-core This issue will automatically resolved with the replacement of Muon with Brave Core. post-v1 We don't expect to be able to resolve this before releasing v1.0 with Brave Core (instead of Muon). priority/P1 Blocks development or testing. Product cannot run. Must be fixed immediately, shipped next release. release/blocking security wontfix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@diracdeltas @tildelowengrimm @bbondy @alexwykoff @jumde @bsclifton