Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

"Always show the URL bar" text missing in preferences #12559

Closed
cndouglas opened this issue Jan 9, 2018 · 3 comments
Closed

"Always show the URL bar" text missing in preferences #12559

cndouglas opened this issue Jan 9, 2018 · 3 comments
Assignees
@bsclifton
Labels
bug copy/content/text priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.19.x Hotfix 12 ...

Comments

@cndouglas
Copy link

cndouglas commented Jan 9, 2018 •
edited by srirambv
Loading

Test Plan

  1. Open Brave and navigate to Preferences>Advanced> URL bar options
  2. Always show the URL bar text should be shown

Description

Look in Preferences > Advanced > URL Bar Options. There is an option titled disableTitleMode, which is the localization variable name. In English, the localized text should be Always show the URL bar (source). As far as I can tell, this only happens with English. I tried Spanish and French, and it looks fine.

Steps to Reproduce

  1. Open Brave and navigate to Preferences > Advanced > URL Bar Options.
  2. Look at the options in that screen.

Actual result:
There is an option titled disableTitleMode.

Expected result:
The option should be titled Always show the URL bar.

Reproduces how often:
Always, if using English.

Brave Version

about:brave info:

Brave: 0.19.131
rev: da2f347
Muon: 4.5.36
libchromiumcontent: 63.0.3239.132
V8: 6.3.292.49
Node.js: 7.9.0
Update Channel: Release
OS Platform: macOS
OS Release: 17.3.0
OS Architecture: x64

Reproducible on current live release:
Yes, 0.19.131.

Additional Information

I think it changed between 0.19 hotfixes 10 (0.19.123) and 11 (0.19.131), but I'm not sure.
@srirambv srirambv added bug copy/content/text priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). labels Jan 9, 2018
@srirambv srirambv added this to the 0.20.x (Beta Channel) milestone Jan 9, 2018
@cezaraugusto
Copy link
Contributor

can't repro on 0.20.16 @liunkae @srirambv could you please confirm?

@bsclifton bsclifton modified the milestones: 0.20.x (Beta Channel), 0.19.x Hotfix 12 Jan 9, 2018
@cndouglas
Copy link
Author

I cannot repro on 0.20.16 either. Looks like it's confined to 0.19.x.

bsclifton added a commit that referenced this issue Jan 9, 2018
@bsclifton
Re-add disableTitleMode string
832e1fd 
(Accidentally removed with e2d0ed6)

Fixes #12559

Auditors: @diracdeltas
@bsclifton
Copy link
Member

Only impacted 0.19.x (accidentally removed with e2d0ed6)

Fixed with 832e1fd

This was referenced Jan 11, 2018
Closed
Closed
Closed
@kjozwiak kjozwiak mentioned this issue Jan 12, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bsclifton bsclifton

Labels
bug copy/content/text priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.19.x Hotfix 12 (Release Channel)
Development

No branches or pull requests
6 participants
@kjozwiak @cezaraugusto @bsclifton @srirambv @cndouglas @LaurenWags