Skip to content
This repository was archived by the owner on Dec 11, 2019. It is now read-only.

Closing fixed-width tabs and then moving mouse away animates tabs past bounds of tab-bar #12566

Closed
petemill opened this issue Jan 9, 2018 · 5 comments · Fixed by #12567 or #12719
Closed

Closing fixed-width tabs and then moving mouse away animates tabs past bounds of tab-bar #12566

petemill opened this issue Jan 9, 2018 · 5 comments · Fixed by #12567 or #12719
Assignees
@petemill
Labels
bug feature/tabsbar QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Milestone
0.23.x (Release C...

Comments

@petemill
Copy link
Member

petemill commented Jan 9, 2018

Description

Bug introduced by #11438 and reported by @luixxiul in #11438 (comment)

Steps to Reproduce

from #11438 (comment)

  1. Open 10 tabs (until the tab size changes)
  2. Click the close button on a tab
  3. Move the mouse cursor from the tabs bar

tabs

Should animate to final width, not too wide and then back to final width.

Reproduces how often:
100% on master

Brave Version

about:brave info:
0.22

Reproducible on current live release:
No

Additional Information
@petemill petemill added this to the 0.22.x (Nightly Channel) milestone Jan 9, 2018
@petemill petemill self-assigned this Jan 9, 2018
petemill added a commit to petemill/browser-laptop that referenced this issue Jan 9, 2018
@petemill
Fix tabs briefly animating too wide after finishing closing some tabs
7ba0513 
Fix brave#12566

Since each tab's 'fixed width' was being removed at the same time, each one was measuring the width whilst other tab(s) were / were not reset eback to a fluid width, causing measurements to be off.
Flex supports transitions / animations by default, so we do not need to measure the element ourselves in this case, anyway.
Bonus for being able to move from in-component animation to purely defined in styles.
@petemill petemill mentioned this issue Jan 9, 2018
Merged
10 tasks
@petemill
Copy link
Member Author

#12567 does not cater for pinned tabs, or for multiple tab pages. Reverting that and reopening this issue...

@petemill petemill reopened this Jan 19, 2018
petemill added a commit that referenced this issue Jan 19, 2018
@petemill
Fix tabs briefly animating too wide after finishing closing some tabs…
ab8080e 
… or when multiple tab pages exist

Fix #12566

Since each tab's 'fixed width' was being removed at the same time, each one was measuring the width whilst other tab(s) were / were not reset back to a fluid width, causing measurements to be off.
Flex supports transitions / animations by default, so we do not need to measure the element ourselves in this case, anyway.
Also prevents pinned tabs from fixing tab width and prevents fixing tab width when tab page remains full.
@petemill petemill mentioned this issue Jan 19, 2018
Merged
10 tasks
petemill added a commit that referenced this issue Jan 19, 2018
@petemill
Fix tabs briefly animating too wide after finishing closing some tabs…
a650bff 
… or when multiple tab pages exist

Fix #12566

Since each tab's 'fixed width' was being removed at the same time, each one was measuring the width whilst other tab(s) were / were not reset back to a fluid width, causing measurements to be off.
Flex supports transitions / animations by default, so we do not need to measure the element ourselves in this case, anyway.
Also prevents pinned tabs from fixing tab width and prevents fixing tab width when tab page remains full.
@bbondy bbondy modified the milestones: 0.22.x (Developer Channel), 0.23.x (Nightly Channel) Feb 25, 2018
This was referenced Jun 11, 2018
Closed
Closed
Closed
This was referenced Jun 19, 2018
Closed
Closed
Closed
@srirambv
Copy link
Collaborator

srirambv commented Jun 20, 2018 •
edited by btlechowski
Loading

Verified on Windows 10 x64 using

  • 0.23.11 - 6565c06
  • Muon - 7.1.0
  • libchromiumcontent - 67.0.3396.87

Verified on Ubuntu 17.10 x64

  • 0.23.11 - 6565c06
  • Muon - 7.1.0
  • libchromiumcontent - 67.0.3396.87

Verified on Ubuntu 17.10 x64

  • 0.23.17 - bc754eb
  • Muon - 7.1.2
  • libchromiumcontent - 67.0.3396.87

This was referenced Jun 21, 2018
Closed
Closed
@LaurenWags
Copy link
Member

@petemill still experiencing this on 0.23.14, reproduced by @srirambv

@LaurenWags LaurenWags reopened this Jun 22, 2018
@bsclifton
Copy link
Member

This should be fixed in our next build- closing so that it can be retested 😄

This was referenced Jun 25, 2018
Closed
Closed
Closed
@srirambv
Copy link
Collaborator

srirambv commented Jun 25, 2018 •
edited by btlechowski
Loading

Verified on Windows 10 x64 using

  • 0.23.16 - 2042c45
  • Muon - 7.1.1
  • libchromiumcontent - 67.0.3396.87

Verified with macOS 10.12.6 using

  • 0.23.16 2042c45
  • Muon 7.1.1
  • libchromiumcontent 67.0.3396.87

Verified on Ubuntu 17.10 x64

  • 0.23.17 - bc754eb
  • Muon - 7.1.2
  • libchromiumcontent - 67.0.3396.87

@srirambv srirambv mentioned this issue Jun 25, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@petemill petemill

Labels
bug feature/tabsbar QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Projects
None yet
Milestone
0.23.x (Release Channel)
7 participants
@petemill @bbondy @kjozwiak @bsclifton @srirambv @LaurenWags @btlechowski