Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Multiple issue with top tiles removal in new tab page #12568

Closed
srirambv opened this issue Jan 9, 2018 · 1 comment
Closed

Multiple issue with top tiles removal in new tab page #12568

srirambv opened this issue Jan 9, 2018 · 1 comment
Assignees
Labels
0.20.x issue first seen in 0.20.x bug duplicate Issue has already been reported feature/newtab feature/topsites priority/P4 Minor loss of function. Workaround usually present. regression

Comments

@srirambv
Copy link
Collaborator

srirambv commented Jan 9, 2018

Description

Multiple issue with top tiles in new tab page

  1. Pinned tile cannot be closed without unpinning it first
  2. Unpinning a tile and closing it doesn't close but show the restore message
  3. Closing a different tile after unpinning the pinned tile causes the previous tile to be removed

Steps to Reproduce

Scenario 1 & 2

  1. Clean install 0.20.16
  2. Click on remove button on the pinned tile, nothing happens, message is shown that its removed but tile is still retained
  3. Close browser and restart, tile is still present

Scenario 3

  1. Clean install 0.20.16
  2. Unpin the pinned tile and close the tile nothing happens
  3. Remove the second tile next to the unpinned tile, removes the pinned tile which was unpinned
  4. Remove the third tile, removes the second tile (which is now the first tile)

Scenario 4

  1. Clean install 0.20.16
  2. Remove all tiles and on the notification click Restore all tiles, nothing is restored
  3. Close browser and restart, all tiles are restored

Actual result:
pinnedtile

Expected result:

  1. Should be able to close the pinned tile without having to unpin
  2. Unpinning a tile and removing it should remove the tile instantly
  3. Close should remove the tile on which the close button is clicked
  4. Clicking on restore all tile should immediately restore the tiles and not wait for browser restart

Reproduces how often:
100%

Brave Version

about:brave info:

Brave 0.20.16
V8 6.3.292.49
rev 0c42d0b
Muon 4.5.36
OS Release 10.0.16299
Update Channel Beta
OS Architecture x64
OS Platform Microsoft Windows
Node.js 7.9.0
Brave Sync v1.4.2
libchromiumcontent 63.0.3239.132

Reproducible on current live release:
No

Additional Information

Even after clicking the remove tile button and waiting for ~10secs the pinned tile isn't removed. Same after browser restart. Unpinned tiles doesn't get removed until browser restart.
Found while testing #12470 for top tiles
cc: @kjozwiak @LaurenWags @bsclifton

@srirambv srirambv added this to the 0.20.x (Beta Channel) milestone Jan 9, 2018
@cezaraugusto cezaraugusto changed the title Multiple issue with top tiles in new tab page Multiple issue with top tiles removal in new tab page Jan 9, 2018
@alexwykoff alexwykoff added the priority/P4 Minor loss of function. Workaround usually present. label Jan 9, 2018
@bsclifton
Copy link
Member

Closing as a dupe of #10411

@bsclifton bsclifton removed this from the 0.20.x (Beta Channel) milestone Jan 11, 2018
@bsclifton bsclifton added the duplicate Issue has already been reported label Jan 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
0.20.x issue first seen in 0.20.x bug duplicate Issue has already been reported feature/newtab feature/topsites priority/P4 Minor loss of function. Workaround usually present. regression
Projects
None yet
Development

No branches or pull requests

4 participants