Removing top site tiles is buggy

[cndouglas]

Test Plan

#12806 (comment)

1. Visit few sites
2. Open the dashboard page in a new tab.
3. Click the "X" button to remove any page tile.
4. The tile should be removed immediately.

---

• Did you search for similar issues before submitting this one?
  Yes.

• Describe the issue you encountered:
  When I try to remove top site tiles on the dashboard page, the tile is not removed immediately. It sometimes gets removed later randomly, when I navigate to another website, open a new tab, etc. Sometimes it does not get removed even after trying multiple things. Refreshing the dashboard page does not help.

• Platform (Win7, 8, 10? macOS? Linux distro?):
  macOS 10.12.x

• Brave Version (revision SHA):
  0.18.21 (263b6d5). I've had this problem for several major versions.

• Steps to reproduce:

  1. Visit any site.
  2. Open the dashboard page in a new tab.
  3. Click the "X" button to remove any page tile.

• Actual result:
  The tile is not removed immediately.

• Expected result:
  The tile should be removed immediately.

• Will the steps above reproduce in a fresh profile? If not what other info can be added?
  Not sure.

• Is this an issue in the currently released version?
  I think I've had the problem throughout 0.18.x, so yes.

• Can this issue be consistently reproduced?
  Almost all the time.

• Extra QA steps:

  1. Visit any site.
  2. Open the dashboard page in a new tab.
  3. Click the "X" button to remove any page tile.
  4. Make sure the tile is removed immediately.

• Screenshot if needed:
  None.

• Any related issues:
  None.

[Jacalz]

+1 from me, Noticed this in 0.18.21 today

[NejcZdovc]

We added 5s delay for generating topSites https://github.com/brave/browser-laptop/blob/master/app/browser/api/topSites.js#L143. We optimised this in version 0.21, so it should be better

[LaurenWags]

+1 from me, I repro'd today with 0.18.23

[LaurenWags]

Added regression label and milestone, this is working in 0.18.14.

[NejcZdovc]

@LaurenWags this is not a regression, we added that intentionally (this 5s delay), so I wouldn't add this to the 0.18 hotfix

[LaurenWags]

ok, since my tiles aren't being removed at all (like they were in previous version) I thought it was a regression. will remove milestone.

[NejcZdovc]

if they are not removed at all, then this is a regression, but would still put it into 0.19 and not block 0.18 on it

[NejcZdovc]

+1 from #10576

[iuphero]

+1 Same problem

[NejcZdovc]

+1 from #10622

[alexwykoff]

This needs some design and engineering consideration @bradleyrichter

[Cyrkhan]

Quite different question, nevertheless also regarding dashboard's tabs : how to add new tiles or replacing default tiles by new ones ? I observed that when I set Brave to erase histories, caches or cookies at shutdown, the dashboard shows no more any tile, even the default ones (Twitter, Facebook and so on), but I cannot add new tiles, or don't know how to proceed.

[bsclifton]

@Cyrkhan #7742 is the issue capturing adding new tiles and showing more tiles (with some discussion already, including a prototype of what adding a site would look like). We'd love to hear your comments 😄

[Jacalz]

+1 from community https://community.brave.com/t/dashboard-thumbs-not-deleting/6931/2

[NejcZdovc]

+1 from #10750

[pongraczi]

+1 Linuxmint 17 64 bit, Mate desktop, Brave | 0.18.23 rev | 36ae2ec

Customization of tiles (I hate that word, it has windows feeling), including user specified icons support and removing default icons once and forever.

[LaurenWags]

+1 from twitter - https://twitter.com/DisinfectantIII/status/905760552332472321

[jonathansampson]

+1 from twitter: https://twitter.com/DynCorpKidsClub/status/907426559388262402

[luixxiul]

manually tried, it look good to me 👍

[LaurenWags]

On MacOS - I click the X, wait 5-10s, nothing happens (tile is not removed). I open a new tab, click the x again, now the tile is removed:

[bsclifton]

+1 from @srirambv via #12568

[LaurenWags]

Reopening - removed tile is not replaced after it is removed.

STR: so my steps were: clean profile. visit 6 different sites. open new tab with dashboard. see 1 pinned tile (default) and 5 unpinned new tiles for a total of 6 tiles. click the x for one of the new tiles. now you have 5 tiles (1 pinned and 4 un-pinned). visit 7th new site. open new tab with dashboard. Still have 5 tiles on new tab page. Close/Restart Brave. Still have 5 tiles on new tab page.