Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

monthly budget reverts from 5.0 BAT -> 25 BAT when restarting #12581

Closed
kjozwiak opened this issue Jan 10, 2018 · 1 comment
Closed

monthly budget reverts from 5.0 BAT -> 25 BAT when restarting #12581

kjozwiak opened this issue Jan 10, 2018 · 1 comment
Assignees
@NejcZdovc
Labels
0.19.x issue first seen in 0.19.x bug feature/rewards QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release-notes/include
Milestone
0.19.x Hotfix 12 ...

Comments

@kjozwiak
Copy link
Member

kjozwiak commented Jan 10, 2018 •
edited by srirambv
Loading

Test Plan

  1. Launch 0.19.x and enable payments via about:preferences#payments
  2. Select 5.0 BAT as the monthly budget
  3. Restart the browser and ensure the monthly budget remains 5.0 BAT

Description

When a user has selected 5.0 BAT as the default monthly budget under about:preferences#payments, the value will be reverted back to 25 BAT when the browser is closed/restarted.

Steps to Reproduce

  1. launch 0.19.131 and enable payments via about:preferences#payments
  2. select 5.0 BAT as the monthly budget
  3. restart the browser and you'll notice that the monthly budget was reverted back to 25 BAT

Actual result:

The monthly budget will be reverted back to 25 BAT if 5 BAT is being used as the default

paymentsissue

Expected result:

Users default monthly budget shouldn't be reverted when restarting the browser.

Reproduces how often:

100% when using the above STR mentioned above.

Brave Version

about:brave info:

Brave: 0.19.131
rev: da2f347
Muon: 4.5.36
libchromiumcontent: 63.0.3239.132

Reproducible on current live release:

N/A as 5.0 BAT as a monthly budget was introduced in 0.19.131

Additional Information

  • Win 10 x64 - Reproducible
  • macOS 10.13.2 x64 - Reproducible
  • Ubuntu 17.10 x64 - Reproducible
@kjozwiak kjozwiak added bug feature/rewards 0.19.x issue first seen in 0.19.x labels Jan 10, 2018
@kjozwiak kjozwiak added this to the 0.19.x Hotfix 12 milestone Jan 10, 2018
@NejcZdovc NejcZdovc self-assigned this Jan 10, 2018
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jan 10, 2018
@NejcZdovc
Fixes default value after restart
cdabe66 
Resolves brave#12581

Auditors:

Test Plan:
@NejcZdovc NejcZdovc mentioned this issue Jan 10, 2018
Merged
10 tasks
bsclifton added a commit that referenced this issue Jan 10, 2018
@bsclifton
Merge pull request #12588 from NejcZdovc/hotfix/#12581-default
e0af1e8 
Fixes default value after restart
bsclifton added a commit that referenced this issue Jan 10, 2018
@bsclifton
Merge pull request #12588 from NejcZdovc/hotfix/#12581-default
8a1f3bd 
Fixes default value after restart
bsclifton added a commit that referenced this issue Jan 10, 2018
@bsclifton
Merge pull request #12588 from NejcZdovc/hotfix/#12581-default
03ef1f5 
Fixes default value after restart
bsclifton added a commit that referenced this issue Jan 10, 2018
@bsclifton
Merge pull request #12588 from NejcZdovc/hotfix/#12581-default
1d421cd 
Fixes default value after restart
This was referenced Jan 11, 2018
Closed
Closed
Closed
@kjozwiak kjozwiak mentioned this issue Jan 12, 2018
Closed
@kjozwiak
Copy link
Member Author

@LaurenWags and myself ran through these cases once again with 0.19.134 which included the following change:

  • changing default from 5.0 BAT to 7.5 BAT

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
0.19.x issue first seen in 0.19.x bug feature/rewards QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release-notes/include
Projects
None yet
Milestone
0.19.x Hotfix 12 (Release Channel)
Development

No branches or pull requests
4 participants
@kjozwiak @NejcZdovc @srirambv @LaurenWags