Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Browser should poll server for UGP promo whenever payments prefs is opened #12688

Closed
davidtemkin opened this issue Jan 17, 2018 · 3 comments · Fixed by #13078
Closed

Browser should poll server for UGP promo whenever payments prefs is opened #12688

davidtemkin opened this issue Jan 17, 2018 · 3 comments · Fixed by #13078
Assignees
@NejcZdovc
Labels
0.21.x issue first seen in 0.21.x feature/rewards QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Milestone
0.21.x (Release C...

Comments

@davidtemkin
Copy link

davidtemkin commented Jan 17, 2018 •
edited by LaurenWags
Loading

Test Plan

#13078

Currently Brave only checks to see if a UGP promotion is active at browser startup time and at 24 hour intervals. The effect of this is that users who hear about a newly-launched promo are not able to take advantage of it without one of a few unappealing actions (wait 24 hours; turn payments on/off; restart the browser).

In order to satisfy users who have just heard about a new UGP promo (e.g. via an announcement, press, social media) and want to immediately accept the token grant, the browser should poll the server to see if a promo is active whenever a user opens payments preferences.
@kjozwiak
Copy link
Member

kjozwiak commented Jan 17, 2018 •
edited
Loading

Is this urgent enough to push into hotfix13 https://github.com/brave/browser-laptop/milestone/98 which includes C64?

@davidtemkin
Copy link
Author

No, I don't think so. For the current promo, it wouldn't help, because more than 24 hours will have passed since the promo went live (i.e., all browsers will poll the server) before any update is released.

@NejcZdovc NejcZdovc added this to the 0.20.x Hotfix 3 (Ledger improvments) milestone Feb 6, 2018
@alexwykoff alexwykoff modified the milestones: 0.20.x Hotfix 3 (Ledger improvments), 0.21.x (Beta Channel) Feb 6, 2018
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Feb 9, 2018
@NejcZdovc
Adds promo check when opening payments tab
1629c03 
Resolves brave#12688

Auditors:

Test Plan:
@NejcZdovc NejcZdovc mentioned this issue Feb 9, 2018
Merged
10 tasks
bsclifton pushed a commit to NejcZdovc/browser-laptop that referenced this issue Feb 15, 2018
@NejcZdovc @bsclifton
Adds promo check when opening payments tab
d1a8e5d 
Resolves brave#12688

Auditors:

Test Plan:
bsclifton added a commit that referenced this issue Feb 15, 2018
@bsclifton
Merge pull request #13078 from NejcZdovc/hotfix/#12688-poll
c017bbb 
Adds promo check when opening payments tab
bsclifton added a commit that referenced this issue Feb 15, 2018
@bsclifton
Merge pull request #13078 from NejcZdovc/hotfix/#12688-poll
e8a67b3 
Adds promo check when opening payments tab
bsclifton added a commit that referenced this issue Feb 15, 2018
@bsclifton
Merge pull request #13078 from NejcZdovc/hotfix/#12688-poll
5210561 
Adds promo check when opening payments tab
@NejcZdovc NejcZdovc modified the milestones: 0.21.x (Beta Channel), 0.21.x (Twitch) Feb 24, 2018
NejcZdovc pushed a commit that referenced this issue Feb 24, 2018
@bsclifton @NejcZdovc
Merge pull request #13078 from NejcZdovc/hotfix/#12688-poll
8cc234f 
Adds promo check when opening payments tab
@LaurenWags
Copy link
Member

Removed QA/checked labels due to changes in milestones. Please recheck with 0.21.15 and higher.

ryanml pushed a commit to ryanml/browser-laptop that referenced this issue Feb 27, 2018
@NejcZdovc @ryanml
Adds promo check when opening payments tab
be5ec04 
Resolves brave#12688

Auditors:

Test Plan:
@srirambv srirambv added the 0.21.x issue first seen in 0.21.x label Feb 27, 2018
This was referenced Feb 27, 2018
Closed
Closed
Closed
@LaurenWags LaurenWags mentioned this issue Jul 13, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
0.21.x issue first seen in 0.21.x feature/rewards QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Projects
None yet
Milestone
0.21.x (Release Channel)
Development

Successfully merging a pull request may close this issue.

Adds promo check when opening payments tab NejcZdovc/browser-laptop