Skip to content
This repository was archived by the owner on Dec 11, 2019. It is now read-only.

BAT client should send user-agent to grant server #12714

Closed
diracdeltas opened this issue Jan 19, 2018 · 1 comment
Closed

BAT client should send user-agent to grant server #12714

diracdeltas opened this issue Jan 19, 2018 · 1 comment
Assignees
@diracdeltas
Labels
feature/rewards QA/no-qa-needed release-notes/include security
Milestone
0.20.x (Release C...

Comments

@diracdeltas
Copy link
Member

This is useful for UGP fraud detection. Currently js/lib/request.js by default does not send any UA.
@diracdeltas
Copy link
Member Author

cc @evq @davidtemkin @bsclifton @NejcZdovc for triage. i don't know what release this should go in, but it needs to be in place before the next grant promo is released.

@diracdeltas diracdeltas self-assigned this Jan 19, 2018
diracdeltas added a commit that referenced this issue Jan 19, 2018
@diracdeltas
Send user-agent information to ledger server
91b1855 
Goes with brave-intl/bat-ledger#122 for basic BAT
fraud detection.

Fix #12714

Test Plan:
1. Enable payments
2. Look at ledger server logs for the user-agent that is being sent when you enable payments and/or claim a BAT grant. (If you do not have access to ledger server logs, you can set the ledger server URL to some HTTP URL and use wireshark to inspect requests.)
3. Make sure the user-agent value is not empty
@diracdeltas diracdeltas mentioned this issue Jan 19, 2018
Merged
10 tasks
@diracdeltas diracdeltas added this to the 0.20.x (Beta Channel) milestone Jan 19, 2018
@bsclifton bsclifton changed the title ledger should sent user-agent to grant server BAT client should send user-agent to grant server Jan 23, 2018
@kjozwiak kjozwiak mentioned this issue Jan 31, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@diracdeltas diracdeltas

Labels
feature/rewards QA/no-qa-needed release-notes/include security
Projects
None yet
Milestone
0.20.x (Release Channel)
Development

No branches or pull requests
2 participants
@diracdeltas @bsclifton