Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Some favicons are distorted #12722

Closed
petemill opened this issue Jan 19, 2018 · 1 comment · Fixed by #12565
Closed

Some favicons are distorted #12722

petemill opened this issue Jan 19, 2018 · 1 comment · Fixed by #12565
Assignees
@petemill
Labels
feature/tabsbar initiative/ux-harmonization initiative/web-compat priority/P4 Minor loss of function. Workaround usually present. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include webcompat
Milestone
0.22.x (Release C...

Comments

@petemill
Copy link
Member

Description

Dark themed tabs apply a filter to favicons which often distorts them beyond recognition or does not fit in with the rest of Brave's flat(ter) visual style.

Steps to Reproduce

Ensure themed tabs are on (the default)

  1. Visit apple.com in active tab

Actual result:
Favicon is blurred beyond recognitino

Expected result:
Favicon is Apple logo

image

Reproduces how often:
100%

Brave Version

about:brave info:
0.19

Reproducible on current live release:
yes
@petemill petemill self-assigned this Jan 19, 2018
@petemill petemill mentioned this issue Jan 19, 2018
Merged
10 tasks
petemill added a commit to petemill/browser-laptop that referenced this issue Jan 22, 2018
@petemill
Adjust shadow filter on favicons on dark-color tabs
0923cfe 
Fix brave#12722
This was previously causing irregularities in brand icons.
petemill added a commit to petemill/browser-laptop that referenced this issue Jan 23, 2018
@petemill
Adjust shadow filter on favicons on dark-color tabs
9876113 
Fix brave#12722
This was previously causing irregularities in brand icons.
petemill added a commit that referenced this issue Jan 23, 2018
@petemill
Adjust shadow filter on favicons on dark-color tabs
fcf0441 
Fix #12722
This was previously causing irregularities in brand icons.
@NejcZdovc NejcZdovc added this to the 0.21.x (Beta Channel) milestone Feb 14, 2018
@bsclifton bsclifton modified the milestones: 0.21.x (Beta Channel), 0.22.x (Developer Channel) Feb 20, 2018
petemill added a commit that referenced this issue Feb 20, 2018
@petemill
Adjust shadow filter on favicons on dark-color tabs
626db53 
Fix #12722
This was previously causing irregularities in brand icons.
@bbondy bbondy modified the milestones: 0.22.x (Developer Channel), 0.23.x (Nightly Channel) Feb 25, 2018
petemill added a commit that referenced this issue Mar 3, 2018
@petemill
Adjust shadow filter on favicons on dark-color tabs
470f183 
Fix #12722
This was previously causing irregularities in brand icons.
@alexwykoff alexwykoff added the priority/P4 Minor loss of function. Workaround usually present. label Mar 13, 2018
@alexwykoff alexwykoff modified the milestones: 0.23.x (Nightly Channel), 0.22.x (Developer Channel) Mar 13, 2018
petemill added a commit to petemill/browser-laptop that referenced this issue Mar 15, 2018
@petemill
Adjust shadow filter on favicons on dark-color tabs
18ec20d 
Fix brave#12722
This was previously causing irregularities in brand icons.
petemill added a commit to petemill/browser-laptop that referenced this issue Mar 16, 2018
@petemill
Adjust shadow filter on favicons on dark-color tabs
c628bd4 
Fix brave#12722
This was previously causing irregularities in brand icons.
petemill added a commit that referenced this issue Mar 16, 2018
@petemill
Adjust shadow filter on favicons on dark-color tabs
7168c03 
Fix #12722
This was previously causing irregularities in brand icons.
petemill added a commit that referenced this issue Mar 16, 2018
@petemill
Adjust shadow filter on favicons on dark-color tabs
f37faad 
Fix #12722
This was previously causing irregularities in brand icons.
petemill added a commit that referenced this issue Mar 16, 2018
@petemill
Adjust shadow filter on favicons on dark-color tabs
8f25269 
Fix #12722
This was previously causing irregularities in brand icons.
@srirambv
Copy link
Collaborator

srirambv commented Mar 22, 2018 •
edited by btlechowski
Loading

Verified on Windows x64

  • 0.22.6 e6ff4ea
  • libchromiumcontent: 65.0.3325.162
  • muon: 5.1.0

Verified on macOS 10.12.6 x64 using the following build:

  • 0.22.6 e6ff4ea
  • libchromiumcontent: 65.0.3325.162
  • muon: 5.1.0

Verified on Ubuntu 10.10 x64

  • 0.22.7 8bb7e77
  • libchromiumcontent: 65.0.3325.181
  • muon: 5.1.1

@kjozwiak kjozwiak mentioned this issue Mar 29, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@petemill petemill

Labels
feature/tabsbar initiative/ux-harmonization initiative/web-compat priority/P4 Minor loss of function. Workaround usually present. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include webcompat
Projects
None yet
Milestone
0.22.x (Release Channel)
Development

Successfully merging a pull request may close this issue.

Tab style updates x 8 brave/browser-laptop
8 participants
@petemill @bbondy @alexwykoff @bsclifton @NejcZdovc @srirambv @LaurenWags @btlechowski