This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Theme color is displayed incorrectly due to transparency #12803
Assignees
Labels
bug
feature/tabsbar
priority/P4
Minor loss of function. Workaround usually present.
QA/checked-Linux
QA/checked-macOS
QA/checked-Win64
QA/test-plan-specified
release-notes/include
webcompat
Milestone
Comments
petemill
added a commit
that referenced
this issue
Jan 23, 2018
…the theme color rendering the same as in the content frame. Blend's the theme color with a white background, which is common in web content. Fix #12803
petemill
added a commit
that referenced
this issue
Jan 25, 2018
…the theme color rendering the same as in the content frame. Blend's the theme color with a white background, which is common in web content. Fix #12803
petemill
added a commit
that referenced
this issue
Feb 20, 2018
…the theme color rendering the same as in the content frame. Blend's the theme color with a white background, which is common in web content. Fix #12803
petemill
added a commit
that referenced
this issue
Mar 3, 2018
…the theme color rendering the same as in the content frame. Blend's the theme color with a white background, which is common in web content. Fix #12803
alexwykoff
added
the
priority/P4
alexwykoff
modified the milestones:
0.23.x (Nightly Channel),
0.22.x (Developer Channel)
petemill
added a commit
to petemill/browser-laptop
that referenced
this issue
Mar 15, 2018
…the theme color rendering the same as in the content frame. Blend's the theme color with a white background, which is common in web content. Fix brave#12803
petemill
added a commit
to petemill/browser-laptop
that referenced
this issue
Mar 16, 2018
…the theme color rendering the same as in the content frame. Blend's the theme color with a white background, which is common in web content. Fix brave#12803 Also do not throw error when parsing color and no valid value is found
petemill
added a commit
that referenced
this issue
Mar 16, 2018
…the theme color rendering the same as in the content frame. Blend's the theme color with a white background, which is common in web content. Fix #12803 Also do not throw error when parsing color and no valid value is found
petemill
added a commit
that referenced
this issue
Mar 16, 2018
…the theme color rendering the same as in the content frame. Blend's the theme color with a white background, which is common in web content. Fix #12803 Also do not throw error when parsing color and no valid value is found
petemill
added a commit
that referenced
this issue
Mar 16, 2018
…the theme color rendering the same as in the content frame. Blend's the theme color with a white background, which is common in web content. Fix #12803 Also do not throw error when parsing color and no valid value is found
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Description
If a theme color is provided with an alpha transparency channel, we preserve that transparency when displaying the theme color on the tab control background. This then causes the theme color to be blended with the tab bar background color, making the theme color match incorrectly.
Steps to Reproduce
Actual result:
Colors do not match
Expected result:
Colors match
Reproduces how often:
100%
Brave Version
about:brave info:
0.19 / 0.20
Reproducible on current live release:
👍
The text was updated successfully, but these errors were encountered: