Skip to content
This repository was archived by the owner on Dec 11, 2019. It is now read-only.

Move Ledger Deleted Sites List to a new dialog #12833

Closed
bradleyrichter opened this issue Jan 24, 2018 · 2 comments
Closed

Move Ledger Deleted Sites List to a new dialog #12833

bradleyrichter opened this issue Jan 24, 2018 · 2 comments
Assignees
@NejcZdovc
Labels
0.21.x issue first seen in 0.21.x design A design change, especially one which needs input from the design team. feature/rewards QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.21.x (Release C...

Comments

@bradleyrichter
Copy link
Contributor

As a user, I need more intuitive access to the sites I may have deleted from my Brave Payments list.

Currently, users are confused by the action of deletion and the location in prefs where these sites are managed.

A new link will be added to the bottom text navigation in the ledger list as shown:
(Show Deleted Sites)
image

Clicking this link will open a dialog with scrolling content:
image

The scrolling dialog will use the same list that is already maintained within the Prefs/Shields list.

A new feature with button "Clear All" will be added to assist in resetting the deleted sites list if needed.
@bradleyrichter bradleyrichter added design A design change, especially one which needs input from the design team. feature/rewards labels Jan 24, 2018
@bradleyrichter bradleyrichter added this to the 0.21.x (Developer Channel) milestone Jan 24, 2018
@NejcZdovc NejcZdovc mentioned this issue Feb 7, 2018
Merged
10 tasks
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Feb 7, 2018
@NejcZdovc
Moves Ledger deleted sites into payments page
d1a81b0 
Resolves brave#12833

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Feb 16, 2018
@NejcZdovc
Moves Ledger deleted sites into payments page
59b183f 
Resolves brave#12833

Auditors:

Test Plan:
bsclifton pushed a commit to NejcZdovc/browser-laptop that referenced this issue Feb 19, 2018
@NejcZdovc @bsclifton
Moves Ledger deleted sites into payments page
382b76f 
Resolves brave#12833

Auditors:

Test Plan:
bsclifton added a commit that referenced this issue Feb 19, 2018
@bsclifton
Merge pull request #13056 from NejcZdovc/feature/#12833-list
a0cfa58 
Moves Ledger Deleted Sites List to a new dialog
bsclifton added a commit that referenced this issue Feb 19, 2018
@bsclifton
Merge pull request #13056 from NejcZdovc/feature/#12833-list
7aedbb3 
Moves Ledger Deleted Sites List to a new dialog
NejcZdovc pushed a commit that referenced this issue Feb 19, 2018
@bsclifton @NejcZdovc
Merge pull request #13056 from NejcZdovc/feature/#12833-list
914ec89 
Moves Ledger Deleted Sites List to a new dialog
@LaurenWags LaurenWags mentioned this issue Feb 23, 2018
Closed
@NejcZdovc NejcZdovc modified the milestones: 0.21.x (Beta Channel), 0.21.x (Twitch) Feb 24, 2018
NejcZdovc pushed a commit that referenced this issue Feb 24, 2018
@bsclifton @NejcZdovc
Merge pull request #13056 from NejcZdovc/feature/#12833-list
2a58dc2 
Moves Ledger Deleted Sites List to a new dialog
@LaurenWags
Copy link
Member

Removed QA/checked labels due to changes in milestones. Please recheck with 0.21.15 and higher.

ryanml pushed a commit to ryanml/browser-laptop that referenced this issue Feb 27, 2018
@NejcZdovc @ryanml
Moves Ledger deleted sites into payments page
131af82 
Resolves brave#12833

Auditors:

Test Plan:
@srirambv srirambv added 0.21.x issue first seen in 0.21.x QA/checked-Win64 labels Feb 27, 2018
This was referenced Feb 27, 2018
Closed
Closed
@kjozwiak
Copy link
Member

Also checked the following under Linux 17.10 x64:

  • have around 20 removed websites being listed under about:preferences#shields using 0.20.46
  • update brave to 0.21.16 a7bed47
  • ensure that all the websites being listed under about:preferences#shields have been moved into the Deleted Sites within about:preferences#payments

@kjozwiak kjozwiak mentioned this issue Mar 1, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
0.21.x issue first seen in 0.21.x design A design change, especially one which needs input from the design team. feature/rewards QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.21.x (Release Channel)
Development

No branches or pull requests
6 participants
@kjozwiak @NejcZdovc @bradleyrichter @srirambv @LaurenWags @btlechowski