Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

publishers should not make requests to youtube, twitch, etc in the main process #13114

Closed
diracdeltas opened this issue Feb 13, 2018 · 5 comments
Closed

publishers should not make requests to youtube, twitch, etc in the main process #13114

diracdeltas opened this issue Feb 13, 2018 · 5 comments
Assignees
@diracdeltas @NejcZdovc
Labels
feature/rewards priority/P3 Major loss of function. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include security
Milestone
0.22.x (Release C...

Comments

@diracdeltas
Copy link
Member

diracdeltas commented Feb 13, 2018 •
edited by bsclifton
Loading

Test Plan:

  1. turn on Brave Payments
  2. browse Youtube for a while in a regular tab; the publishers should show up in the ledger payments panel, and favicons should appear
  3. repeat Step 2 for Twitch
  4. browse Youtube in a private tab; this time the publishers should not show up in the payments panel

Original issue description

related: #12938
@diracdeltas diracdeltas self-assigned this Feb 13, 2018
diracdeltas added a commit that referenced this issue Feb 13, 2018
@diracdeltas
Add publishers media info request API
e324721 
Needed for
brave-intl/bat-publisher#11 (review)
and #13114
@diracdeltas diracdeltas mentioned this issue Feb 13, 2018
Merged
10 tasks
@NejcZdovc NejcZdovc added this to the 0.22.x (Developer Channel) milestone Feb 26, 2018
NejcZdovc pushed a commit that referenced this issue Feb 26, 2018
@diracdeltas @NejcZdovc
Add publishers media info request API
36173db 
Needed for
brave-intl/bat-publisher#11 (review)
and #13114
@alexwykoff alexwykoff added the priority/P3 Major loss of function. label Feb 27, 2018
@alexwykoff alexwykoff modified the milestones: 0.22.x (Developer Channel), Backlog (Prioritized) Feb 27, 2018
@alexwykoff
Copy link
Contributor

@NejcZdovc - If we wish to change anything in bat-publisher, we'll need to land this too.

@NejcZdovc NejcZdovc modified the milestones: Backlog (Prioritized), 0.22.x (Developer Channel) Feb 28, 2018
@NejcZdovc NejcZdovc self-assigned this Feb 28, 2018
@NejcZdovc
Copy link
Contributor

changing this to 0.22, because #13330 is in 0.22 and this will have version increase

NejcZdovc pushed a commit that referenced this issue Mar 2, 2018
@diracdeltas @NejcZdovc
Add publishers media info request API
79dfa09 
Needed for
brave-intl/bat-publisher#11 (review)
and #13114
NejcZdovc pushed a commit that referenced this issue Mar 14, 2018
@diracdeltas @NejcZdovc
Add publishers media info request API
8bb9c4d 
Needed for
brave-intl/bat-publisher#11 (review)
and #13114
@NejcZdovc NejcZdovc modified the milestones: 0.22.x (Beta Channel), 0.21.x w/ Chromium 65 (Release Channel) Mar 19, 2018
@diracdeltas
Copy link
Member Author

diracdeltas commented Mar 19, 2018 •
edited
Loading

Test Plan:

  1. turn on Brave Payments
  2. browse Youtube for a while in a regular tab; the publishers should show up in the ledger payments panel, and favicons should appear
  3. repeat Step 2 for Twitch
  4. browse Youtube in a private tab; this time the publishers should not show up in the payments panel

@bsclifton bsclifton modified the milestones: 0.21.x w/ Chromium 65 (Release Channel), 0.22.x (Beta Channel) Mar 19, 2018
@bsclifton
Copy link
Member

moved to 0.22.x

This was referenced Mar 22, 2018
Closed
Closed
Closed
@srirambv
Copy link
Collaborator

srirambv commented Mar 22, 2018 •
edited by btlechowski
Loading

Verified on Windows x64

  • 0.22.6 e6ff4ea
  • libchromiumcontent: 65.0.3325.162
  • muon: 5.1.0

Verified on macOS 10.12.6 x64 using the following build:

  • 0.22.6 e6ff4ea
  • libchromiumcontent: 65.0.3325.162
  • muon: 5.1.0

Verified on Ubuntu 10.10 x64

  • 0.22.7 8bb7e77
  • libchromiumcontent: 65.0.3325.181
  • muon: 5.1.1

@kjozwiak kjozwiak mentioned this issue Mar 29, 2018
Closed
@diracdeltas diracdeltas mentioned this issue May 8, 2018
Closed
diracdeltas added a commit that referenced this issue May 8, 2018
@diracdeltas
add comment about metascraper untrusted input, sanitize HTML
a93fea1 
fix #14066

Test Plan:
follow test plan in #13114
to make sure there are no regressions
diracdeltas added a commit that referenced this issue May 8, 2018
@diracdeltas
add comment about metascraper untrusted input, sanitize HTML
94b507c 
fix #14066

Test Plan:
follow test plan in #13114
to make sure there are no regressions
@diracdeltas diracdeltas mentioned this issue May 8, 2018
Merged
10 tasks
diracdeltas added a commit that referenced this issue May 9, 2018
@diracdeltas
add comment about metascraper untrusted input, sanitize HTML
a5fb6e9 
fix #14066

Test Plan:
follow test plan in #13114
to make sure there are no regressions
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@diracdeltas diracdeltas

@NejcZdovc NejcZdovc

Labels
feature/rewards priority/P3 Major loss of function. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include security
Projects
None yet
Milestone
0.22.x (Release Channel)
Development

No branches or pull requests
7 participants
@diracdeltas @alexwykoff @bsclifton @NejcZdovc @srirambv @LaurenWags @btlechowski