Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

BraveBeta.exe process not always being terminated when closing Brave via title bar #13233

Closed
kjozwiak opened this issue Feb 21, 2018 · 7 comments · Fixed by #13242
Closed

BraveBeta.exe process not always being terminated when closing Brave via title bar #13233

kjozwiak opened this issue Feb 21, 2018 · 7 comments · Fixed by #13242
Assignees
@petemill
Labels
0.21.x issue first seen in 0.21.x bug OS/unix-like/linux OS/Windows QA/checked-Win64 QA/test-plan-specified regression release/blocking release-notes/exclude
Milestone
0.22.x (Release C...

Comments

@kjozwiak
Copy link
Member

kjozwiak commented Feb 21, 2018 •
edited by bsclifton
Loading

Description

@btlechowski (great find BTW 👍) found that when closing brave via the 'X' button under the title bar, the BraveBeta.exe process doesn't terminate which can lead to situations where clicking on the Brave shortcut on the desktop doesn't launch the application due to the process still running.

Test Plan / Steps to Reproduce

  1. launch 0.21.11 and open your favourite process explorer
  2. once launched, close brave using the X located on the title bar
  3. relaunch Brave

You'll notice that several BraveBeta.exe processes haven't been closed and are still running.

Actual result:

winprocesses

screen shot 2018-02-21 at 3 01 35 pm

Expected result:

All BraveBeta.exe process should be terminated correctly when Brave is closed.

Reproduces how often:

100% reproducible when following the STR mentioned above.

Brave Version

about:brave info:

Brave: 0.21.11 
V8: 6.4.388.41 
rev: e146cd88d6cc5c91f8e772a18cd6c604fe903f58 
Muon: 5.0.5 
OS Release: 10.0.16299 
Update Channel: Beta 
OS Architecture: x64 
OS Platform: Microsoft Windows 
Node.js: 7.9.0 
Brave Sync: v1.4.2 
libchromiumcontent: 64.0.3282.140

Reproducible on current live release:

Couldn't reproduce with the current release.

Additional Information
@kjozwiak kjozwiak added this to the 0.21.x (Beta Channel) milestone Feb 21, 2018
@kjozwiak kjozwiak changed the title BraveBeta.exe process not always being terminated when closing Brave BraveBeta.exe process not always being terminated when closing Brave via title bar Feb 21, 2018
@btlechowski
Copy link
Contributor

I am able to reproduce with 100% rate using these steps:
Steps:

  1. Clean install
  2. Open Brave
  3. Close Brave using titlebar's Close button (x)
  4. Check running processes for BraveBeta

Tested on Win7 x64

Brave: 0.21.11 
V8: 6.4.388.41 
rev: e146cd88d6cc5c91f8e772a18cd6c604fe903f58 
Muon: 5.0.5 
OS Release: 6.1.7601 
Update Channel: Beta 
OS Architecture: x64 
OS Platform: Microsoft Windows 
Node.js: 7.9.0 
Brave Sync: v1.4.2 
libchromiumcontent: 64.0.3282.140

@kjozwiak
Copy link
Member Author

Reproduced this on Ubuntu 17.10 x64 using 0.21.11 as well. Example:

screen shot 2018-02-21 at 3 56 23 pm

@petemill petemill self-assigned this Feb 21, 2018
@darkdh
Copy link
Member

darkdh commented Feb 21, 2018

reproducible using muon 5.0.0 and 4.8.2 so might be something wrong on browser-laptop

@petemill
Copy link
Member

Probably related to bufferWindow. We should exclude the buffer window from checking if all windows are closed.

petemill added a commit that referenced this issue Feb 21, 2018
@petemill
When closing last window, make sure buffer window is closed so that a…
95fd6c9 
…pp exits.

Only on win/linux, since we only handle 'window-all-closed' on those platforms.
Fix #13233
@petemill petemill mentioned this issue Feb 21, 2018
Merged
10 tasks
@petemill
Copy link
Member

Thanks for finding @btlechowski and @kjozwiak! A potential fix is pending in #13242.

bsclifton pushed a commit that referenced this issue Feb 22, 2018
@petemill @bsclifton
When closing last window, make sure buffer window is closed so that a…
97baf96 
…pp exits.

Only on win/linux, since we only handle 'window-all-closed' on those platforms.
Fix #13233
@bsclifton bsclifton mentioned this issue Feb 22, 2018
Closed
@srirambv
Copy link
Collaborator

Verified on Windows 10. No background process running when quit

This was referenced Feb 23, 2018
Closed
Closed
ryanml pushed a commit to ryanml/browser-laptop that referenced this issue Feb 27, 2018
@petemill @ryanml
When closing last window, make sure buffer window is closed so that a…
0936a67 
…pp exits.

Only on win/linux, since we only handle 'window-all-closed' on those platforms.
Fix brave#13233
@srirambv
Copy link
Collaborator

Verified on Windows x64

  • 0.22.6 e6ff4ea
  • libchromiumcontent: 65.0.3325.162
  • muon: 5.1.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@petemill petemill

Labels
0.21.x issue first seen in 0.21.x bug OS/unix-like/linux OS/Windows QA/checked-Win64 QA/test-plan-specified regression release/blocking release-notes/exclude
Projects
None yet
Milestone
0.22.x (Release Channel)
Development

Successfully merging a pull request may close this issue.

When closing last window, make sure buffer window is closed so that app exits brave/browser-laptop
7 participants
@petemill @kjozwiak @bsclifton @darkdh @srirambv @LaurenWags @btlechowski