Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Saved performance profile in Developer Tools is empty #13254

Closed
btlechowski opened this issue Feb 22, 2018 · 3 comments · Fixed by brave/muon#511
Closed

Saved performance profile in Developer Tools is empty #13254

btlechowski opened this issue Feb 22, 2018 · 3 comments · Fixed by brave/muon#511
Assignees
@darkdh
Labels
0.21.x issue first seen in 0.21.x feature/developer-tools feature/download QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release-notes/exclude
Milestone
0.22.x (Release C...

Comments

@btlechowski
Copy link
Contributor

Steps to Reproduce

  1. Open Developer Tools (F12) and Open Performance tab
  2. Click Record button and record for few seconds
  3. Save the profile

Actual result:

Profile file is created but has 0 size

Expected result:
Profile file is saved

Reproduces how often:

100%

Brave Version

Brave: 0.21.11 
V8: 6.4.388.41 
rev: e146cd88d6cc5c91f8e772a18cd6c604fe903f58 
Muon: 5.0.5 
OS Release: 4.13.0-21-generic 
Update Channel: Beta 
OS Architecture: x64 
OS Platform: Linux 
Node.js: 7.9.0 
Brave Sync: v1.4.2 
libchromiumcontent: 64.0.3282.140

Brave: 0.21.11 
V8: 6.4.388.41 
rev: e146cd88d6cc5c91f8e772a18cd6c604fe903f58 
Muon: 5.0.5 
OS Release: 6.1.7601 
Update Channel: Beta 
OS Architecture: x64 
OS Platform: Microsoft Windows 
Node.js: 7.9.0 
Brave Sync: v1.4.2 
libchromiumcontent: 64.0.3282.140

Additional Information

TC taken from #11906

Not reproducible in 0.20.42
@btlechowski btlechowski added this to the 0.21.x (Beta Channel) milestone Feb 22, 2018
@LaurenWags
Copy link
Member

Reproduced on MacOS

Brave | 0.21.11
V8 | 6.4.388.41
rev | e146cd8
Muon | 5.0.5
OS Release | 16.7.0
Update Channel | Beta
OS Architecture | x64
OS Platform | macOS
Node.js | 7.9.0
Brave Sync | v1.4.2
libchromiumcontent | 64.0.3282.140

darkdh added a commit to brave/muon that referenced this issue Feb 26, 2018
@darkdh
Writing file on FILE thread and set saved_files_ for
ea60c5c 
CommonWebContentsDelegate::DevToolsAppendToFile

fix brave/browser-laptop#13254

Auditors: @bridiver, @bsclifton
@darkdh darkdh mentioned this issue Feb 26, 2018
Merged
@bsclifton bsclifton modified the milestones: 0.22.x (Developer Channel), 0.21.x w/ Chromium 65 (Beta Channel) Mar 1, 2018
@bsclifton
Copy link
Member

Moving to 0.22.x; we're going to have 0.21.x-C65 only contain the Chromium upgrade 😄 👍

@bsclifton bsclifton modified the milestones: 0.21.x w/ Chromium 65 (Beta Channel), 0.22.x (Developer Channel) Mar 9, 2018
@LaurenWags
Copy link
Member

LaurenWags commented Mar 23, 2018 •
edited by btlechowski
Loading

Verified on macOS 10.12.6 x64 using the following build:

  • 0.22.7 8bb7e77
  • libchromiumcontent: 65.0.3325.181
  • muon: 5.1.1

Verified on Ubuntu 10.10 x64

  • 0.22.7 8bb7e77
  • libchromiumcontent: 65.0.3325.181
  • muon: 5.1.1

Verified on Windows 7 x64

  • 0.22.7 8bb7e77
  • libchromiumcontent: 65.0.3325.181
  • muon: 5.1.1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@darkdh darkdh

Labels
0.21.x issue first seen in 0.21.x feature/developer-tools feature/download QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release-notes/exclude
Projects
None yet
Milestone
0.22.x (Release Channel)
Development

Successfully merging a pull request may close this issue.

Fix empty devtool profile brave/muon
5 participants
@kjozwiak @bsclifton @darkdh @LaurenWags @btlechowski