Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Resume after pause on twitch media does not resume timer #13257

Closed
bsclifton opened this issue Feb 22, 2018 · 4 comments
Closed

Resume after pause on twitch media does not resume timer #13257

bsclifton opened this issue Feb 22, 2018 · 4 comments

Comments

@bsclifton
Copy link
Member

bsclifton commented Feb 22, 2018

Test Plan

#13326

Description

When testing #13142, I realized that timer for time spent on a twitch video is not resumed when you click PLAY after pausing a video

Steps to Reproduce

  1. Watch a twitch video; confirm time spent is showing in ledger
  2. Click pause; confirm time spent was updated
  3. Click play again; wait for a minute
  4. Notice time does not increment

Actual result:

Expected result:

Reproduces how often:

Brave Version

about:brave info:

Reproducible on current live release:

Additional Information

@srirambv
Copy link
Collaborator

Seeing a different behaviour on Windows.
Visited this link and started playing video https://www.twitch.tv/videos/230977648
Played the video for 3min20sec and paused, ledger showed 3min52secs as time spent
Paused the video for 2 mins and then resumed to play
Played the video for 4min53sec and paused, ledger showed 6min39secs

@srirambv
Copy link
Collaborator

Even seeking video to a different position the time spent is recorded

@NejcZdovc
Copy link
Contributor

Tried your scenario, this is what happened for me:

Played the video for 3min20sec and paused, ledger showed 3min21secs as time spent
Paused the video for 2 mins and then resumed to play
Played the video for 4min53sec (which is total of 8m13s) and paused, ledger showed 8min15secs

That 2s more is expected and happens because of the nature that we are logging twitch time

NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Feb 27, 2018
Resolves brave#13257

Auditors:

Test Plan:
@NejcZdovc NejcZdovc modified the milestones: Triage Backlog, 0.21.x (Beta Channel) Feb 27, 2018
@NejcZdovc NejcZdovc modified the milestones: 0.21.x (Beta Channel), 0.22.x (Developer Channel) Feb 27, 2018
@alexwykoff alexwykoff added the priority/P3 Major loss of function. label Feb 27, 2018
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Feb 28, 2018
Resolves brave#13257

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Feb 28, 2018
Resolves brave#13257

Auditors:

Test Plan:
bsclifton pushed a commit to NejcZdovc/browser-laptop that referenced this issue Mar 15, 2018
Resolves brave#13257

Auditors:

Test Plan:
bsclifton added a commit that referenced this issue Mar 15, 2018
bsclifton added a commit that referenced this issue Mar 15, 2018
bsclifton added a commit that referenced this issue Mar 15, 2018
@LaurenWags
Copy link
Member

LaurenWags commented Mar 23, 2018

Verified on macOS 10.12.6 x64 using the following build:

  • 0.22.7 8bb7e77
  • libchromiumcontent: 65.0.3325.181
  • muon: 5.1.1

Verified on Windows 7 x64

  • 0.22.8 3ae27f2
  • libchromiumcontent: 65.0.3325.181
  • muon: 5.1.2

Verified on Ubuntu 16.04 using

  • 0.22.9 e0fc152
  • libchromiumcontent: 65.0.3325.181
  • muon: 5.1.2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.