Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Backup keys import/export not working #13274

Closed
NejcZdovc opened this issue Feb 23, 2018 · 1 comment
Closed

Backup keys import/export not working #13274

NejcZdovc opened this issue Feb 23, 2018 · 1 comment
Assignees
@NejcZdovc
Labels
0.22.x issue first seen in 0.22.x feature/rewards priority/P1 Blocks development or testing. Product cannot run. Must be fixed immediately, shipped next release. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release/blocking release-notes/exclude
Milestone
0.22.x (Release C...

Comments

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Feb 23, 2018 •
edited by srirambv
Loading

Testplan

see #13279

Description

Steps to Reproduce

Export

  1. Enable payments
  2. Go to advance settings
  3. Try to export backup keys

Import

  1. Enable payments
  2. Go to advance settings
  3. Try to import backup keys

Actual result:

Browser crashes

Expected result:
Keys should be saved

Reproduces how often:

100%

Brave Version

about:brave info:

Reproducible on current live release:

Additional Information
@NejcZdovc NejcZdovc added feature/rewards 0.21.x issue first seen in 0.21.x labels Feb 23, 2018
@NejcZdovc NejcZdovc added this to the 0.21.x (Beta Channel) milestone Feb 23, 2018
@NejcZdovc NejcZdovc self-assigned this Feb 23, 2018
@NejcZdovc NejcZdovc added priority/P1 Blocks development or testing. Product cannot run. Must be fixed immediately, shipped next release. release/blocking labels Feb 23, 2018
@NejcZdovc NejcZdovc changed the title Backup keys export not working Backup keys import/export not working Feb 23, 2018
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Feb 23, 2018
@NejcZdovc
Fixes backup keys export/import; improves print flow
c4e2d02 
Resolves brave#13274

Auditors:

Test Plan:
@NejcZdovc NejcZdovc mentioned this issue Feb 23, 2018
Merged
10 tasks
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Feb 23, 2018
@NejcZdovc
Fixes backup keys export/import; improves print flow
6c186ec 
Resolves brave#13274
Resolves brave#7512
Resolves brave#7511
Resolves brave#11419

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Feb 23, 2018
@NejcZdovc
Fixes backup keys export/import; improves print flow
06e0ad2 
Resolves brave#13274
Resolves brave#7512
Resolves brave#7511
Resolves brave#11419

Auditors:

Test Plan:
@bsclifton bsclifton added 0.22.x issue first seen in 0.22.x and removed 0.21.x issue first seen in 0.21.x labels Feb 27, 2018
bsclifton added a commit that referenced this issue Mar 2, 2018
@bsclifton
Merge pull request #13279 from NejcZdovc/hotfix/#13274-dialog
7c2cf6d 
Fixes backup keys export/import; improves print flow
bsclifton added a commit that referenced this issue Mar 2, 2018
@bsclifton
Merge pull request #13279 from NejcZdovc/hotfix/#13274-dialog
e8fc619 
Fixes backup keys export/import; improves print flow
bsclifton added a commit that referenced this issue Mar 2, 2018
@bsclifton
Merge pull request #13279 from NejcZdovc/hotfix/#13274-dialog
b39d39e 
Fixes backup keys export/import; improves print flow
This was referenced Mar 22, 2018
Closed
Closed
@LaurenWags
Copy link
Member

LaurenWags commented Mar 22, 2018 •
edited by btlechowski
Loading

Verified on macOS 10.12.6 x64 using the following build:

  • 0.22.6 e6ff4ea
  • libchromiumcontent: 65.0.3325.162
  • muon: 5.1.0

Verified on Linux

  • 0.22.6 e6ff4ea
  • libchromiumcontent: 65.0.3325.162
  • muon: 5.1.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
0.22.x issue first seen in 0.22.x feature/rewards priority/P1 Blocks development or testing. Product cannot run. Must be fixed immediately, shipped next release. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release/blocking release-notes/exclude
Projects
None yet
Milestone
0.22.x (Release Channel)
Development

No branches or pull requests
6 participants
@kjozwiak @bsclifton @NejcZdovc @srirambv @LaurenWags @btlechowski