Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

favicons are not consistently displayed in the ledger table #13281

Closed
LaurenWags opened this issue Feb 23, 2018 · 0 comments
Closed

favicons are not consistently displayed in the ledger table #13281

LaurenWags opened this issue Feb 23, 2018 · 0 comments

Comments

@LaurenWags
Copy link
Member

Description

@srirambv and I are not seeing favicons displayed consistently in the ledger table.

Steps to Reproduce

  1. Add some sites to ledger table. See that sites have favicons.
  2. Delete some sites from the table.
  3. Open deleted sites dialog box.
  4. Clear one or more (or all) sites.
  5. Revisit site so it gets added back to the table.

Actual result:
Sites may or may not display their favicons when returned to the table. In the screenshot below all sites had been removed at one time or another (all sites had favicons prior to deleting from the table). Two of them got favicons back, but the others did not.

screen shot 2018-02-23 at 11 57 43 am

Expected result:
All sites should have favicons.

Reproduces how often:
Most of the time, but not 100%

Brave Version

about:brave info:
0.21.12

Reproducible on current live release:

Additional Information

@srirambv sometimes doesn't see favicons added when sites are added to the ledger table initially.

cc @NejcZdovc

@LaurenWags LaurenWags added this to the 0.21.x (Beta Channel) milestone Feb 23, 2018
@NejcZdovc NejcZdovc self-assigned this Feb 23, 2018
@LaurenWags LaurenWags modified the milestones: 0.21.x (Beta Channel), Triage Backlog Feb 23, 2018
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Feb 23, 2018
Resolves brave#13281

Auditors:

Test Plan:
@NejcZdovc NejcZdovc mentioned this issue Feb 23, 2018
10 tasks
@NejcZdovc NejcZdovc modified the milestones: Triage Backlog, 0.21.x (Beta Channel) Feb 23, 2018
@NejcZdovc NejcZdovc modified the milestones: 0.21.x (Beta Channel), 0.21.x (Twitch) Feb 24, 2018
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Feb 25, 2018
Resolves brave#13281

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Feb 25, 2018
Resolves brave#13281

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Feb 25, 2018
Resolves brave#13281

Auditors:

Test Plan:
bsclifton pushed a commit to NejcZdovc/browser-laptop that referenced this issue Feb 26, 2018
Resolves brave#13281

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Feb 26, 2018
Resolves brave#13281

Auditors:

Test Plan:
bsclifton added a commit that referenced this issue Feb 26, 2018
bsclifton added a commit that referenced this issue Feb 26, 2018
bsclifton added a commit that referenced this issue Feb 26, 2018
ryanml pushed a commit to ryanml/browser-laptop that referenced this issue Feb 27, 2018
Resolves brave#13281

Auditors:

Test Plan:
@srirambv srirambv added the 0.21.x issue first seen in 0.21.x label Feb 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.