Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Background process doesn't quit when data is imported #13422

Closed
srirambv opened this issue Mar 12, 2018 · 5 comments · Fixed by #13758
Closed

Background process doesn't quit when data is imported #13422

srirambv opened this issue Mar 12, 2018 · 5 comments · Fixed by #13758
Assignees
@petemill
Labels
0.21.x issue first seen in 0.21.x bug feature/importer OS/Windows QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.22.x Release 3 ...

Comments

@srirambv
Copy link
Collaborator

Description

Background process doesn't quit when data is imported

Steps to Reproduce

  1. Clean install 0.21.656
  2. Launch browser and close, ensure no background process are retained
  3. Import browser data/bookmarks HTML file into Brave
  4. Close browser, background process remain opened doesn't close

Actual result:
bookmark import

Expected result:
Should quit all background process when browser is closed irrespective of importing browser data

Reproduces how often:
100%

Brave Version

about:brave info:

Brave 0.21.656
Brave Sync v1.4.2
libchromiumcontent 65.0.3325.146
Muon 4.9.0
Node.js 7.9.0
OS Architecture x64
OS Platform Microsoft Windows
OS Release 10.0.16299
rev c8e9925
Update Channel Beta
V8 6.5.254.31

Reproducible on current live release:
No

Additional Information

Killing the active background process and relaunching the browser, doesn't show the imported data

cc: @darkdh @hferreiro @bsclifton @ltilve @bridiver
@srirambv srirambv added this to the 0.21.x w/ Chromium 65 (Beta Channel) milestone Mar 12, 2018
@kjozwiak
Copy link
Member

kjozwiak commented Mar 12, 2018 •
edited
Loading

I'm pretty sure this is the same issue as #13277. This is only reproducible when you quit via the X under the title menu and can be reproduced under both Win and Linux platforms.

This is also reproducible with 0.21.18 580be78 which is the latest release. Removing the cr65, regression and release/blocking tags.

@petemill is this the same thing as #13277?

@darkdh
Copy link
Member

darkdh commented Mar 12, 2018

@srirambv can you narrow down which data you import cause the problem?

@kjozwiak
Copy link
Member

@darkdh I can reproduce the above by simply importing any .html backup and then closing Brave via the X located on the toolbar.

STR: (also reproducible with 0.21.18 580be78 which is the current release)

  • launch brave 0.21.656
  • import the .html backup mentioned below
  • close Brave using X via the title bar

.html bookmark backup: https://drive.google.com/file/d/1hTlLtP2bkNM-265ilSJGWejHtG3T1NzR/view?usp=sharing.

@bsclifton
Copy link
Member

Moving out of milestone since this is an existing issue

@bsclifton bsclifton modified the milestones: 0.21.x w/ Chromium 65 (Beta Channel), Triage Backlog Mar 13, 2018
@kjozwiak kjozwiak mentioned this issue Mar 20, 2018
Closed
petemill added a commit that referenced this issue Apr 7, 2018
@petemill
Calculate bookmarks bar overflow using css
9bd1cb7 
Fix #13695

Remove usage of textCalc as it was the last usage of tabs.executeScriptInBackground which is not compatible with upcoming muon v6.x since as it incorrectly used executeScriptInTab which should only work on a WebContents which is a Tab, not a Window. Muon does not have a generic WebContents.executeJavascript method.

Also added bonus of not requiring creating new Windows in order to calculate text width and having to manage when they are closed, etc which should address the following issues, if that was the cause:
Fix #13422
Fix #13277
@petemill petemill mentioned this issue Apr 7, 2018
Merged
10 tasks
petemill added a commit that referenced this issue Apr 7, 2018
@petemill
Calculate bookmarks bar overflow using css
8b1767b 
Fix #13695

Remove usage of textCalc as it was the last usage of tabs.executeScriptInBackground which is not compatible with upcoming muon v6.x since as it incorrectly used executeScriptInTab which should only work on a WebContents which is a Tab, not a Window. Muon does not have a generic WebContents.executeJavascript method.

Also added bonus of not requiring creating new Windows in order to calculate text width and having to manage when they are closed, etc which should address the following issues, if that was the cause:
Fix #13422
Fix #13277
petemill added a commit that referenced this issue Apr 9, 2018
@petemill
Calculate bookmarks bar overflow using css
52982e6 
Fix #13695

Remove usage of textCalc as it was the last usage of tabs.executeScriptInBackground which is not compatible with upcoming muon v6.x since as it incorrectly used executeScriptInTab which should only work on a WebContents which is a Tab, not a Window. Muon does not have a generic WebContents.executeJavascript method.

Also added bonus of not requiring creating new Windows in order to calculate text width and having to manage when they are closed, etc which should address the following issues, if that was the cause:
Fix #13422
Fix #13277
petemill added a commit that referenced this issue Apr 9, 2018
@petemill
Calculate bookmarks bar overflow using css
122aa70 
Fix #13695

Remove usage of textCalc as it was the last usage of tabs.executeScriptInBackground which is not compatible with upcoming muon v6.x since as it incorrectly used executeScriptInTab which should only work on a WebContents which is a Tab, not a Window. Muon does not have a generic WebContents.executeJavascript method.

Also added bonus of not requiring creating new Windows in order to calculate text width and having to manage when they are closed, etc which should address the following issues, if that was the cause:
Fix #13422
Fix #13277
@bsclifton bsclifton modified the milestones: Triage Backlog, 0.22.x Release 3 (Beta channel) Apr 11, 2018
@btlechowski
Copy link
Contributor

Verified Win7 x64 v0.22.108

@kjozwiak kjozwiak mentioned this issue May 16, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@petemill petemill

Labels
0.21.x issue first seen in 0.21.x bug feature/importer OS/Windows QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.22.x Release 3 (Release Channel)
Development

Successfully merging a pull request may close this issue.

Calculate bookmarks bar overflow using css brave/browser-laptop
7 participants
@petemill @kjozwiak @bsclifton @darkdh @srirambv @LaurenWags @btlechowski