Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Handle pinned sites separately when doing contribution #13431

Closed
NejcZdovc opened this issue Mar 13, 2018 · 7 comments · Fixed by #13530
Closed

Handle pinned sites separately when doing contribution #13431

NejcZdovc opened this issue Mar 13, 2018 · 7 comments · Fixed by #13530
Assignees
Labels
feature/rewards priority/P1 Blocks development or testing. Product cannot run. Must be fixed immediately, shipped next release. QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/test-plan-specified release-notes/include

Comments

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Mar 13, 2018

Test Plan

#13530

Description

Pinned sites should be excluded from the statistical voting.

@NejcZdovc NejcZdovc added this to the 0.22.x (Developer Channel) milestone Mar 13, 2018
@NejcZdovc NejcZdovc self-assigned this Mar 13, 2018
@alexwykoff alexwykoff added the priority/P1 Blocks development or testing. Product cannot run. Must be fixed immediately, shipped next release. label Mar 20, 2018
@NejcZdovc NejcZdovc mentioned this issue Mar 20, 2018
10 tasks
@LaurenWags
Copy link
Member

@NejcZdovc @mrose17 How 'off' is acceptable for pinned sites (per the test plan)? one of mine is off by almost 20:

screen shot 2018-03-23 at 4 14 46 pm

screen shot 2018-03-23 at 4 16 25 pm

cc @kjozwiak @btlechowski

@LaurenWags LaurenWags reopened this Mar 23, 2018
@NejcZdovc
Copy link
Contributor Author

@LaurenWags can you please provide monthly amount, ledger-state and which version you are on

@LaurenWags
Copy link
Member

monthly amount is 7.5 and I was using 0.22.7. I don't have ledger state.

@NejcZdovc
Copy link
Contributor Author

NejcZdovc commented Mar 27, 2018

10 BAT (15 votes)

screen shot 2018-03-27 at 8 24 05 am

ledger-state.json.zip

Publisher Pinned % table Votes % votes
slo-tech.com Yes 30 5 33.33
Brave on YouTube Yes 20 4 26.67
TechGumbo on YouTube Yes 10 3 20
24ur.com Yes 5 1 6.67
Chris' Tutorials on YouTube No 17 0 0
ThioJoe on YouTube No 8 1 6.67
Popesites on YouTube No 6 1 6.67
CNET on YouTube No 4 0 0

7.5 BAT (11 votes)

image

ledger-state.json.zip

Publisher Pinned % table Votes % votes
slo-tech.com Yes 30 4 36.36
Brave on YouTube Yes 20 3 27.27
TechGumbo on YouTube Yes 10 1 9.09
24ur.com Yes 5 1 9.09
Chris' Tutorials on YouTube No 17 2 18.18
ThioJoe on YouTube No 8 0 0
Popesites on YouTube No 6 0 0
CNET on YouTube No 4 0 0

@NejcZdovc
Copy link
Contributor Author

NejcZdovc commented Mar 27, 2018

Closing this as this was implemented, but we will need to fine tune it a little bit more. Will create another issue for that. It's better, but we can still improve it.

Issue opened #13620

@LaurenWags
Copy link
Member

Thanks for opening up the new issue @NejcZdovc !

@LaurenWags
Copy link
Member

LaurenWags commented Mar 28, 2018

Verified on macOS 10.12.6 x64 using the following build:

  • 0.22.8 3ae27f2
  • libchromiumcontent: 65.0.3325.181
  • muon: 5.1.2

Verified on Mint 18.3 x64 using the following build:

  • 0.22.11 56de947
  • libchromiumcontent: 65.0.3325.181
  • muon: 5.1.2

Verified on Win 10 x64 using the following build:

  • 0.22.11 56de947
  • libchromiumcontent: 65.0.3325.181
  • muon: 5.1.2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature/rewards priority/P1 Blocks development or testing. Product cannot run. Must be fixed immediately, shipped next release. QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/test-plan-specified release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants