Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Updates bat libraries #13530

Merged
merged 1 commit into from
Mar 23, 2018
Merged

Updates bat libraries #13530

merged 1 commit into from
Mar 23, 2018

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Mar 20, 2018

Resolves #13509
Resolves #13431 (brave-intl/bat-publisher#24)

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

  1. clean profile
  2. enable payments
  3. visit some sites
  4. pin few sites
  5. trigger contribution (close browser, change reconcile timestamp, run with LEDGER_NO_DELAY=true LEDGER_NO_FUZZING=true LEDGER_VERBOSE=true params)
  6. make sure that pinned sites are in the same ball park (could be couple % off of course)
  7. open ledger-state.json and make sure that there is memo object in there

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@NejcZdovc NejcZdovc added this to the 0.22.x (Beta Channel) milestone Mar 20, 2018
@NejcZdovc NejcZdovc self-assigned this Mar 20, 2018
@NejcZdovc
Copy link
Contributor Author

code is done, I just need to test it on b-l part

@NejcZdovc NejcZdovc force-pushed the fix/#13509-update branch 5 times, most recently from 1867f3c to 0c8c18b Compare March 23, 2018 01:03
@codecov-io
Copy link

codecov-io commented Mar 23, 2018

Codecov Report

Merging #13530 into master will increase coverage by <.01%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master   #13530      +/-   ##
==========================================
+ Coverage   56.74%   56.74%   +<.01%     
==========================================
  Files         285      284       -1     
  Lines       28782    28742      -40     
  Branches     4752     4746       -6     
==========================================
- Hits        16331    16309      -22     
+ Misses      12451    12433      -18
Flag Coverage Δ
#unittest 56.74% <66.66%> (ø) ⬆️
Impacted Files Coverage Δ
app/browser/api/ledger.js 61.62% <66.66%> (+0.08%) ⬆️
js/stores/appStoreRenderer.js 91.66% <0%> (-8.34%) ⬇️
app/renderer/components/reduxComponent.js 57.75% <0%> (-3.45%) ⬇️
js/stores/windowStore.js 28.46% <0%> (-0.3%) ⬇️
app/browser/tabs.js 23.68% <0%> (-0.11%) ⬇️
app/locale.js 35.77% <0%> (ø) ⬆️
app/common/constants/ledgerStatuses.js
...r/components/preferences/payment/enabledContent.js 74.76% <0%> (+7.84%) ⬆️

Resolves brave#13509

Auditors:

Test Plan:
Copy link
Member

@mrose17 mrose17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wunderbar!

@NejcZdovc NejcZdovc merged commit 5bd5b15 into brave:master Mar 23, 2018
NejcZdovc added a commit that referenced this pull request Mar 23, 2018
NejcZdovc added a commit that referenced this pull request Mar 23, 2018
@NejcZdovc
Copy link
Contributor Author

master 5bd5b15
0.23 90bdc52
0.22 b6d476c

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use the latest bat-* package versions Handle pinned sites separately when doing contribution
3 participants