brave doesn't check URL protocol and requests external application permissions

[kjozwiak]

Test plan

See #13475

Description

Brave will requests for external application permissions when a URL with an invalid protocol is used. We shouldn't be asking for external application permissions when an invalid protocol is being used.

Steps to Reproduce

1. launch brave and load reddit.com in a new tab
2. within the same tab, type in abc://google.com and press 'enter'
3. reddit.com will request for external application permissions

Actual result:

Expected result:

Brave shouldn't be asking for external application permissions when loading a URL with an invalid protocol.

Reproduces how often:

100% reproducible using the above STR.

Brave Version

about:brave info:

Brave: 0.21.658
V8: 6.5.254.36
rev: ad8bdc1
libchromiumcontent: 65.0.3325.162
Muon: 4.9.2
OS Release: 17.4.0
Update Channel: Beta
OS Architecture: x64
OS Platform: macOS
Node.js: 7.9.0
Brave Sync: v1.4.2

Reproducible on current live release:

Yes, currently also reproducible under 0.21.18 580be78 which is the latest released build.

Additional Information

CC'ing @diracdeltas @flamsmark for proper triage.

[diracdeltas]

It might be hard to detect all valid external protocols since people are constantly creating new ones. However we should probably show the origin of the external site in the URL bar instead of the origin of the page that the user is currently on.

[diracdeltas]

reopening since it depends on #13475

[kjozwiak]

@LaurenWags @btlechowski easiest way to get a local webserver going so you can go through the test plan that was added is using python -m SimpleHTTPServer.

[kjozwiak]

Verified on Ubuntu 17.10 x64 using the following build:

• 0.22.8 3ae27f2
• libchromiumcontent: 65.0.3325.181
• muon: 5.1.2

Verified on macOS 10.12.6 x64 using the following build:

• 0.22.8 3ae27f2
• libchromiumcontent: 65.0.3325.181
• muon: 5.1.2

Verified on Windows 7 x64

• 0.22.8 3ae27f2
• libchromiumcontent: 65.0.3325.181
• muon: 5.1.2