Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Option in Developer Tools Crashes Brave #13521

Closed
LaurenWags opened this issue Mar 20, 2018 · 8 comments · Fixed by brave/muon#542
Closed

Option in Developer Tools Crashes Brave #13521

LaurenWags opened this issue Mar 20, 2018 · 8 comments · Fixed by brave/muon#542

Comments

@LaurenWags
Copy link
Member

Description

Opening Developer Tools -> Sources (tab) -> Overrides (sub-tab) and clicking ‘Select folder for overrides’ crashes Brave.

Reported via community: https://community.brave.com/t/developer-tools-select-folder-for-overrides-crashes-brave/18215

Steps to Reproduce

  1. Select View > Toggle Developer Tools
  2. Select Sources tab > Overrides sub-tab
  3. Select the 'Select folder for overrides' under the sub-tab.

Actual result:
Brave Crashes.

Expected result:
Brave should not crash.

Reproduces how often:
Easily

Brave Version

about:brave info:
0.21.23

Reproducible on current live release:
No, that option is not available on 0.21.18

Additional Information

CR65 related? cc @bsclifton
Reported with Windows, reproduced with MacOS

@kjozwiak
Copy link
Member

Moved into this into the 0.21 milestone so @bsclifton is made aware. However, this will most likely be triaged out into another milestone/backlog.

@kjozwiak
Copy link
Member

Moving into 0.22 after speaking with @bsclifton.

@kjozwiak kjozwiak modified the milestones: 0.21.x w/ Chromium 65 (Release Channel), 0.22.x (Beta Channel) Mar 20, 2018
@kjozwiak kjozwiak added the crash label Mar 20, 2018
@darkdh darkdh self-assigned this Mar 20, 2018
@alexwykoff alexwykoff added the priority/P2 Crashes. Loss of data. Severe memory leak. label Mar 20, 2018
@darkdh
Copy link
Member

darkdh commented Mar 21, 2018

will not crash with muon 5.0.0 and above but still need to make it functioning normally.
Currently it behaves same as Add folder to workspace

@kjozwiak
Copy link
Member

kjozwiak commented Mar 27, 2018

Using the above STR, I reproduced the issue using 0.21.24 19c78a1. Once reproduced, I went through verification with Ubuntu 17.10 x64 using the following build:

  • 0.22.7 8bb7e77
  • libchromiumcontent: 65.0.3325.181
  • muon: 5.1.1

@bsclifton
Copy link
Member

bsclifton commented Mar 27, 2018

@kjozwiak it doesn't crash, but fix isn't in place quite yet (will be delivered with Muon 5.1.2). I believe it will just not do anything at the moment

Removing QA/checked-Linux label so that we can retest when new Muon is available

@darkdh
Copy link
Member

darkdh commented Mar 27, 2018

Before muon 5.1.2 the folder will be added to workspace even if you add it in Overrides
screen shot 2018-03-22 at 2 47 36 pm
screen shot 2018-03-27 at 9 40 00 am

After 5.1.2, you can successfully add it to Overrides
screen shot 2018-03-27 at 9 38 32 am

@kjozwiak
Copy link
Member

kjozwiak commented Mar 27, 2018

@kjozwiak it doesn't crash, but fix isn't in place quite yet (will be delivered with Muon 5.1.2). I believe it will just not do anything at the moment

Removing QA/checked-Linux label so that we can retest when new Muon is available

Thanks @bsclifton, I was going to create a new issue after the triage meeting for Overrides not working correctly. Makes sense on why it wasn't working previously.

@btlechowski
Copy link
Contributor

btlechowski commented Mar 28, 2018

Verified on Windows 7 x64

  • 0.22.8 3ae27f2
  • libchromiumcontent: 65.0.3325.181
  • muon: 5.1.2

Verified on macOS 10.12.6 x64 using the following build:

  • 0.22.8 3ae27f2
  • libchromiumcontent: 65.0.3325.181
  • muon: 5.1.2

Verified on Ubuntu 17.10 x64 using the following build:

  • 0.22.8 3ae27f2
  • libchromiumcontent: 65.0.3325.181
  • muon: 5.1.2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants