Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

corrupt wallet message does not go away after recovering your wallet #13583

Closed
LaurenWags opened this issue Mar 23, 2018 · 1 comment · Fixed by #13607
Closed

corrupt wallet message does not go away after recovering your wallet #13583

LaurenWags opened this issue Mar 23, 2018 · 1 comment · Fixed by #13607
Assignees
@NejcZdovc
Labels
0.22.x issue first seen in 0.22.x bug feature/rewards QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Milestone
0.22.x (Release C...

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Mar 23, 2018 •
edited by bsclifton
Loading

Test plan

See #13607

Description

After you receive the corrupt wallet overlay and recover your wallet, the overlay does not go away, even after a restart of Brave.

Steps to Reproduce

  1. Launch brave with LEDGER_ENVIRONMENT=staging and LEDGER_VERBOSE=true with a clean profile
  2. Enable payments
  3. Save recovery key
  4. Close Brave
  5. Open ledger-state.json and modify seed (remove some of them)
  6. Launch Brave with same parameters from step 1
  7. Navigate to Payments, overlay is shown.
  8. Click on recover button
  9. Copy/Paste words or import them.
  10. Successful wallet recovery, close popup
  11. Corrupt message is still displayed, even after restart

Actual result:
corrupt-overlay1

Expected result:
Corrupt overlay should go away once you have successfully recovered your wallet.

Reproduces how often:
Easily

Brave Version

about:brave info:
0.22.7

Reproducible on current live release:
No

Additional Information
@LaurenWags LaurenWags added bug feature/rewards 0.22.x issue first seen in 0.22.x labels Mar 23, 2018
@LaurenWags LaurenWags added this to the 0.22.x (Beta Channel) milestone Mar 23, 2018
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Mar 26, 2018
@NejcZdovc
Fixes recover flow when seed is corrupted
6486e82 
Resolves brave#13583

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Mar 26, 2018
@NejcZdovc
Fixes recover flow when seed is corrupted
864df85 
Resolves brave#13583

Auditors:

Test Plan:
@NejcZdovc NejcZdovc mentioned this issue Mar 26, 2018
Merged
10 tasks
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Mar 26, 2018
@NejcZdovc
Fixes recover flow when seed is corrupted
5dbe566 
Resolves brave#13583

Auditors:

Test Plan:
bsclifton added a commit that referenced this issue Mar 26, 2018
@bsclifton
Merge pull request #13607 from NejcZdovc/hotfix/#13583-away
03e30fe 
Fixes recover flow when seed is corrupted
This was referenced Mar 28, 2018
Closed
Closed
Closed
NejcZdovc pushed a commit that referenced this issue Mar 28, 2018
@bsclifton @NejcZdovc
Merge pull request #13607 from NejcZdovc/hotfix/#13583-away
2f2f58e 
Fixes recover flow when seed is corrupted
NejcZdovc pushed a commit that referenced this issue Mar 28, 2018
@bsclifton @NejcZdovc
Merge pull request #13607 from NejcZdovc/hotfix/#13583-away
0c503ab 
Fixes recover flow when seed is corrupted
@LaurenWags
Copy link
Member Author

LaurenWags commented Mar 28, 2018 •
edited by kjozwiak
Loading

Verified on macOS 10.12.6 x64 using the following build:

  • 0.22.9 e0fc152
  • libchromiumcontent: 65.0.3325.181
  • muon: 5.1.2

Verified on Win7 x64:

  • 0.22.9: e0fc152
  • libchromiumcontent: 65.0.3325.181
  • muon: 5.1.2

Verified on Mint 18.3 x64 using the following build:

  • 0.22.11 56de947
  • libchromiumcontent: 65.0.3325.181
  • muon: 5.1.2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
0.22.x issue first seen in 0.22.x bug feature/rewards QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Projects
None yet
Milestone
0.22.x (Release Channel)
Development

Successfully merging a pull request may close this issue.

Fixes recover flow when seed is corrupted NejcZdovc/browser-laptop
5 participants
@kjozwiak @bsclifton @NejcZdovc @LaurenWags @btlechowski