Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

tab color changes after opening wallet recovery a second time #13640

Closed
LaurenWags opened this issue Mar 28, 2018 · 0 comments
Closed

tab color changes after opening wallet recovery a second time #13640

LaurenWags opened this issue Mar 28, 2018 · 0 comments
Assignees
@petemill
Labels
0.22.x issue first seen in 0.22.x bug feature/tabsbar stale

Comments

@LaurenWags
Copy link
Member

Description

Found while testing #13584 - if you open the recovery dialog a second time the tab changes color.

Steps to Reproduce

  1. Launch brave with a clean profile
  2. Enable payments
  3. Save recovery key
  4. Close Brave
  5. Open ledger-state.json and modify seed (remove some of them)
  6. Launch Brave again
  7. Navigate to Payments, overlay is shown.
  8. Click on recover button. Close recover popup.
  9. Click on recover button again.

Actual result:
Preferences tab color changes:
recover-twice

Expected result:
No tab color change

Reproduces how often:
Easily

Brave Version

about:brave info:
Brave | 0.22.9
V8 | 6.5.254.41
rev | e0fc152
Muon | 5.1.2
OS Release | 16.7.0
Update Channel | Release
OS Architecture | x64
OS Platform | macOS
Node.js | 7.9.0
Brave Sync | v1.4.2
libchromiumcontent | 65.0.3325.181

Reproducible on current live release:
no

Additional Information

cc @NejcZdovc
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@petemill petemill

Labels
0.22.x issue first seen in 0.22.x bug feature/tabsbar stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@petemill @kjozwiak @bsclifton @NejcZdovc @LaurenWags