unable to open Recover wallet dialog a second time from corrupt wallet overlay

[LaurenWags]

Test plan

See #13621

Description

If you click on 'Recover my Brave Wallet' button from the corrupt wallet overlay, close the popup (without copy/paste or import of keys), and click on the 'Recover my Brave Wallet' button again, the popup won't display. You have to close/reopen Brave to get the recover dialog again.

Steps to Reproduce

1. Launch brave with LEDGER_ENVIRONMENT=staging and LEDGER_VERBOSE=true with a clean profile
2. Enable payments
3. Save recovery key
4. Close Brave
5. Open ledger-state.json and modify seed (remove some of them)
6. Launch Brave with same parameters from step 1
7. Navigate to Payments, overlay is shown.
8. Click on recover button. Close recover popup.
9. Click on recover button again.

Actual result:
Popup is not displayed. If you close/relaunch Brave and you’re on the payments page the recover popup is opened automatically without clicking on the button.

Expected result:
Recover wallet dialog should open when you click on the recover button from the overlay.

Reproduces how often:
Easily

Brave Version

about:brave info:
0.22.7

Reproducible on current live release:
no

Additional Information

[bsclifton]

confirmed this is still an issue (even after #13607 was merged)

[LaurenWags]

Verified on macOS 10.12.6 x64 using the following build:

• 0.22.9 e0fc152
• libchromiumcontent: 65.0.3325.181
• muon: 5.1.2

Verified on Win7 x64:

• 0.22.9: e0fc152
• libchromiumcontent: 65.0.3325.181
• muon: 5.1.2

Verified on Mint 18.3 x64 using the following build:

• 0.22.11 56de947
• libchromiumcontent: 65.0.3325.181
• muon: 5.1.2