Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

[FEATURE REQUEST] Add an option to disable WebRTC in about:preferences #13668

Closed
ghost opened this issue Mar 30, 2018 · 4 comments · Fixed by #13713
Closed

[FEATURE REQUEST] Add an option to disable WebRTC in about:preferences #13668

ghost opened this issue Mar 30, 2018 · 4 comments · Fixed by #13713
Assignees
@diracdeltas
Labels
QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.22.x Release 3 ...

Comments

@ghost
Copy link

ghost commented Mar 30, 2018 •
edited by LaurenWags
Loading

Test Plan

#13713

Description

Add an option to disable WebRTC in the settings menu (about:preferences).

Why: WebRTC can leak IP addresses even behind VPN.
@BrendanEich
Copy link
Member

This came up on reddit and our advice to use fingerprinting protection was not useful due to auth systems that do canvas readback (slider captchas etc). I think we must fix this issue so users do not face the bad choice of logging in over a vpn with such a captcha, leaking home ipaddr, and too late then enabling f.p. Cc: @diracdeltas

@jumde jumde mentioned this issue Mar 30, 2018
Closed
@diracdeltas diracdeltas self-assigned this Apr 3, 2018
diracdeltas added a commit that referenced this issue Apr 4, 2018
@diracdeltas
add advanced webrtc IP handling preference
074e87b 
fix #13668

Test Plan:
1. go to about:preferences#advanced
2. at the bottom, it should show a webrtc policy select menu which defaults
   to 'default'
3. turn on fingerprinting protection to 'block all'
4. go to https://browserleaks.com/webrtc. it should not show any IPs
5. turn off fingerprinting protection on that page. now it should show IPs
6. in about:preferences#advanced, set webrtc policy to 'default public
   interface only'
7. reload https://browserleaks.com/webrtc. it should only show the
   public IP.
8. in about:preferences#advanced, set webrtc policy to 'disable
   non-proxied UDP'
9. reload https://browserleaks.com/webrtc. it should show no IPs.
10. in about:preferences#advanced, set webrtc policy to 'default public
    and private interfaces'
11. reload https://browserleaks.com/webrtc. it should show both IPs.
@diracdeltas diracdeltas mentioned this issue Apr 4, 2018
Merged
10 tasks
diracdeltas added a commit that referenced this issue Apr 4, 2018
@diracdeltas
add advanced webrtc IP handling preference
1271baa 
fix #13668

Test Plan:
1. go to about:preferences#advanced
2. at the bottom, it should show a webrtc policy select menu which defaults
   to 'default'
3. turn on fingerprinting protection to 'block all'
4. go to https://browserleaks.com/webrtc. it should not show any IPs
5. turn off fingerprinting protection on that page. now it should show IPs
6. in about:preferences#advanced, set webrtc policy to 'default public
   interface only'
7. reload https://browserleaks.com/webrtc. it should only show the
   public IP.
8. in about:preferences#advanced, set webrtc policy to 'disable
   non-proxied UDP'
9. reload https://browserleaks.com/webrtc. it should show no IPs.
10. in about:preferences#advanced, set webrtc policy to 'default public
    and private interfaces'
11. reload https://browserleaks.com/webrtc. it should show both IPs.
@NejcZdovc NejcZdovc added this to the 0.22.x Release 3 milestone Apr 7, 2018
diracdeltas added a commit that referenced this issue Apr 10, 2018
@diracdeltas
add advanced webrtc IP handling preference
e9ac0f4 
fix #13668

Test Plan:
1. go to about:preferences#advanced
2. at the bottom, it should show a webrtc policy select menu which defaults
   to 'default'
3. turn on fingerprinting protection to 'block all'
4. go to https://browserleaks.com/webrtc. it should not show any IPs
5. turn off fingerprinting protection on that page. now it should show IPs
6. in about:preferences#advanced, set webrtc policy to 'default public
   interface only'
7. reload https://browserleaks.com/webrtc. it should only show the
   public IP.
8. in about:preferences#advanced, set webrtc policy to 'disable
   non-proxied UDP'
9. reload https://browserleaks.com/webrtc. it should show no IPs.
10. in about:preferences#advanced, set webrtc policy to 'default public
    and private interfaces'
11. reload https://browserleaks.com/webrtc. it should show both IPs.
diracdeltas added a commit that referenced this issue Apr 10, 2018
@diracdeltas
add advanced webrtc IP handling preference
1482a2e 
fix #13668

Test Plan:
1. go to about:preferences#advanced
2. at the bottom, it should show a webrtc policy select menu which defaults
   to 'default'
3. turn on fingerprinting protection to 'block all'
4. go to https://browserleaks.com/webrtc. it should not show any IPs
5. turn off fingerprinting protection on that page. now it should show IPs
6. in about:preferences#advanced, set webrtc policy to 'default public
   interface only'
7. reload https://browserleaks.com/webrtc. it should only show the
   public IP.
8. in about:preferences#advanced, set webrtc policy to 'disable
   non-proxied UDP'
9. reload https://browserleaks.com/webrtc. it should show no IPs.
10. in about:preferences#advanced, set webrtc policy to 'default public
    and private interfaces'
11. reload https://browserleaks.com/webrtc. it should show both IPs.
This was referenced May 3, 2018
Closed
Closed
Closed
@LaurenWags
Copy link
Member

@diracdeltas @jumde - is the proper test plan for this under #13674 or #13713 ?

@diracdeltas
Copy link
Member

diracdeltas commented May 4, 2018 via email

@LaurenWags
Copy link
Member

LaurenWags commented May 4, 2018 •
edited by btlechowski
Loading

Verified with macOS 10.12.6 using

  • 0.22.702 e4a853d
  • muon 6.0.7
  • libchromiumcontent 66.0.3359.139

Verified on Windows x64

  • 0.22.702 e4a853d
  • libchromiumcontent 66.0.3359.139
  • muon: 6.0.7

Verified on Ubuntu 17.10 x64

  • 0.22.703 903b8d0
  • libchromiumcontent 66.0.3359.139
  • muon: 6.0.8

@srirambv srirambv mentioned this issue May 8, 2018
Closed
@kjozwiak kjozwiak mentioned this issue May 16, 2018
Closed
@jumde jumde mentioned this issue Jul 16, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@diracdeltas diracdeltas

Labels
QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.22.x Release 3 (Release Channel)
Development

Successfully merging a pull request may close this issue.

add advanced webrtc IP handling preference brave/browser-laptop
7 participants
@BrendanEich @diracdeltas @NejcZdovc @srirambv @LaurenWags @btlechowski @GeetaSarvadnya