Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Some Top site tiles are missing favicons #13728

Closed
btlechowski opened this issue Apr 4, 2018 · 7 comments
Closed

Some Top site tiles are missing favicons #13728

btlechowski opened this issue Apr 4, 2018 · 7 comments

Comments

@btlechowski
Copy link
Contributor

btlechowski commented Apr 4, 2018

Steps to Reproduce

  1. Clean install
  2. Open onet.pl
  3. Open a new tab

Actual result:
Instead of favicons, there are letters (on screenshot below O)
image

When I click on the O tile, the favicon will load.

Expected result:
Favicons are immediately shown

Brave Version

Reproduced on Win7 and Mac

Brave: 0.22.103 
V8: 6.5.254.41 
rev: 2324f5563110b178304d30b81f3cfae965ae4a03 
Muon: 6.0.0 
OS Release: 6.1.7601 
Update Channel: Beta 
OS Architecture: x64 
OS Platform: Microsoft Windows 
Node.js: 7.9.0 
Brave Sync: v1.4.2 
libchromiumcontent: 65.0.3325.181

@btlechowski btlechowski added the 0.22.x-single-webview Issue first seen on single-webview build against v0.22.x branch label Apr 4, 2018
@btlechowski btlechowski added this to the 0.22.x Release 2 (Beta Channel) milestone Apr 4, 2018
@petemill
Copy link
Member

petemill commented Apr 6, 2018

I think this is fixed with 0.22.106, please let me know if otherwise

@petemill petemill modified the milestones: 0.22.x Release 2 (Beta Channel), 0.22.x Release 3 Apr 6, 2018
@Tomatoshadow2
Copy link

@petemill Is it still possible for what @btlechowski is describing to show up like that for any site, as I just downloaded 22.106 and one of the tiles are like that?

Thanks.

@petemill
Copy link
Member

Should be fixed with 0.22.108

@LaurenWags
Copy link
Member

Site listed in STR works, but other sites (twitter and github) are still displaying a letter instead of favicon. Tested with 0.22.109:
13728

@LaurenWags LaurenWags reopened this Apr 11, 2018
@LaurenWags
Copy link
Member

It looks like instead of displaying the favicons it's displaying the first letter of the tab title. In the below image I opened 0.22.109 with a clean profile then closed the about:welcome page. From the new tab page, I cmd+clicked on each of the default top site tiles. After a few seconds, the favicons changed to the letters (only the pinned twitter tab retained the favicon):
screen shot 2018-04-11 at 5 45 24 pm

@petemill
Copy link
Member

petemill commented May 1, 2018

Found the bug and fixed it. Should be fixed with 0.22.701

@LaurenWags
Copy link
Member

LaurenWags commented May 3, 2018

Verified with macOS 10.12.6 using

Verified on Windows x64

  • 0.22.702 e4a853d
  • libchromiumcontent 66.0.3359.139
  • muon: 6.0.7

Verified on Ubuntu 17.10 x64
0.22.703 903b8d0
libchromiumcontent 66.0.3359.139
muon: 6.0.8

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants