about:newtab tile favicons are inconsistent in size

[alexwykoff]

Description

When visiting the new tab page, the favicons are different sizes.

Steps to Reproduce

Visit a random set of sites, usually Hacker News is ok, but Facebook & YouTube occasionally go through the shrink ray.

1. Visit a few different sites
2. Open a new tab
3. Observe favicons in tiles

Actual result:

Expected result:
The favicons should all be of a consistent size.

Reproduces how often: [What percentage of the time does it reproduce?]
100%

Brave Version

It's been an issue since newtab was implemented.

about:brave info:

Reproducible on current live release:
Yes

Additional Information

[MargarytaChepiga]

Hello! I think this is because we set the img to max-width and max-height. Which sets the limit only for the maximum size of the image. So if the favicon is smaller than 64px it will display it's original weight and height. Here:

browser-laptop/less/about/newtab.less

Line 235 in 56f9e72

img {

The solution I see to this is to make the size static. But then the icons might not look good if their initial size is much smaller. Any ideas? Is anyone is working on this btw?
Before:

After:

[bradleyrichter]

@MargarytaChepiga My only concern with this otherwise nice fix is that, as you said, the 16x size icons will scale up and look fuzzy. Is there a way to add an exception to prevent this?

(only allow favicons to scale up to the desired height/width if they are large enough.)

[MargarytaChepiga]

@bradleyrichter yes, I can do that. But again, the icons won't be the same size.

[MargarytaChepiga]

@bradleyrichter If you mean to leave them the same size ( as in don't scale up 16px) then it's pretty much the same thing as it was before with the only difference that the favicons size is smaller now. Take a look please: