Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

bookmark bar folder and file icons are misaligned when overflow indicator is visible #13789

Closed
petemill opened this issue Apr 10, 2018 · 1 comment
Closed

bookmark bar folder and file icons are misaligned when overflow indicator is visible #13789

petemill opened this issue Apr 10, 2018 · 1 comment
Assignees
@petemill
Labels
0.22.x issue first seen in 0.22.x QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release-notes/exclude
Milestone
0.22.x Release 3 ...

Comments

@petemill
Copy link
Member

petemill commented Apr 10, 2018 •
edited by bsclifton
Loading

Test plan

See #13986

Steps to Reproduce

  1. Bookmark many items and at least one folder
  2. Switch to favicons only
  3. Resize window to show overflow indicator from not showing overflow indicator

Actual result:
Folder and default favicon (i.e. document icon) jump a couple of pixels vertically.

Expected result:
Same alignment as when overflow indicator is not present

Reproduces how often:
100%

Brave Version

about:brave info:
0.22.x single webview
0.23.x source
master

Reproducible on current live release:
No

Additional Information

Caused by #13758
@petemill petemill added regression 0.22.x-single-webview Issue first seen on single-webview build against v0.22.x branch labels Apr 10, 2018
@petemill petemill added this to the 0.22.x Release 3 (Beta channel) milestone Apr 10, 2018
@petemill petemill self-assigned this Apr 10, 2018
petemill added a commit that referenced this issue May 2, 2018
@petemill
Ensure all icons in bookmarks bar are vertically aligned
fe85850 
Fix #13789

Also restore different bookmarks bar height when in text-only mode vs with favicons.
Fix #13985

Also reduce flicker of bookmark bar / overflow-indicator / last item by having aphrodite not remove the custom class-name on render.
@petemill petemill mentioned this issue May 2, 2018
Merged
10 tasks
@petemill petemill added PR/pending-review 0.22.x issue first seen in 0.22.x and removed 0.22.x-single-webview Issue first seen on single-webview build against v0.22.x branch labels May 2, 2018
petemill added a commit that referenced this issue May 2, 2018
@petemill
Ensure all icons in bookmarks bar are vertically aligned
9306021 
Fix #13789

Also restore different bookmarks bar height when in text-only mode vs with favicons.
Fix #13985

Also reduce flicker of bookmark bar / overflow-indicator / last item by having aphrodite not remove the custom class-name on render.
petemill added a commit that referenced this issue May 3, 2018
@petemill
Ensure all icons in bookmarks bar are vertically aligned
681349d 
Fix #13789

Also restore different bookmarks bar height when in text-only mode vs with favicons.
Fix #13985

Reduce flicker of bookmark bar / overflow-indicator / last item by having aphrodite not remove the custom class-name on render.

Reduce complexity of bookmarks toolbar state by passing through ToolbarMode 'enum' to component.
Future-proof bookmark mode setting retrieval for state-selector-memoization by passing through appState
This was referenced May 8, 2018
Closed
Closed
Closed
@btlechowski
Copy link
Contributor

btlechowski commented May 8, 2018 •
edited by LaurenWags
Loading

Verified on Ubuntu 17.10 x64
0.22.703 903b8d0
libchromiumcontent 66.0.3359.139
muon: 6.0.8

Verified on Windows x64

  • 0.22.703 903b8d0
  • libchromiumcontent 66.0.3359.139
  • muon: 6.0.8

Verified with macOS 10.12.6 using

  • 0.22.703 903b8d0
  • muon 6.0.8
  • libchromiumcontent 66.0.3359.139

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@petemill petemill

Labels
0.22.x issue first seen in 0.22.x QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release-notes/exclude
Projects
None yet
Milestone
0.22.x Release 3 (Release Channel)
Development

No branches or pull requests
6 participants
@petemill @kjozwiak @bsclifton @srirambv @LaurenWags @btlechowski