Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

brave crashing when submitting online forms on some websites #13947

Closed
kjozwiak opened this issue Apr 26, 2018 · 4 comments · Fixed by brave/muon#579
Closed

brave crashing when submitting online forms on some websites #13947

kjozwiak opened this issue Apr 26, 2018 · 4 comments · Fixed by brave/muon#579
Assignees
@darkdh
Labels
0.22.x issue first seen in 0.22.x cr66 crash priority/P2 Crashes. Loss of data. Severe memory leak. QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified regression release-notes/include
Milestone
0.22.x Hotfix

Comments

@kjozwiak
Copy link
Member

kjozwiak commented Apr 26, 2018 •
edited
Loading

Description

There's been several reports of Brave crashing when submitting online forms on several different websites, few examples:

Steps to Reproduce

Example 1:

  1. launch 0.22.667 0433b26
  2. visit https://check.aec.gov.au/
  3. click on Verify Enrollment -> Brave crashes

Example 2:

  1. launch 0.22.667 0433b26
  2. visit http://www.elliott.org/help and fill out the form
  3. click on Submit -> Brave crashes

Example 3:

  1. launch 0.22.667 0433b26
  2. visit https://www.netvibes.com/en#!signin
  3. click on Login -> Brave crashes

Example 4:

  1. launch 0.22.667 0433b26
  2. https://ofsguestsurvey.wufoo.com/forms/q1kktnxw1icoiro/def/Field1942=LON&Field1=9D0F8E1C&Field2255=1&Field2257=5&Field2259=Caroline%20G
  3. click on Submit -> Brave crashes

Example 5:

  1. launch 0.22.667 0433b26
  2. visit https://www.paypal.com
  3. click on Log in at the top of the web page
  4. enter an email address and press Next -> Brave crashes

Example 6:

  1. launch 0.22.667 0433b26
  2. visit www.compostrevolution.com.au/australia-wide/shop
  3. click on Confirm Order which will take you to the form submission page
  4. click on Continue -> Brave crashes

Example 7:

  1. launch 0.22.667 0433b26
  2. visit https://store.brave.com/
  3. click on any of the items and select Add to Cart
  4. select Checkout on the modal that you receive once you've added something into the cart
  5. click on Continue to Shipping Method -> Brave crashes

Actual result:

Brave crashes when users submit online forms on several different websites.

Expected result:

Brave shouldn't be crashing when users are submitting online forms.

Reproduces how often:

Reproducible 100% of the time using the above two examples.

Brave Version

about:brave info:

Brave: 0.22.667
V8: 6.6.346.24
rev: 0433b26
Muon: 5.2.6
OS Release: 17.4.0
Update Channel: Release
OS Architecture: x64
OS Platform: macOS
Node.js: 7.9.0
Brave Sync: v1.4.2
libchromiumcontent: 66.0.3359.117

Reproducible on current live release:

Yes, currently reproducible using 0.22.667 0433b26 which was just released.

Additional Information

Example of crash report: https://stats.brave.com/dashboard#crash/5ae14047be25a1001f7a1ee6
@kjozwiak kjozwiak added crash regression priority/P2 Crashes. Loss of data. Severe memory leak. 0.22.x issue first seen in 0.22.x cr66 labels Apr 26, 2018
@kjozwiak kjozwiak added this to the Backlog (Prioritized) milestone Apr 26, 2018
@darkdh darkdh self-assigned this Apr 26, 2018
darkdh added a commit to brave/muon that referenced this issue Apr 26, 2018
@darkdh
Disable credit card upload by default to avoid accessing null Identit…
5714fef 
…yManager

from GetIdentityManager stubbed by us

fix brave/browser-laptop#13947

Auditors: @bridiver, @bsclifton
@darkdh darkdh mentioned this issue Apr 26, 2018
Merged
@bsclifton bsclifton changed the title brave crashing when sumbitting online forms on some websites brave crashing when submitting online forms on some websites Apr 26, 2018
@bsclifton bsclifton modified the milestones: Backlog (Prioritized), 0.22.x Hotfix Apr 26, 2018
@LaurenWags
Copy link
Member

twitter +1s:
https://twitter.com/i_am_jasin/status/989483000953032705
https://twitter.com/dliebo/status/989466673458679808

@kjozwiak kjozwiak mentioned this issue Apr 26, 2018
Closed
@srirambv srirambv mentioned this issue Apr 26, 2018
Closed
@DavidRBailey
Copy link

Duplicate: #13954

@LaurenWags
Copy link
Member

+1s from community: https://community.brave.com/t/ebay-sign-in-crashes-brave/20948

This was referenced Apr 26, 2018
Closed
Closed
This was referenced Apr 27, 2018
Closed
Closed
Closed
@kjozwiak kjozwiak mentioned this issue Apr 27, 2018
Closed
@kjozwiak kjozwiak mentioned this issue Apr 27, 2018
Closed
8 tasks
@srirambv
Copy link
Collaborator

srirambv commented Apr 27, 2018 •
edited by kjozwiak
Loading

Verified on Windows with 0.22.669 on both upgrade profile and clean profile. No crash when submitting form.

Verified on macOS x64 with 0.22.669 on both upgrade profile and clean profile. No crash when submitting form.

Verified on Ubuntu 17.10 x64 with 0.22.669 on both upgrade profile and clean profile. No crash when submitting form.

Verified on Win 10 x86 with 0.22.669 on both upgrade profile and clean profile. No crash when submitting form.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@darkdh darkdh

Labels
0.22.x issue first seen in 0.22.x cr66 crash priority/P2 Crashes. Loss of data. Severe memory leak. QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified regression release-notes/include
Projects
None yet
Milestone
0.22.x Hotfix
Development

Successfully merging a pull request may close this issue.

Disable credit card upload by default brave/muon
7 participants
@kjozwiak @bsclifton @DavidRBailey @darkdh @srirambv @LaurenWags @btlechowski