This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 975
Cannot scroll webview contents #13982
Labels
0.22.x-single-webview
Issue first seen on single-webview build against v0.22.x branch
QA/checked-Linux
QA/checked-macOS
QA/checked-Win64
QA/test-plan-specified
release-notes/exclude
Milestone
Comments
petemill
added
the
0.22.x-single-webview
Issue first seen on single-webview build against v0.22.x branch
label
May 1, 2018
bridiver
added a commit
to brave/muon
that referenced
this issue
May 4, 2018
probable fix for brave/browser-laptop#13982 auditors @PeteMiller
fixed brave/muon@7439cde |
Reproduced with 0.22.702 - had been testing the |
This was referenced May 8, 2018
This is definitely fixed since there has not been a single report since the fix and it was occuring almost every tab switch for me. Test plan is just to switch to any tab for the first time and see if it can be scrolled. |
bsclifton
added
QA/test-plan-specified
release-notes/exclude
and removed
QA/test-plan-required
labels
May 14, 2018
This was referenced May 15, 2018
Verified with macOS 10.12.6 using
Verified on Windows x64 using
Verified on Ubuntu 17.10 x64
|
bridiver
added a commit
to brave/muon
that referenced
this issue
May 15, 2018
probable fix for brave/browser-laptop#13982 auditors @PeteMiller
bridiver
added a commit
to brave/muon
that referenced
this issue
Jun 17, 2018
commit 0c4a3357350ed78eb5b1c7c3efb9e66b7cf7313a Author: bridiver <github@brianjohnson.cc> Date: Sun Jun 17 15:08:27 2018 -0700 misc merge fixes commit 097bbfe62d61397adf6b6c44bde6af4c785d6d14 Author: bridiver <github@brianjohnson.cc> Date: Fri Jun 15 19:04:30 2018 -0700 fix build errors commit bdc5b56fc1c12c3c61a97138f387fdaf967a11b8 Author: bridiver <github@brianjohnson.cc> Date: Fri Jun 15 15:19:51 2018 -0700 remove patches that don't apply correctly commit 9867cc0bad140ba94a4e366a2c8faefbd3cb88ad Merge: 7de25657c 2527f9c39 Author: bridiver <github@brianjohnson.cc> Date: Thu Jun 14 18:22:20 2018 -0700 Merge branch 'C67-rebase' commit 2527f9c3969b294dabf5db102f1b62dbff768bcc Author: bridiver <github@brianjohnson.cc> Date: Tue Jun 12 19:27:57 2018 -0700 Bump v7.0.7+67.0.3396.87 commit 8e4273a6995254a00fdeea8aefd637314b0c9719 Author: bridiver <github@brianjohnson.cc> Date: Mon Jun 11 16:40:19 2018 -0700 Bump v7.0.6+67.0.3396.71 commit a22badd3cc9c94d281124bd700860c6d3e7a59fd Author: bridiver <github@brianjohnson.cc> Date: Mon Jun 11 16:38:40 2018 -0700 don't use spare renderer for extensions fix https://github.com/brave/browser-laptop/issues/14380 commit f3df64c20b5c86a10680aed2c00df0376538cedc Author: bridiver <github@brianjohnson.cc> Date: Mon Jun 11 13:57:04 2018 -0700 enable `chrome.i18n.getAcceptLanguages` fix https://github.com/brave/browser-laptop/issues/8326 auditors: @jonathansampson commit 7ba56bd04019d8b6f7963211398df5c82b96631c Author: bridiver <github@brianjohnson.cc> Date: Sun Jun 10 19:03:05 2018 -0700 Bump v7.0.6+67.0.3396.79 commit 699c819ab81115e26a3c680c6b6162fefa0e8cb0 Author: Brian Johnson <github@brianjohnson.cc> Date: Sun Jun 10 19:02:15 2018 -0700 Merge pull request #606 from brave/fix-copy-paste-from-context-menu Check if web contents is attached before allowing it to be considered as focused commit 0dc2bcba36d2b42222efbcf85f6f93bce976fc3a Author: bridiver <github@brianjohnson.cc> Date: Wed Jun 6 17:24:27 2018 -0700 Bump v7.0.5+67.0.3396.79 commit e2bde158162ffb822d97e9305f2b4b8e3a694246 Author: bridiver <github@brianjohnson.cc> Date: Mon Jun 4 19:48:10 2018 -0700 Bump v7.0.4+67.0.3396.71 commit d249b8f3b2281ba856c89a8de3b3ce8b62985438 Author: bridiver <github@brianjohnson.cc> Date: Sun Jun 3 22:16:50 2018 -0700 Bump v7.0.3+67.0.3396.48 commit 35a8d0a1dac072781fb5725032e9eec9a52e42ed Author: Anthony Tseng <darkdh@gmail.com> Date: Fri Jun 1 15:25:38 2018 -0700 RenderWidgetHostNSViewBridge::SetTargetView for legacy webview The other side of bridge (RenderWidgetHostViewCocoa) of legacy webview is not valid https://chromium.googlesource.com/chromium/src/+/98581bb30ea1eaebee3c3e4fb4c49e4a2446deca fix https://github.com/brave/browser-laptop/issues/14247 Auditor: @bridiver, @hferreiro, @ltilve commit 57b180415f0b32d2184b05f1127197836cab036b Author: bridiver <github@brianjohnson.cc> Date: Thu May 31 18:49:50 2018 -0700 Bump v7.0.2+67.0.3396.48 commit bcdc2a4780cdf5b7cbcd059963bff7e42d55a9d9 Author: Brian Johnson <github@brianjohnson.cc> Date: Fri Mar 30 12:26:05 2018 -0700 Merge pull request #550 from brave/fix_526 Fix #526: Adding static pins for Amazons CAs commit d7b67ac0ef23620042b3960a13fd7e3e5c712639 Author: bridiver <github@brianjohnson.cc> Date: Thu May 31 12:27:37 2018 -0700 make sure the webcontents getes deleted on block even if `was_blocked` is null fix https://github.com/brave/browser-laptop/issues/14261 auditors @bsclifton @petemiller commit 7f4521d29ed8a0bade233c3de00293c4920d2dfa Author: bridiver <github@brianjohnson.cc> Date: Tue May 29 17:09:35 2018 -0700 Bump v7.0.1+67.0.3396.48 commit 18a1394b743bd04b9408c9f39595eede6c55e598 Author: Anthony Tseng <darkdh@gmail.com> Date: Tue May 29 16:31:40 2018 -0700 Explicitly calling `ExtensionWebContentsObserver::Initialize` https://chromium.googlesource.com/chromium/src/+/399b6c3d211c09e1e0a003e8edb547043535bf77 fix brave/browser-laptop#14252 Auditor: @bridiver commit d507b31a3d587b13e9ba4dd2aba9ed259bdb1849 Author: bridiver <github@brianjohnson.cc> Date: Tue May 29 15:37:58 2018 -0700 lint fixes commit c72746969697d95359f9076a5a0d368d1aa17e54 Author: bridiver <github@brianjohnson.cc> Date: Tue May 29 15:36:38 2018 -0700 LifecycleUnits are now used for tab discarding https://crrev.com/a271a5c03ac2 auditors @hferreiro @darkdh commit b903f9b924ff19627bf1f6c6e3f34716127d30c1 Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Mon May 28 10:08:29 2018 +0200 Remove unused WIDEVINE_CDM_AVAILABLE_NOT_COMPONENT commit 82f2e95688d95fc2236331e56fdeeeeffe567ea6 Author: Lorenzo Tilve <ltilve@igalia.com> Date: Fri May 25 15:06:26 2018 +0200 chromium_src: C67 Updates to content_settings_observer.cc commit af44404c9b4de4a3da677f9640c3e74d77e3b15d Author: bridiver <github@brianjohnson.cc> Date: Tue May 22 19:40:42 2018 -0700 bump chromedriver version commit cc67385ea4f4d12c98affcf540bb32306d60a302 Author: bridiver <github@brianjohnson.cc> Date: Tue May 22 12:17:43 2018 -0700 Bump v7.0.0+67.0.3396.48 commit ce229ea8a545bfad8f34564c9533681bf86304a1 Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Fri May 18 10:01:12 2018 +0200 chromium_src: Add missing blink/public/mojom:mojom_platform dep Fixes the following error: ../../content/public/browser/render_frame_host.h:18:10: fatal error: 'third_party/blink/public/mojom/page/page_visibility_state.mojom.h' file not found #include "third_party/blink/public/mojom/page/page_visibility_state.mojom.h" ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated. commit b3d7213e9922166525b039e2fa662e8eb30403a5 Author: Lorenzo Tilve <ltilve@igalia.com> Date: Thu May 17 19:22:38 2018 +0200 Fix lint issues commit 83f8c85ed1dbb004dce48607d62ea95b28836891 Author: Lorenzo Tilve <ltilve@igalia.com> Date: Wed May 16 23:24:24 2018 +0200 Add unimplemented AreServerCardsSupported override https://crrev.com/50f8f8228b96 commit c0a323cb81764fb0771816ed727fb36292d6a112 Author: Lorenzo Tilve <ltilve@igalia.com> Date: Thu May 10 10:56:33 2018 +0200 Fix win linking issues commit 07e494afd59bbdee332ba2572a3521cba709ef96 Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Wed May 9 13:53:38 2018 +0200 Fix linking issues with 'is_debug = true' commit 7e625a5cc3de8e16e8df6e600959366f82e82b94 Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Mon May 7 13:45:59 2018 +0200 chromium_src: C67 Updates to profile_io_data.cc commit 84a3d6fcdcde213aee402c23ccc29594b43072fa Author: Lorenzo Tilve <ltilve@igalia.com> Date: Thu May 3 13:35:09 2018 +0200 Change UserGestureDone to NavigatedByUser https://crrev.com/d4599909a503 commit 2665b242dfe04886af3711fc5af1cf0c03f1ba31 Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Wed May 2 11:39:10 2018 +0200 Stub Browser::OpenURL() Fixes a Windows compilation error: ../../chrome/browser/safe_browsing/chrome_cleaner/ chrome_cleaner_navigation_util_win.cc(56,12): error: no member named 'OpenURL' in 'Browser' browser->OpenURL(content::OpenURLParams( ~~~~~~~ ^ commit baf459239cd0d83d16c4a1534e23d7581779ddd2 Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Mon Apr 30 12:12:07 2018 +0200 Stub some LocationBarView static methods Fixes this linking errors: error: undefined symbol: LocationBarView::GetAvailableTextHeight() >>> referenced by chrome_typography.cc:62 (../../chrome/browser/ui/views/harmony/chrome_typography.cc:62) >>> obj/electron/chromium_src/browser/chrome_typography.o: (ApplyCommonFontStyles(int, int, int*, gfx::Font::Weight*)) error: undefined symbol: LocationBarView:: GetAvailableDecorationTextHeight() >>> referenced by chrome_typography.cc:78 (../../chrome/browser/ui/views/harmony/chrome_typography.cc:78) >>> obj/electron/chromium_src/browser/chrome_typography.o: (ApplyCommonFontStyles(int, int, int*, gfx::Font::Weight*)) commit 893ac85fba6e56ccdba703537e8217ae2506cf5d Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Fri Apr 27 13:17:16 2018 +0200 Add material_refresh_layout_provider.cc as a dependency Fixes the following linking error: error: undefined symbol: vtable for MaterialRefreshLayoutProvider >>> referenced by material_refresh_layout_provider.h:13 (../../chrome/browser/ui/views/harmony/ material_refresh_layout_provider.h:13) >>> obj/electron/chromium_src/browser/chrome_layout_provider.o: (ChromeLayoutProvider::CreateLayoutProvider()) commit 0be7f204be4562a8523bdda8204bb256b770da79 Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Wed Apr 25 13:52:19 2018 +0200 chromium_src: C67 updates to UpgradeDetectorImpl commit 9f583629372ad944fdfff32a950b482fb896c642 Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Fri Apr 27 12:08:46 2018 +0200 chromium_src: Stub ChromePasswordProtectionService::ShouldShowChangePasswordSettingUI() Fixes the following linking error: error: undefined symbol: safe_browsing::ChromePasswordProtectionService:: ShouldShowChangePasswordSettingUI(Profile*) >>> referenced by security_state_tab_helper.cc:277 (../../chrome/browser/ssl/security_state_tab_helper.cc:277) >>> obj/electron/chromium_src/browser/security_state_tab_helper.o: (SecurityStateTabHelper::GetMaliciousContentStatus() const) commit 57072915dd889c5381d471055466c4e225d21dde Author: Lorenzo Tilve <ltilve@igalia.com> Date: Tue Apr 24 12:39:34 2018 +0200 Add missing framework_version/framework_contents params for Mac https://crrev.com/8685feba0505 commit 324a8071ce95c27d5ea98f786086d6050e2d0829 Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Thu Apr 26 12:26:41 2018 +0200 TODO: Disable //extensions/browsershared_user_script_master.* It duplicated symbols in //atom/browser/extensions/shared_user_script_master.* Investigate if the upstream file can be used. They are identical besides Brave version using AtomExtensionsBrowserClient::IsIncognitoEnabled() instead of util::IsIncognitoEnabled(). The former comments "ExtensionPrefs::Get(context)->IsIncognitoEnabled(extension_id);" with a TODO. Can we make that call work? commit 335b5e48a911fc306cfb0e5792694385fd5be1e5 Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Wed Apr 25 14:21:39 2018 +0200 chromium_src: C67 updates to IOThread commit 708bfd35c8249fa9c795685e9ff754a4be2467e4 Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Wed Apr 25 11:52:15 2018 +0200 Make NativeWindow::IsVisible() a const method IsVisible() was added to ui::BaseWindow in https://crrev.com/9421d88bf70e commit f9929eddd77520f5aea3f32ce37ed3644138ae29 Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Wed Apr 25 08:00:00 2018 +0200 extensions/utility/ has been removed https://crrev.com/b6f2cc9ca6f6 commit 2259bf4727d0c16e1d7b6b1ed6a902766eba7fc5 Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Wed Apr 25 07:49:12 2018 +0200 "chrome/utility/extensions/extensions_handler.h" was removed https://crrev.com/fbc2f693490f commit 4601e5025d93e86aeff81d2bbe058bd5e8e82d78 Author: Lorenzo Tilve <ltilve@igalia.com> Date: Tue Apr 24 17:09:26 2018 +0200 Expose GetPermissionStatusForFrame through the content PermissionManager API https://crrev.com/4ead6c35d84f commit f17b676dc059a9dc472cead319825e0a334066ab Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Tue Apr 24 14:26:35 2018 +0200 Update Node to C67 branch commit 3334bd167f2a4d6f905cb5900f3b0a5773135853 Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Tue Apr 24 12:27:45 2018 +0200 Remove `process.getProcessMemoryInfo()` Platform-specific memory metrics were removed in favor of the memory_instrumentation service. https://crrev.com/d447bb62da40 https://crrev.com/07e3ce4f1317 https://crrev.com/19ad19ef88be commit 8158ec0707af8537cfa4a0cc2b999122c5eff2a5 Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Mon Apr 23 15:44:53 2018 +0200 ExtensionApiFrameIdMap::CacheFrameData() => InitializeRenderFrameHost() https://crrev.com/399eed41d62b https://crrev.com/8418c66bd1f8 commit 57c985eaa65a6443a45804e03b1b1cc43514b43d Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Mon Apr 23 14:28:39 2018 +0200 Move content script classes from chrome/ to extensions/ https://crrev.com/b96abb855efb commit 71c272d7191928e1273a40a96ed907c84b4273ca Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Mon Apr 23 14:23:21 2018 +0200 Allow content script requests to attach SameSite cookies https://crrev.com/13105d485c94 commit f2ac608b02058449d5c8f4bcd43ae3522d145d4b Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Mon Apr 23 14:09:30 2018 +0200 C67 updates for ExtensionTabUtil https://crrev.com/2f127c42d218 https://crrev.com/a271a5c03ac2 commit 439a0cebc850a663f719210bc2c0c5e0eb8c2205 Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Mon Apr 23 13:51:27 2018 +0200 C67 changes to BrowserProcessImpl commit 35bb4e47daf3ebc6d42d2da0dbfc3875a5099bd3 Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Mon Apr 23 12:46:16 2018 +0200 Rename SCHEME_WITHOUT_PORT to SCHEME_WITH_HOST https://crrev.com/123ca19dd4e7 commit 08b7fdb8ae70d3add5f3b2073ae1a9178429f281 Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Mon Apr 23 12:44:28 2018 +0200 Stub BravePasswordManagerClient::LogPasswordReuseDetectedEvent() https://crrev.com/da5d0c766f26 commit 70e7cf0a4ccda16ae919222c534fb80463954eaf Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Mon Apr 23 11:34:09 2018 +0200 Handle external protocols with the network service https://crrev.com/a67add8097a5 commit f076c1a234ca5152d6a42c2a2d0728bc05414873 Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Mon Apr 23 07:41:28 2018 +0200 Allow user agent to be overridden in popup webview creation https://crrev.com/c1134a866ccc commit 76b3b7a4740b1b37598249fb15a585ac74eb2d5e Author: Lorenzo Tilve <ltilve@igalia.com> Date: Sun Apr 22 12:59:29 2018 +0200 Fix lint issues for make_unique<> commit 1c00a36d211e197d732e864bc46452b49250eb31 Author: Lorenzo Tilve <ltilve@igalia.com> Date: Sun Apr 22 12:46:37 2018 +0200 Group experimental canvas features with the rest of web platform features https://crrev.com/2a7c3b2cd5c6 commit f7f991c19cc4184ca6b280369a64e15dac1090c9 Author: Lorenzo Tilve <ltilve@igalia.com> Date: Sun Apr 22 11:54:40 2018 +0200 Removed SyzyProf profiling support https://crrev.com/69d0bcdd9729 commit 128d6edd5049e886d48b75818fc707f16821cb9c Author: Lorenzo Tilve <ltilve@igalia.com> Date: Sun Apr 22 11:24:33 2018 +0200 PasswordManagerClient::GetPrefs() is changed to a const function https://crrev.com/c18a57c2b9c8 commit 597e26207babc816ef76b830d59fe6a2b979886b Author: Lorenzo Tilve <ltilve@igalia.com> Date: Sun Apr 22 11:11:21 2018 +0200 Simplify EnsureProcessTerminated() implementations https://crrev.com/c18a57c2b9c8 commit 1403f81c99c581765ecde0f19ac7a401305a15aa Author: Lorenzo Tilve <ltilve@igalia.com> Date: Sun Apr 22 11:01:52 2018 +0200 Plumb the RenderFrameHost through for CheckMediaAccessPermission https://crrev.com/ad7c24a16ce2 commit 118458c0a3e77956e2d2e9239aeb29ef334eadfe Author: Lorenzo Tilve <ltilve@igalia.com> Date: Sat Apr 21 23:51:01 2018 +0200 Report multiple reused domains in PhishGuard pings https://crrev.com/3686eccdb757 commit 4a22b15e52d042adaf673d42f4796cde7a81e0cc Author: Lorenzo Tilve <ltilve@igalia.com> Date: Sat Apr 21 23:40:57 2018 +0200 Move STHDistributor, STHObserver, and STHReporter out of //net https://crrev.com/6d00e4f36107 commit 5aa56a1a321f97481265dd63b02655912fb3f223 Author: Lorenzo Tilve <ltilve@igalia.com> Date: Sat Apr 21 23:33:06 2018 +0200 Migrate BrowserThread::IsMessageLoopValid to BrowserThread::IsThreadInitialized https://crrev.com/2983181ccb26 commit 9abf2845e0c0680da30d8424c10ee0c4cec63f35 Author: Lorenzo Tilve <ltilve@igalia.com> Date: Sat Apr 21 23:15:35 2018 +0200 Use base::Value by value instead of std::unique_ptr https://crrev.com/95facbc5d103 commit ead17124313914cf58a2687d56e39f5f17cc6846 Author: Lorenzo Tilve <ltilve@igalia.com> Date: Sat Apr 21 22:43:38 2018 +0200 Move //components/unzip_service to //components/services/unzip https://crrev.com/6a897c7180f6 commit ba6c224f5bab71cf119b749805db7a8a7c5d2ef8 Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Fri Apr 20 14:31:09 2018 +0200 Remove base::MakeUnique https://crrev.com/0e26b21394de commit d1cae4f3bbbb3d2451692314a49c09563b6ebbaf Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Fri Apr 20 14:08:03 2018 +0200 Rename various ProxyService symbols to refer to ProxyResolutionService https://crrev.com/d567e868e691 commit 20b287827de32766b6418a64f41c718a35a39691 Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Fri Apr 20 14:05:42 2018 +0200 Rename references to "proxy scripts" to "pac files" https://crrev.com/995978677120 commit 1cdf9a27b6c080dd00adf46356d88fa230154184 Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Fri Apr 20 13:59:19 2018 +0200 Replace ProxyConfigSource with ProxyConfigWithAnnotation https://crrev.com/ca8d525d49c7 commit ea820172d643c63b9f7265fc8e96cb8a9c45267c Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Fri Apr 20 13:24:49 2018 +0200 Rename net/proxy_resolution/{proxy_service => proxy_resolution_service}.h https://crrev.com/ffe89daa07d6 commit 9d11aa1db8f7c86555d1dc10aee528302b435330 Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Fri Apr 20 13:21:30 2018 +0200 SpecialStoragePolicy virtual methods changed https://crrev.com/e1e1772f872b commit 1643089a39a57751c41e1e6ca9ec322b789f7639 Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Fri Apr 20 13:02:01 2018 +0200 Rename ResourceDispatcherHostLoginDelegate to LoginDelegate https://crrev.com/d7502e51c35c commit 70789a2de90cea369b80df7467cae1ebd4a9ef8a Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Fri Apr 20 12:36:52 2018 +0200 Change atom::api::WebContents::CheckMediaAccessPermission() parameters https://crrev.com/ad7c24a16ce2 commit 47cfee7b5a0ba53d953728612c1f26985cddbdf6 Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Fri Apr 20 12:34:22 2018 +0200 DevTools: do not index excluded folders https://crrev.com/007878869255 commit 96bca4138a5eb6ffc06cda8f92f5483eb9aa5431 Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Wed Apr 18 13:46:27 2018 +0200 DevTools: deprecate devtools_protocol helpers on the chrome level, use inspector_protocol generator https://crrev.com/0aaf77db834d commit 8963e4d85696e29a8790b4a45f4b8872504a967a Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Wed Apr 18 12:23:33 2018 +0200 Rename buildflag_headers for consistency https://crbug.com/814485 https://crrev.com/02e38b93c348 https://crrev.com/c8240b098394 https://crrev.com/318a55fc28aa https://crrev.com/a5f7ba11e697 https://crrev.com/a35f9a482b70 https://crrev.com/d7983c5387fe https://crrev.com/0caaaf430f7c commit dd9368ce690968e5981d4550b608bf0194c75012 Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Wed Apr 18 13:30:42 2018 +0200 //mojo/edk/system subsumed by //mojo/edk https://crrev.com/773a51f03d60 https://crrev.com/898d796d5977 commit 517960a1adca7d287f0395811ed2244a43d96274 Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Wed Apr 18 13:07:42 2018 +0200 Revert "Add missing //components/proximity_auth/public/interfaces mojo dep" This reverts commit 7f017784177b00d8174acbfe901a6f2bf2f70ce2. Not needed since https://crrev.com/813085eba93e where the component was moved to chromeos/. commit 3ce0b0a4d192502bfa91de65744b9010500eeeb6 Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Tue Apr 17 10:54:36 2018 +0200 Switch to Debian Sid sysroot https://crrev.com/13734d4601ef commit 3665af82b497c4ec379ecd6155fe097ddf473dc9 Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Tue Apr 17 16:47:36 2018 +0200 Update patches to Chromium 67.0.3396.56 commit 5f68bbecb216305837b7bd7dfb9427f14075b9cc Author: Lorenzo Tilve <ltilve@igalia.com> Date: Thu Apr 26 13:28:05 2018 +0200 Pepper CDM is being deprecated in favor of mojo CDM https://crrev.com/729d804e8f8b https://crrev.com/d5b69c8251c1 https://crrev.com/de910d0e7867 commit adc20ce15024e0823a747179accb4fe5e19abc05 Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Tue Apr 17 18:06:34 2018 +0200 alink patch to use -filelist in Mac was added upstream https://crrev.com/0a289a6f9912 commit 4cd961762fb40d97d210acc66fb3dd8d5436c8b9 Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Tue Apr 17 16:56:19 2018 +0200 Revert "DROP: temporary fix for an upstream build error in Chromium" This reverts commit eb080bcfb684f317c1c9ef994655604325e7459a. commit e9ed3b6efa36cc243a54792c17f434c12fea89b8 Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Wed Apr 18 12:36:14 2018 +0200 The Great Blink mv https://crrev.com/a30d423812ad https://crrev.com/0aee4434a4db commit b388d882caa32e4767653c8c3990690eb9e2c5f4 Author: bridiver <github@brianjohnson.cc> Date: Thu May 17 13:07:45 2018 -0700 Bump v6.0.12+66.0.3359.170 commit ff8b6f552606fb76a9e43480476eb425292b9cde Author: bridiver <github@brianjohnson.cc> Date: Thu May 17 15:26:02 2018 -0700 let the order controller do all the work auditors: @petemiller @bbondy commit 67319635346db4c5548594cf045758cde99c38db Author: bridiver <github@brianjohnson.cc> Date: Thu May 17 13:07:40 2018 -0700 defer calling ResumeLoadingCreatedWebContents for renderer initiated navigations auditors @petemiller @darkdh commit d7d575c309eb49cdba5505b9afca0aae6f587576 Author: bridiver <github@brianjohnson.cc> Date: Fri May 18 10:33:51 2018 -0700 remove direct dependency on `request` - there is still a nested dep through mksnapshot, but we're not using those tools either auditors: @diracdeltas commit 51c159ee6e886851f829418e10ea0027f9694606 Author: bridiver <github@brianjohnson.cc> Date: Tue May 15 15:10:55 2018 -0700 misc build fixes commit d7f00a428044654ef759e9b055e3d95f6fc17541 Author: bridiver <github@brianjohnson.cc> Date: Mon May 14 14:41:02 2018 -0700 Bump v6.0.11+66.0.3359.170 commit 8ab70054663c469a968f9e89470a2d33012a97d5 Author: bridiver <github@brianjohnson.cc> Date: Mon May 14 14:40:56 2018 -0700 background pages don't have tab helpers fix https://github.com/brave/browser-laptop/issues/14079 commit 211fce9923398f89a5c63a064317b6bf6dc431ee Author: bridiver <github@brianjohnson.cc> Date: Fri May 11 12:51:49 2018 -0700 Bump v6.0.10+66.0.3359.170 commit 604cbc808da57f341062c795d05bda2959467dc5 Author: bridiver <github@brianjohnson.cc> Date: Wed May 9 16:10:11 2018 -0700 Bump v6.0.9+66.0.3359.139 commit 3bb5db3032c03dfb52e048e281c0d0a2c4ec9c0a Author: bridiver <github@brianjohnson.cc> Date: Wed May 9 16:09:59 2018 -0700 always pass an int to fromID/fromTabID auditors @petemiller fix https://github.com/brave/browser-laptop/issues/14075 commit ec2b1fa7f285a742e29a08610a8b1eeba48a5c4c Author: bridiver <github@brianjohnson.cc> Date: Sun May 6 16:54:26 2018 -0700 Bump v6.0.8+66.0.3359.139 commit 805698330f971c976ac64d9507e7e24abd7f0d9e Author: Anthony Tseng <darkdh@gmail.com> Date: Sun May 6 16:48:23 2018 -0700 Avoid syncing muted state with owner web_contents fix https://github.com/brave/browser-laptop/issues/13979 fix https://github.com/brave/browser-laptop/issues/13996 Auditor: @bridiver commit a733a0e868d25a533f7c3b50030e907fd7ded357 Author: bridiver <github@brianjohnson.cc> Date: Sun May 6 16:45:39 2018 -0700 revert deletion of https://github.com/brave/muon/commit/ebac9c9f7b64e50547afa3314ae9ff78ee741d2e and https://github.com/brave/muon/commit/554772bfab1aceb7e719a9e5d74cd22ce2e2b528 auditors @darkdh commit 1ac2b63bc26571484efe2bed0af6060f6b1a3640 Author: bridiver <github@brianjohnson.cc> Date: Sat May 5 03:25:22 2018 -0700 keep track of render view switches fix https://github.com/brave/browser-laptop/issues/13810 commit 7439cdef1a8e15965e113d29aced4141153644c7 Author: bridiver <github@brianjohnson.cc> Date: Thu May 3 21:43:42 2018 -0700 fix race condition for primary surface id probable fix for https://github.com/brave/browser-laptop/issues/13982 auditors @petemiller commit 4faa983fdd768e2123ab62c325e10ed2863d2605 Author: bridiver <github@brianjohnson.cc> Date: Tue May 1 13:18:11 2018 -0700 Bump v6.0.7+66.0.3359.139 commit 2b20086c2d0e85f35c3a389a973feea6eb0ff3a0 Author: bridiver <github@brianjohnson.cc> Date: Tue May 1 13:18:05 2018 -0700 replace finder patch lost in c66 rebase - fixes crash on find if an `about` page is open commit 504da0ed8decd43d0db56365fac96f79ece40fb8 Author: bridiver <github@brianjohnson.cc> Date: Mon Apr 30 20:55:25 2018 -0700 check for -2 directly because tabs sometimes have no index commit 03759b927590b92486d6820c773158881079e1a4 Author: bridiver <github@brianjohnson.cc> Date: Mon Apr 30 19:41:17 2018 -0700 Bump v6.0.6+66.0.3359.139 commit 29ba6424dbab0934bef7d51c931ffc640d17f3d1 Author: bridiver <github@brianjohnson.cc> Date: Mon Apr 30 15:12:00 2018 -0700 remove log commit 872b996367368d461e55e7b54c39161cf3759dce Author: bridiver <github@brianjohnson.cc> Date: Mon Apr 30 14:25:57 2018 -0700 fix webview src attribute auditors @petemill commit c684cc0c4d66f455827db944baaf93aeb83adcdc Author: bridiver <github@brianjohnson.cc> Date: Fri Apr 27 13:42:16 2018 -0700 Bump v6.0.5+65.0.3325.181 commit c7b27d6ff6065ee199b665d84555ae0555145414 Author: bridiver <github@brianjohnson.cc> Date: Wed Apr 25 15:38:15 2018 -0700 update surfaces on attach/detach commit 4917e2dc7885f95991607b65101d7a9db30416b7 Author: bridiver <github@brianjohnson.cc> Date: Tue Apr 17 16:09:30 2018 -0700 Bump v6.0.4+65.0.3325.181 commit f8407cfc8a7af451d74ac96d70b526a1fc624ef3 Author: bridiver <github@brianjohnson.cc> Date: Tue Apr 10 22:37:30 2018 -0700 Bump v6.0.3+65.0.3325.181 commit d92211ed202f9f2e43eebce24e1b88dc00da10e0 Author: bridiver <github@brianjohnson.cc> Date: Tue Apr 10 21:02:30 2018 -0700 only call attach/detach from JS commit 1f5f368c06d896eb4b5a4baa846317fc2278077d Author: petemill <miller.pete+commit@gmail.com> Date: Tue Apr 10 22:14:20 2018 -0700 webview - make sure detach is looking at correct attached webcontents commit 69c6dfae2c3e7cc71ec6ecd225ad7672c06d395d Author: petemill <miller.pete+commit@gmail.com> Date: Tue Apr 10 16:51:25 2018 -0700 webview should not replace guest until previous guest has completley detached commit 7d9b0fa9cf500cff92da4099cc68da56a9526835 Author: bridiver <github@brianjohnson.cc> Date: Mon Apr 9 22:47:09 2018 -0700 Bump v6.0.2+65.0.3325.181 commit dab998e5ed0843dc05eb00d4b26ec3299fd85e51 Author: petemill <miller.pete+commit@gmail.com> Date: Mon Apr 9 18:56:47 2018 -0700 webview - do not attempt to detach from a non-attached contents commit c9c03428825047c24cf323f9fc8b5f47986274b3 Author: bridiver <github@brianjohnson.cc> Date: Fri Apr 6 19:02:43 2018 -0700 don't resume/block on detach/load commit 20fe01d92ebaa5dc4451bfaf74ed9a1fcc539331 Author: bridiver <github@brianjohnson.cc> Date: Fri Apr 6 15:12:33 2018 -0700 fix clone commit 6c640cd2dc9f5e9f3ceb6717b75a36404e09725a Author: petemill <miller.pete+commit@gmail.com> Date: Thu Apr 5 20:15:01 2018 -0700 Revert "Window WebContents get TabHelper to preserve ExecuteScriptInTab woring for windows" This reverts commit 28bb99c8caa8bd7dc15c1701938b86c420c96a59. commit 26ab44593f8eea6a7653177c3326295ec11afb89 Author: petemill <miller.pete+commit@gmail.com> Date: Thu Apr 5 20:15:01 2018 -0700 Window WebContents get TabHelper to preserve ExecuteScriptInTab woring for windows Even though ExecuteScriptInTab probably shouldn't work on a Window's WebContent, this is existing functionality that dependent projects may use. Can consider refactoring those implementations if this causes any side effects. Auditors: @bridiver commit 3c6fb8a66badad98cfbb801383115d0f1cb84d14 Author: petemill <miller.pete+commit@gmail.com> Date: Wed Apr 4 10:39:01 2018 -0700 Use webContents.id for unique ID across different kinds of WebContents Fixes bad references in the remote registry since .getId() on non-tab contents, such as window's WebContents, will always be -1. Also adds optional logging for debugging ObjectsRegistry actions. commit 38765bbd8e051467a11c0c9ec49913374012fe31 Author: bridiver <github@brianjohnson.cc> Date: Wed Apr 4 12:53:50 2018 -0700 Bump v6.0.1+65.0.3325.181 commit 90ffde3d6dd5b9d444cbce76ef1ff5c17b527c7e Author: bridiver <github@brianjohnson.cc> Date: Tue Apr 3 20:57:04 2018 -0700 clone wip commit b872697b3c2e5e36ee2a7b433d9b1a8b71f33c13 Author: bridiver <github@brianjohnson.cc> Date: Tue Apr 3 20:43:38 2018 -0700 keep `active_` in sync commit 4b13bfdbc6a4ad5ffc6d787056830acc9f1bc335 Author: bridiver <github@brianjohnson.cc> Date: Mon Apr 2 20:53:55 2018 -0700 main window webcontents should get ZoomController and RendererPreferencesHelper fix https://github.com/brave/browser-laptop/issues/13681 commit d6353e67bf469b26247cfe07d724234bb8a0e719 Author: bridiver <github@brianjohnson.cc> Date: Fri Mar 30 18:38:45 2018 -0700 Bump v6.0.0+65.0.3325.181 commit ca7c06fd9b010e2b86ba565a10c8efaa5b4ce1ae Author: bridiver <github@brianjohnson.cc> Date: Fri Mar 30 18:32:53 2018 -0700 always return a value for `isDestroyed` commit f959001f8645a22058cb3872e1b608cce9319891 Author: petemill <miller.pete+commit@gmail.com> Date: Fri Mar 30 17:28:41 2018 -0700 forward tab-inserted-at to renderer commit 4260d31851d391009e7447a7760495e26052f999 Author: petemill <miller.pete+commit@gmail.com> Date: Fri Mar 30 17:28:05 2018 -0700 forward tab-moved event to renderer commit ae74375cf508960f6bcc00f8818834808c76b180 Author: petemill <miller.pete+commit@gmail.com> Date: Fri Mar 30 17:27:07 2018 -0700 handle unknown WebContents events forwarding to renderer commit 480369c024170b8e37b4a662bb5f6db1746f9cdd Author: petemill <miller.pete+commit@gmail.com> Date: Fri Mar 30 17:26:02 2018 -0700 fix: embedder tab event duplication on insert to new tab strip commit 1b6d0136f429b37d8c548ade1cec2a9d4b9a9f01 Author: petemill <miller.pete+commit@gmail.com> Date: Fri Mar 30 16:41:53 2018 -0700 webview detachGuest internal reference fix commit 4a57c2240472461d8791c5aedb419cf77cf8135b Author: bridiver <github@brianjohnson.cc> Date: Wed Mar 28 17:51:55 2018 -0700 TabDetachedAt is already handled correctly in TabHelper and this fires the event sometimes when it shouldn't commit 5e452aa1a66a0161195d34b3fd370e095a71f261 Author: petemill <miller.pete+commit@gmail.com> Date: Wed Mar 28 15:22:27 2018 -0700 only register guests from window contents on tab insert commit 91b69699c8e1f9b6c14ab120ba5c95ec26412fd1 Author: bridiver <github@brianjohnson.cc> Date: Wed Mar 28 12:31:37 2018 -0700 emit tab-inserted-at and tab-detached-at on tab and window webcontents commit bfb37894a2496e4d7bf16c26bdd0539ed23a0115 Author: bridiver <github@brianjohnson.cc> Date: Wed Mar 28 12:24:44 2018 -0700 emit `tab-replaced-at` on old webcontents commit 9520ff3c128f3656e1c98d4580202987a64440a4 Author: bridiver <github@brianjohnson.cc> Date: Tue Mar 27 19:51:37 2018 -0700 add MoveTo commit 425daab00e846d0aecb6e3fe5c6220358daf7737 Author: bridiver <github@brianjohnson.cc> Date: Tue Mar 27 16:08:40 2018 -0700 add window_id to tab-detached-at only the embedder should be a tab strip observer commit 176c6ad3a120d61dfdbfa980a4cbc3d4211e6ae5 Author: petemill <miller.pete+commit@gmail.com> Date: Tue Mar 27 15:09:07 2018 -0700 forward tab-detached-at to renderer commit a65d47bbb85796c866b8a869540128617e374549 Author: petemill <miller.pete+commit@gmail.com> Date: Mon Mar 26 01:42:38 2018 -0700 remote.registerAllWindowTabEvents commit 2978ed22df66955d19deaa45ebe6f8dd90636173 Author: petemill <miller.pete+commit@gmail.com> Date: Fri Mar 23 22:14:36 2018 -0700 harden webview detach / attach against destroy timing commit 9298f7ef1d19ce1bfbba6161034102a29a28c68a Author: bridiver <github@brianjohnson.cc> Date: Fri Mar 23 21:34:30 2018 -0700 don't discard discareded tabs commit 5f929ad34340933e9427f596f77e286878c85f9a Author: bridiver <github@brianjohnson.cc> Date: Fri Mar 23 14:15:20 2018 -0700 only detach/attach if the replaced contents is attached commit a39f8405acebf3cb2653393f88242bbb35fd3456 Author: petemill <miller.pete+commit@gmail.com> Date: Fri Mar 23 13:05:07 2018 -0700 stop forwarding tab events to detached webview commit d4a33e7e7570a512d4a20ece6b0247af5a1b16bd Author: petemill <miller.pete+commit@gmail.com> Date: Fri Mar 23 12:10:08 2018 -0700 Ensure guest embedder gets events for replaced contents commit f3b5fb9b22fc1ccf608d2a963ce4d8df40262613 Author: bridiver <github@brianjohnson.cc> Date: Fri Mar 23 08:45:06 2018 -0700 use owner instead of embedder because only the active tab has an embedder commit 8d2989867c2701a356dd6817763ed2f33a90b128 Author: bridiver <github@brianjohnson.cc> Date: Thu Mar 22 19:11:59 2018 -0700 fix insertion order commit 773f2a9890d67192a1311ee86bdb8ccd26f7d11a Author: bridiver <github@brianjohnson.cc> Date: Thu Mar 22 18:38:13 2018 -0700 remove unnecessary change commit d875dfe768856e090eb80ca2580b149e93dd802b Author: bridiver <github@brianjohnson.cc> Date: Thu Mar 22 18:03:28 2018 -0700 allow localhost urls in webui for dev commit fb9eb68438b01838550d3c453ba9d66ff21efe1d Author: bridiver <github@brianjohnson.cc> Date: Thu Mar 22 18:03:17 2018 -0700 fix discarded tabs probably commit 6d86bcaa3fee15bb706e25415352f5aec3196de0 Author: bridiver <github@brianjohnson.cc> Date: Wed Mar 21 22:06:37 2018 -0700 don't check for HasWindow here because the browser has not been set yet - maybe we should call this when the browser has been set? commit 24d079344347a4e1f78b8f5b850220d215739bf0 Author: petemill <miller.pete+commit@gmail.com> Date: Wed Mar 21 16:38:55 2018 -0700 <webview>.detachGuest prevent multiple calls for same guest Also offer promise result commit 0e0cfda430eb91ecf84c4c131a3cec09cba5bec9 Author: Pete Miller <miller.pete@gmail.com> Date: Fri Mar 9 00:08:24 2018 -0800 restore <webview> content events for backwards compat commit beafceaf20b0e42e13309a645352ad1442e92837 Author: Pete Miller <miller.pete@gmail.com> Date: Fri Mar 9 00:02:09 2018 -0800 <webview> should not try to detach a guest of a destroyed contents commit c649c916f1ab127f100ee5f48be7c2c093210f6d Author: Pete Miller <miller.pete@gmail.com> Date: Wed Mar 7 17:26:56 2018 -0800 keep sending guest events to embedder after detach from webview whilst still in window tab strip commit 3f5db317a79fc74cb14320b7036adc7efd2e56f8 Author: bridiver <github@brianjohnson.cc> Date: Wed Mar 7 15:49:55 2018 -0800 tab-inserted-at tab-detached-at commit 0634ead6aa1454fc4bdb53088fb2d75f3d234cac Author: bridiver <github@brianjohnson.cc> Date: Tue Mar 6 15:34:07 2018 -0800 don't replace commit 150d859505db2274f7f0065a620fb06da31fe578 Author: bridiver <github@brianjohnson.cc> Date: Tue Mar 6 14:16:18 2018 -0800 replaceGuestContents commit e2666ef0a5a1604cf39795c63e6aec89783020d4 Author: Pete Miller <miller.pete@gmail.com> Date: Mon Feb 26 20:09:30 2018 -0800 <webview> gets getGuestId and getId functions commit 16a665017bcae983fbbea6a91a4b05b60afe86d7 Author: bridiver <github@brianjohnson.cc> Date: Fri Feb 23 21:30:01 2018 -0700 oops commit 3e76b0ed9c504894c5072dc09c89a28c75a976d2 Author: bridiver <github@brianjohnson.cc> Date: Fri Feb 23 20:59:05 2018 -0700 load test commit 3707fea6733cc030f107e13494b3e12d738895dc Author: bridiver <github@brianjohnson.cc> Date: Fri Feb 23 19:54:57 2018 -0700 forward `tab-replaced-at` to the renderer commit 1e80580e967eee17aa34436bc88ac14113a72b4a Author: bridiver <github@brianjohnson.cc> Date: Fri Feb 23 16:26:47 2018 -0700 has window commit 8af66ae9d43c22e58afd9572d9426009ed7d6c8c Author: bridiver <github@brianjohnson.cc> Date: Tue Feb 13 17:47:54 2018 -0700 fixes commit a662031475348b4cb1b24f642a5e03f2fc8b5371 Author: bridiver <github@brianjohnson.cc> Date: Tue Feb 13 16:59:27 2018 -0700 add support for global tab event handler commit 8d3b1af8efe0678c8adaa9f2584b0edd01955b70 Author: bridiver <github@brianjohnson.cc> Date: Tue Feb 13 16:58:48 2018 -0700 pt 2 commit 1fb518a9296c0b444b606d30871fb84a6dc37745 Author: bridiver <github@brianjohnson.cc> Date: Tue Feb 13 16:58:08 2018 -0700 add support for TabReplacedAt commit 20e425b704a48da464fc83bfe52676d139e26272 Author: bridiver <github@brianjohnson.cc> Date: Sun Feb 11 18:59:22 2018 -0700 wip commit d462800b4dacc4d013f6be83c491a855332357fa Author: bridiver <github@brianjohnson.cc> Date: Fri Feb 9 20:45:49 2018 -0700 insert into tab strip before attach commit f5a913c7569aada55daa42a182f59a97c3f5230e Author: Brian Clifton <brian@clifton.me> Date: Wed Apr 25 22:20:40 2018 -0700 Bump v5.2.7+66.0.3359.117 commit 1acc7d63bf6c32f6b60ddad53282a8b271261ff2 Author: Brian Clifton <brian@clifton.me> Date: Wed Apr 25 22:19:50 2018 -0700 Merge pull request #579 from brave/cc_upload Disable credit card upload by default commit 617ff5a59d7e707c238939bc731da10964843a5b Author: bridiver <github@brianjohnson.cc> Date: Sat Apr 21 16:55:55 2018 -0700 add PasswordWebDataService commit ce7680b063ea6ca2c4d40c389a02769eda4b3e5e Author: bridiver <github@brianjohnson.cc> Date: Sat Apr 21 08:04:28 2018 -0700 Bump v5.2.6+66.0.3359.117 commit 552def024b8640b2833fc1b00069f60f5933b0a5 Author: bridiver <github@brianjohnson.cc> Date: Fri Apr 20 16:00:42 2018 -0700 use WebDataServiceWrapper auditors @darkdh @hferreiro commit df6fa799bc69bdf63634ed5c8868856d4d34a4e6 Author: bridiver <github@brianjohnson.cc> Date: Fri Apr 20 15:41:26 2018 -0700 use new `CreateLoginDelegate` method auditors @darkdh @ltilve commit c40ce82f8f5ecb82675c94af2a1351286bcc7619 Author: Anthony Tseng <darkdh@gmail.com> Date: Thu Apr 19 18:40:51 2018 -0700 Fix GetDevToolsURL https://chromium.googlesource.com/chromium/src/+/c8a484b5f69327d05a95c0298b1ef2a18f192532 https://chromium.googlesource.com/chromium/src/+/0648bcb737057e3fbf3d23791fb3e7758caa83f1 fix https://github.com/brave/browser-laptop/issues/13870 Auditor: @bridiver commit 85885f2c63b370f89d2c85c096b976b2115db353 Author: bridiver <github@brianjohnson.cc> Date: Wed Apr 18 21:17:10 2018 -0700 Bump v5.2.5+66.0.3359.117 commit 1115ad72df67bda9506dbdaadee56e818c268180 Author: Brian Johnson <github@brianjohnson.cc> Date: Wed Apr 18 21:02:57 2018 -0700 Merge pull request #575 from brave/deps-b-l-2184 Update external binaries to 1.3.0 for latest Squirrel.Mac commit 808e32a0268e17ba59e02e4de9eeb304c0876f2b Author: Anthony Tseng <darkdh@gmail.com> Date: Wed Apr 18 16:01:56 2018 -0700 Disable unified autoplay policy https://chromium.googlesource.com/chromium/src/+/12c615ca3716162f32341c597d581b3a6d6b7f95 Auditor: @bridiver commit 7a843b0b2f582d9014f17c48c508d93bff7ea76e Author: bridiver <github@brianjohnson.cc> Date: Tue Apr 17 17:57:41 2018 -0700 Bump v5.2.4+66.0.3359.117 commit be33729cf6e51515c4f83023c1cb37ee6374c8da Author: Anthony Tseng <darkdh@gmail.com> Date: Tue Apr 17 16:29:29 2018 -0700 Follow up of 9b3fa42a7d8ddf2833cad4e6644f5932273e305f and 49fb698039a53bbc98d43f53a4e4b44c136d7cfc commit 8fdda7d9421946fb77d456da3564f66054b6cbb3 Author: bridiver <github@brianjohnson.cc> Date: Tue Apr 17 09:04:48 2018 -0700 Bump v5.2.3+66.0.3359.81 commit 8dfaa2c2cf11ffee73b371dd54e8c50697b4d051 Author: bridiver <github@brianjohnson.cc> Date: Mon Apr 16 21:18:37 2018 -0700 don't set the web_layer_ to null on detach commit 49fb698039a53bbc98d43f53a4e4b44c136d7cfc Author: Anthony Tseng <darkdh@gmail.com> Date: Mon Apr 16 16:12:00 2018 -0700 Fixup metrics_service_accessor.cc patch commit 9b3fa42a7d8ddf2833cad4e6644f5932273e305f Author: Anthony Tseng <darkdh@gmail.com> Date: Mon Apr 16 15:37:44 2018 -0700 Fix MetricsServiceAccessor::IsMetricsReportingEnabled https://chromium.googlesource.com/chromium/src/+/0176f9a3186594f2906d67418d43a786a2ccd366 fix https://github.com/brave/browser-laptop/issues/13842 Auditors: @bridiver, @hferreiro, @ltilve commit d4effccfda02d2e35cd1a3d6d68a59a9e14d9a1f Author: Anthony Tseng <darkdh@gmail.com> Date: Mon Apr 16 10:46:15 2018 -0700 Servicify unzipping and use it in the component updater. https://chromium.googlesource.com/chromium/src/+/6d76442a2acad95257d7beb62be7691f73f014c0 fix https://github.com/brave/browser-laptop/issues/13840 fix https://github.com/brave/browser-laptop/issues/13838 fix https://github.com/brave/browser-laptop/issues/13837 Auditors: @bridiver, @hferreiro, @ltilve commit 7ce5e916f2e8b3a06ca5d38e07901450e358518c Author: bridiver <github@brianjohnson.cc> Date: Fri Apr 13 18:44:53 2018 -0700 Bump v5.2.2+66.0.3359.81 commit 0a64fe98199c029b0e417d23163c17a2fba6aed1 Author: bridiver <github@brianjohnson.cc> Date: Thu Apr 12 18:40:34 2018 -0700 Revert "Pass correct status of network to error handler's constructor" This reverts commit 040cc785ddeac1ce018563e625f65e50b742aa28. commit bd7d4ae2c246ce26b77db5ff51385291dc94c58b Author: Brian Clifton <brian@clifton.me> Date: Thu Apr 12 14:10:32 2018 -0700 Merge pull request #570 from bsclifton/revert-quarantine Revert "Merge pull request #484 from brave/quarantine_downloads" commit db7f914503cf4ce0170501b3d659452501cf8396 Author: bridiver <github@brianjohnson.cc> Date: Thu Apr 12 09:32:54 2018 -0700 Bump v5.2.1+66.0.3359.81 commit 7fdcb483522fbff503538ba5c6d6d623861b301e Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Thu Apr 12 13:14:12 2018 +0200 Implement BraveConfigurator::CreateServiceManagerConnector() https://crrev.com/29f9b94b7d8d This was missing from a previous rebase in which it wasn't needed. It fixes #567 and fixes #568. commit d1df1be286ad93e34a79b12738b3f6e838f76474 Author: Lorenzo Tilve <ltilve@igalia.com> Date: Thu Apr 12 13:06:01 2018 +0200 fixup! Remove unused elements from CopyFromSurface() API commit 70b5f858d69560c056ba6688fced19e9a1c62e74 Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Thu Apr 12 11:28:08 2018 +0200 fixup! Updates to ExtensionTabUtil commit 7db41e336f638422077b03e210abea83776b1cbe Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Thu Apr 12 11:23:46 2018 +0200 fixup! Remove SequencedWorkerPool commit 86d474306ffeca2787e04af1a78789e79e80e7a9 Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Thu Apr 12 11:13:33 2018 +0200 fixup! REVIEW: InspectElement() receives a RenderFrameHost commit d526fa07fc80883623e2e15f5a57fc8f3fe4076c Author: Anthony Tseng <darkdh@gmail.com> Date: Wed Apr 11 20:39:30 2018 -0700 chrome: Unship snapshot_blob.bin from Win/Mac/Linux https://chromium.googlesource.com/chromium/src/+/b550792f0f9357f380d501288f368e85d43279b8 fix https://github.com/brave/muon/issues/548 Auditors: @bridiver, @hferreiro, @ltilve commit e0532fe1d1eee960ef358d5e914635388d78e373 Author: Anthony Tseng <darkdh@gmail.com> Date: Wed Apr 11 19:38:33 2018 -0700 fixup chrome_service.cc patch commit 237242113a697ab7647aa6a262b7ec887c37a2de Author: Anthony Tseng <darkdh@gmail.com> Date: Wed Apr 11 19:08:04 2018 -0700 Fix spellchecker fix https://github.com/brave/muon/issues/566 Auditors: @bridiver, @ltilve, @hferreiro commit 662b6bef1a75883c82929379581f4f00d7cef97b Author: bridiver <github@brianjohnson.cc> Date: Wed Apr 11 14:59:09 2018 -0700 bump chromedriver version cc @bsclifton commit a1a111f683706c43adee5c46a8f5fb491a87d9a0 Author: bridiver <github@brianjohnson.cc> Date: Wed Apr 11 10:02:59 2018 -0700 Bump v5.2.0+66.0.3359.81 commit 8eef379943eb594052aa4c7ca0c4f111fb70752c Author: Lorenzo Tilve <ltilve@igalia.com> Date: Wed Apr 4 23:33:05 2018 +0200 Fix on avoid saving passwords when the user is signing in to Chrome https://crrev.com/80e1c6bf5b21 commit ae174b03afe91635b9c410cbd468f3a2b87e37fc Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Mon Mar 26 13:36:09 2018 +0200 DROP Disable chrome service Workarounds https://github.com/brave/muon/issues/547 so that we can do some testing. commit d02c605447c6ffc3ee513585506d311bbc4d47b5 Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Fri Mar 23 13:06:21 2018 +0100 Lint fixes commit 2aebd6c71ad000f3b97842312549c664d05f8081 Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Thu Mar 22 14:02:16 2018 +0100 Create ::Browser after window is initialized In the below upstream CL, a new constraint is added: the Browser object needs to be added to BrowserList after the window is initialized. This commits moves Browser creation after NativeWindow initialization. http://crrev.com/3ca12c8595fb commit 09b1e33aa38cbe37e2f189f9ee4f2a0ff08db3ad Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Thu Mar 22 14:02:02 2018 +0100 REVIEW: Fix linking error on Windows about attestation permissions Should we need to add webauthn prompt? https://crrev.com/85339f65 commit 32f0d10e2abb5cbe76e6779572a7053bed1c19c7 Author: Lorenzo Tilve <ltilve@igalia.com> Date: Tue Mar 20 17:53:26 2018 +0100 Fix Linux linking issues due to missing kLibsecretAndGnomeAppString https://crrev.com/c64adae0b7de commit cc34494283e109bb7a8c06cd32884ec890692938 Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Thu Mar 22 14:01:39 2018 +0100 Fix undefined symbol link error commit d8ebcc030723aa84f44e23e34674d7106b822f1d Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Thu Mar 22 14:01:10 2018 +0100 Fix ShowFolderUploadConfirmationDialog link error Copy browser_dialog.cc to chromium_src to get ShowFolderUploadConfirmationDialog() referenced from FileSelectHelper::LaunchConfirmationDialog. http://crrev.com/2a02a69e3173 commit 987cb6e3233828e311b42ba69844382a3d02a991 Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Thu Mar 22 14:00:43 2018 +0100 Stub UIThreadSearchTermsData::EstimateMemoryUsage() http://crrev.com/361a59325a97 commit d35741a9b95e31994b73380a62d134a02a8bc563 Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Thu Mar 22 14:00:01 2018 +0100 Updates to IOThread http://crrev.com/4556c6b0431a http://crrev.com/d9ec7077b9e1 commit 22a1123732bc3d4be834cfb16f0dbb038a9bc9ef Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Thu Mar 22 13:59:50 2018 +0100 Fix PrintPreviewMessageHandler http://crrev.com/c9a194557fcc commit bc8979e941eef1ca6052200acfca13d281b6d0c1 Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Thu Mar 22 13:59:19 2018 +0100 Fix stub UpgradeDetectorImpl https://crrev.com/875403e09166 https://crrev.com/ded72aba15ca commit b508517129d62c01049396d14797b10fae878c1a Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Mon Mar 19 13:20:49 2018 +0100 Convert PersonalDataManager to use IdentityManager https://crrev.com/fbb98d83616e commit 96ff0c455e139bd71dedc77764b0ebe965da9e4a Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Mon Mar 19 13:01:11 2018 +0100 TODO: ResourceDispatcherHost::ClearLoginDelegateForRequest() was removed https://crrev.com/bc561f417634 commit 6a9aff3bdaa5e7042363b4bd4d35deae6f682e3b Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Thu Mar 22 13:59:02 2018 +0100 Used std::unique_ptr instead of raw pointers to transfer ownership. http://crrev.com/9d35fc570a8f commit 040cc785ddeac1ce018563e625f65e50b742aa28 Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Fri Mar 16 21:19:37 2018 +0100 Pass correct status of network to error handler's constructor https://crrev.com/b31c30d73957 commit 44139b67349ef5858e5c45a02a82bc87f3475ed3 Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Fri Mar 16 12:23:45 2018 +0100 Remove UtilityMessageHandler https://crrev.com/21b7a819b054 commit 883f7f94987f4d46bc31bbae04d3fe7fffb138d5 Author: Lorenzo Tilve <ltilve@igalia.com> Date: Thu Mar 15 14:04:36 2018 +0100 Mojify spellcheck filter files to spellcheck host files https://crrev.com/384fe0f5b0c5 https://crrev.com/d9085ee1dd4b https://crrev.com/16331307f930 commit eb080bcfb684f317c1c9ef994655604325e7459a Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Thu Mar 15 14:07:35 2018 +0100 DROP: temporary fix for an upstream build error in Chromium commit f1dc7edfabadf2e63f88d923029a47af96271e63 Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Thu Mar 15 13:46:29 2018 +0100 Remove suborigin implementation https://crrev.com/5641d755098b commit 29977e86e7d8ca0170adea817c49845cd319037c Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Thu Mar 15 13:41:54 2018 +0100 Remove v8_helpers::SetProperty() https://crrev.com/b17e66da13e1 commit fe3f33260d79b433da19dce2f37ecdcba644ec57 Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Thu Mar 15 13:25:52 2018 +0100 Load resources from extension bundles in the network service https://crrev.com/8f8126680433 commit a598faaa2d336a212a277b9ba277ac5332e888e0 Author: Lorenzo Tilve <ltilve@igalia.com> Date: Thu Mar 15 10:44:01 2018 +0100 Rename IsStorageSessionOnlyOrBlocked() https://crrev.com/cb95a65980b2 commit 66a2d0945f67c1fdfa80d96e7b3af55285918c85 Author: Lorenzo Tilve <ltilve@igalia.com> Date: Thu Mar 15 10:38:41 2018 +0100 Remove unused elements from CopyFromSurface() API https://crrev.com/6a4443f04150 commit 2f58a63e0bb1d4ff7423d1f5fcb4048e6c55a4fb Author: Lorenzo Tilve <ltilve@igalia.com> Date: Thu Mar 15 10:10:58 2018 +0100 Remove InvalidationService::GetIdentityProvider() https://crrev.com/a012b4cba417 commit 501aaa7723100b1575a340c9d8797191e6856d6a Author: Lorenzo Tilve <ltilve@igalia.com> Date: Thu Mar 15 09:58:09 2018 +0100 Reland of NetworkService: Implement URLLoader::OnAuthRequired https://crrev.com/bc561f417634 commit 4833e1869d94e28dc00841b2e868666c60356c9f Author: Lorenzo Tilve <ltilve@igalia.com> Date: Wed Mar 14 22:47:38 2018 +0100 Remove unused content/public/browser/readback_types.h https://crrev.com/6a4443f04150 commit aef580e986a146730d12a7edc5c07c28a8f83fd5 Author: Lorenzo Tilve <ltilve@igalia.com> Date: Wed Mar 14 22:28:33 2018 +0100 Reporting: Check upload permissions asynchronously https://crrev.com/7b07ea496fa6 commit 788c2a3a9ff0692009c697b48ad035d5893e4a8d Author: Lorenzo Tilve <ltilve@igalia.com> Date: Wed Mar 14 16:35:30 2018 +0100 Rename media/cdm/ppapi to media/cdm/library_cdm https://crrev.com/cc32f2eded17 commit 7f993ad7f93cc882346f17f1de4af4b6c80149f4 Author: Lorenzo Tilve <ltilve@igalia.com> Date: Wed Mar 14 13:11:46 2018 +0100 Renamed buildflag_headers https://crrev.com/9ae8289311df commit 09f2360484df8122a32efbb345e8c7f35f7a0403 Author: Lorenzo Tilve <ltilve@igalia.com> Date: Mon Mar 5 22:17:24 2018 +0100 Change APIBindingsSystem to NativeExtensionBindingsSystem https://crrev.com/b15f7f04de19 commit d611ffefabb46dbb2931af07e2271f664bdfbff8 Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Mon Mar 5 14:28:48 2018 +0100 Stub AtomAutofillClient::GetIdentityManager() https://crrev.com/3520fb171ac7 commit 6245a73db8347bb77d8a9b6ed04784a13bb8272d Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Mon Mar 5 14:04:37 2018 +0100 REVIEW: InspectElement() receives a RenderFrameHost https://crrev.com/902bffab618a commit f12c6c763365a131f8a01dc80af98389af006872 Author: Lorenzo Tilve <ltilve@igalia.com> Date: Sun Mar 4 21:22:12 2018 +0100 Serveral */public/{interfaces => mojom} file moves https://crrev.com/19db638f87e6 https://crrev.com/ed7f41b809a7 commit 2ed2aa54ff4c14b13d3404302776b722d56a539c Author: Lorenzo Tilve <ltilve@igalia.com> Date: Sun Mar 4 18:56:26 2018 +0100 Move kScrubTab to ExtensionTabUtil https://crrev.com/1980f44de819 commit 96ff0ced4ae8bac4556d37f856b56dadaaf0f879 Author: Lorenzo Tilve <ltilve@igalia.com> Date: Sun Mar 4 18:46:13 2018 +0100 Give the JS dialog manager the alerting frame https://crrev.com/2fefc4bd0b63 commit 14793c41e0271b0fadbe92c70828e2c36200ffae Author: Lorenzo Tilve <ltilve@igalia.com> Date: Sun Mar 4 13:42:31 2018 +0100 Remove SequencedWorkerPool https://crrev.com/4914ec14f5ba commit bbb537e74f2c4d1a4f15b9aa0eba96cba5b3b07e Author: Lorenzo Tilve <ltilve@igalia.com> Date: Sun Mar 4 13:33:34 2018 +0100 Use scoped_refptr for the url context getter in the component updater https://crrev.com/556147da66b8 commit 311154148dcc9ca8390e1e81b1c3090ed5952561 Author: Lorenzo Tilve <ltilve@igalia.com> Date: Sun Mar 4 13:12:36 2018 +0100 Moved TOUCH_SUPPORT_* enums to TouchSupport enum classes https://crrev.com/8f12ad6e2ce3 commit 78b511d6dc4dbc3760e918bfdce57a27810ffa39 Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Fri Mar 2 10:11:19 2018 +0100 Do not override CancelPermissionRequest() The method was removed from PermissionManager. This commit makes it private. commit ae59935da8eafcb88fd9c0dd58cba0ee30874a99 Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Fri Mar 2 00:51:32 2018 +0100 Remove deprecated BrowserThread::FILE and DB https://crrev.com/9f99a202a791 https://crrev.com/7dabf71463f1 https://crrev.com/0070d4146866 https://crrev.com/c61269077f9f https://crrev.com/66bdfd838560 commit 3247af8fc85d40ad81c9aaed7bf0805de4ed14fe Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Fri Mar 2 11:31:05 2018 +0100 Use DoNothing() instead of Bind(&DoNothing) https://crrev.com/341e1fbe2da0 commit 50c0907f769435ff93f4af57277aadeeab81959e Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Thu Mar 1 13:25:32 2018 +0100 Make profile directory creation always synchronous This is also required for the BrowserThread::FILE deprecation. https://crrev.com/0b08bf2eaee2 commit acbd379fbd6cde1daf62e66743b2d0e6e96afd33 Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Thu Mar 1 10:20:23 2018 +0100 Remove obsolete ShouldHandleSystemCommands function https://crrev.com/e7b8d9f40641 commit a65f919b585ae17b14cfa02ed913ccc73debfe26 Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Thu Mar 1 01:34:50 2018 +0100 Updates to ExtensionTabUtil https://crrev.com/1980f44de819 commit 729104b861c878f9d000c9e8453da0d5ce7b7ec9 Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Thu Mar 1 01:02:55 2018 +0100 WebContentsObserver::WasShown() was moved to OnVisibilityChanged() https://crrev.com/fe4a1775a29f commit decec43bf0ca4c372f08371d09804e7f636aa250 Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Wed Feb 28 19:22:30 2018 +0100 Update parameters to WebContents::Renderer{Responsive/Unresponsive}() https://crrev.com/1572e8c3cf50 commit df1fb568ec70d46c8316481703732763562b28b8 Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Wed Feb 28 18:38:56 2018 +0100 Rename interfaces directory to mojom in Device Service https://crrev.com/31d0bb0369f9 commit db2a88bcdaba15372953fcc8e8e7c296ef36cb43 Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Mon Feb 26 21:42:51 2018 +0100 Include missing 'base/callback.h' commit af2ea63d92b407d7fb756553220dba6949a16d8b Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Mon Feb 26 21:15:42 2018 +0100 Stub AtomExtensionSystem::FinishDelayedInstallationIfReady() https://crrev.com/b4fbf923b1cd commit 0537c576b54cf34eca2c9cb1ef014daeadb0a9d4 Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Mon Feb 26 21:04:03 2018 +0100 Implement missing AtomExtensionsBrowserClient::IsAppModeForcedForApp() https://crrev.com/fc4a81a9b419 commit bb1df10e6cb7b2c6cc4b7442646de70c5a3eb89b Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Mon Feb 26 20:57:27 2018 +0100 Updates to BrowserProcessImpl https://crrev.com/3044d4f94d5e https://crrev.com/c9ae59c8f37d commit 93973e02376ab33afed2f53b9588267e9728f686 Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Thu Feb 22 14:09:17 2018 +0100 Update for debug agent removal in Node https://crrev.com/4128082eb181cd1da391c24d1481ffa1c1848da1 commit d65f39693561c6ec7cb356f6f3a2189a84aeb821 Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Thu Feb 22 14:06:25 2018 +0100 Add some V8 gyp files V8 removed all of its gypfiles https://crrrev.com/2c8663aa1a2d7e411bb2759dfe31d289990db135 commit 90caadd2a7f3b10ee2ceaf3ade94a8154e9959a2 Author: Lorenzo Tilve <ltilve@igalia.com> Date: Thu Feb 22 12:40:00 2018 +0100 Modernize TabContentsIterator https://crrev.com/2f97ce593ed5 commit 9e9aae98b1036dc418cd70f4c4d5a05a665b2a5e Author: Lorenzo Tilve <ltilve@igalia.com> Date: Thu Feb 22 12:36:31 2018 +0100 TODO: Check cssOrigin param https://crrev.com/9494d72752c2 commit 0ce4a5fc8b624eb89c44c2d4a7b60bb058b7b6fe Author: Lorenzo Tilve <ltilve@igalia.com> Date: Thu Feb 22 11:51:11 2018 +0100 REVIEW: Update chrome service and expose a chrome_renderer service https://crrev.com/16331307f930 https://crrev.com/02a5bf7ceac0 commit e01a137651dd7b64a251abf24f010a9603590ff0 Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Mon Feb 26 20:49:03 2018 +0100 Move CreateClientCertStore() to BraveContentBrowserClient https://crrev.com/9409ded1ffb6 commit 4e4b0e366d9200597da333a902e014537d1d8683 Author: Lorenzo Tilve <ltilve@igalia.com> Date: Thu Feb 22 11:16:29 2018 +0100 Moved services/proxy_resolver/public/{interfaces => mojom} https://crrev.com/26cf47486c0e commit 5d9aca6e3e4294bd9c4c00b63c91d8b4a9493ae9 Author: Lorenzo Tilve <ltilve@igalia.com> Date: Wed Feb 21 17:21:36 2018 +0100 Moved VECTOR_ICON_TEMPLATE definitions https://crrev.com/a5676deb1e67 commit 7a967ad29ade15147a1b3cf138ee35f3a0e32a9b Author: Lorenzo Tilve <ltilve@igalia.com> Date: Wed Feb 21 16:08:30 2018 +0100 Changed wm::ShadowElevation constants https://crrev.com/280f4ffbd9bf commit b9c11f5c999adbc6fad1d79532b13fde4ecda441 Author: Lorenzo Tilve <ltilve@igalia.com> Date: Wed Feb 21 14:42:54 2018 +0100 Removed UtilityMessageHandler https://crrev.com/21b7a819b054 commit 2036549c948480d9446bed5281047700ab6c8b07 Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Tue Feb 27 11:52:17 2018 +0100 Factor RouteFunction() calls into a separate method https://crrev.com/d9ea83498e82 commit 8ec4a3bc407dd9d20fa0205a8ff1889d83691e64 Author: Lorenzo Tilve <ltilve@igalia.com> Date: Tue Feb 20 13:02:58 2018 +0100 Remove ResourceUsageReporter https://crrev.com/f180ce175b43 commit 083f14364194d93ecde632090f6c36c196cc730b Author: Lorenzo Tilve <ltilve@igalia.com> Date: Tue Feb 20 12:04:53 2018 +0100 Add a weakly-bound RequestQuit closure to ServiceContext https://crrev.com/9b6adaeec348 commit b8827861f39da61d8b13d6e220f409008dc99ddc Author: Lorenzo Tilve <ltilve@igalia.com> Date: Mon Feb 19 21:43:54 2018 +0100 Import moved network_switches.h https://crrev.com/91243b3fec15 commit dfc0659b9904b54f75eea9134826aebfa715f445 Author: Lorenzo Tilve <ltilve@igalia.com> Date: Mon Feb 19 21:33:36 2018 +0100 Renamed ProxyService class to ProxyResolutionService https://crrev.com/8c2f97d546a7 commit 2f57bc7aceef5935cdaf769da71d656633735108 Author: Lorenzo Tilve <ltilve@igalia.com> Date: Mon Feb 19 21:23:51 2018 +0100 Renamed proxy auto config files https://crrev.com/9844d32d14c7 commit cca07210c5cace8a094d95492d066ef96544f78b Author: Lorenzo Tilve <ltilve@igalia.com> Date: Mon Feb 19 20:55:27 2018 +0100 Converted ui::AXEvent to ax::mojom::Event https://crrev.com/dcef1b73d879 commit 94b4b460fef91f49b5ad9beee35eac9b2399169b Author: Lorenzo Tilve <ltilve@igalia.com> Date: Mon Feb 19 20:44:45 2018 +0100 Unified DevTools logic for serving front-end bundles https://crrev.com/c8a484b5f693 commit 523c0a14ac9c8492612e67dbe189b41a3b490e15 Author: Lorenzo Tilve <ltilve@igalia.com> Date: Mon Feb 19 20:31:03 2018 +0100 Extracted kLogNetLog flag to network_switches.h https://crrev.com/a255e00eccc9 commit ef465ee714ead7662989deb94a749256dbcb5176 Author: Lorenzo Tilve <ltilve@igalia.com> Date: Mon Feb 19 20:10:30 2018 +0100 Moved switches::kLogNetLog to network https://crrev.com/91243b3fec15 commit 64f3dc703600d6d4695a8637cf674e9c32ee85af Author: Lorenzo Tilve <ltilve@igalia.com> Date: Mon Feb 19 16:50:54 2018 +0100 Move content/network to services/network https://crrev.com/3bbbdf9432a8 commit a65c794a0c4d8d8f59c8bf4279e908a3f0ba9368 Author: Lorenzo Tilve <ltilve@igalia.com> Date: Mon Feb 19 16:15:20 2018 +0100 Move download related files from content/ to components/download/ https://crbug.com/803135 https://crrev.com/0ca8e1eef71c https://crrev.com/a9f487874963 https://crrev.com/eb78b7a549e4 https://crrev.com/a904f3303bf7 commit 50b0fb4485957ecae2e544990720c96f96b9faaf Author: Lorenzo Tilve <ltilve@igalia.com> Date: Mon Feb 19 15:39:30 2018 +0100 Moved net/proxy to net/proxy_resolution https://crrev.com/582d462e78c5 commit 6493bac080062af5b3946cbbbeb1b1b00d6cf734 Author: Lorenzo Tilve <ltilve@igalia.com> Date: Mon Feb 19 14:26:36 2018 +0100 Moved components/download/public to components/download/public/background_service https://crrev.com/48bf2b931acb commit dd2ca23a27ce942e007fa0db2e4e629bc191cd9b Author: Lorenzo Tilve <ltilve@igalia.com> Date: Mon Feb 19 14:22:41 2018 +0100 Moved device/usb/public/interfaces to device/usb/public/mojom https://crrev.com/fa93b142ca74 commit 4656c2631f11189595a5a2c15fecfc9cd74f3524 Author: Lorenzo Tilve <ltilve@igalia.com> Date: Mon Feb 19 14:18:49 2018 +0100 Renamed media/cdm/ppapi to media/cdm/library_cdm https://crrev.com/cc32f2eded17 commit 978ef1ff908427b4efd83bfe3ebfce05e9a4a581 Author: Lorenzo Tilve <ltilve@igalia.com> Date: Sun Feb 18 21:40:30 2018 +0100 Update patches to Chromium 66.0.3359.81 commit fec8bd38380918d11f6bde6d261734cb9232d38d Author: Brian Johnson <github@brianjohnson.cc> Date: Tue Mar 27 13:21:25 2018 -0700 Merge pull request #551 from brave/win-create-dist fix windows create_dist commit 6b284144bd643f437d14ea565724534c049fd381 Author: Brian Clifton <brian@clifton.me> Date: Mon Mar 26 16:45:31 2018 -0700 Revert "Merge pull request #531 from brave/fix_526" This reverts commit 364910b6f9d689ad3432ad68c7c69f17288aac68. commit 5f4638eb76c798f90a36fecbfebf095da9fa5281 Author: Brian Clifton <brian@clifton.me> Date: Mon Mar 26 10:31:50 2018 -0700 Bump v5.1.2+65.0.3325.181 commit 364910b6f9d689ad3432ad68c7c69f17288aac68 Author: Brian Clifton <brian@clifton.me> Date: Mon Mar 26 10:29:35 2018 -0700 Merge pull request #531 from brave/fix_526 Add Pins for Amazon CAs commit 593eaac004f610d17912c914791a028e84b1480b Author: Brian Clifton <brian@clifton.me> Date: Mon Mar 26 10:27:56 2018 -0700 Merge pull request #540 from brave/permission_host_muon Incorrect hosts were granted `OpenExternal` permissions commit 1aa98e5546ca058031405244696f07b273797b8e Author: Brian Clifton <brian@clifton.me> Date: Mon Mar 26 10:26:49 2018 -0700 Merge pull request #542 from brave/browser-laptop-issue-13521 Add filesystem `type` for dev tools commit 103f04c8ebc01dc6359df4bd5f555c046e90ce2e Author: Brian Clifton <brian@clifton.me> Date: Mon Mar 26 10:24:57 2018 -0700 Merge pull request #545 from brave/browser-laptop-issue-13580 Handle mouse up/down in async commit 60482b93fdf9386653e434ba8ea6cc8255ef9023 Author: Brian Clifton <brian@clifton.me> Date: Mon Mar 26 10:22:11 2018 -0700 Merge pull request #546 from brave/browser-laptop-13546 Fix printing service on Windows commit a7c2199dbf41bd0d62367f6a69b7023e7ac6657b Author: Brian Johnson <github@brianjohnson.cc> Date: Wed Mar 21…
This is happening for me more often then I want now. But I can scroll with keyboard controls. |
bsclifton
added a commit
to brave/muon
that referenced
this issue
Aug 21, 2018
Removing these patches from browser_plugin.cc: - bbf2817 - 416dc9c Most of the above patches have already been removed (after single webview) from browser_plugin.cc Chromium 68 has a few patches related to surface synchronization, such as this: https://chromium.googlesource.com/chromium/src/+/98d76dade64f938d939b7930e1de5460b564c2e2%5E%21/ The above Muon patches were to solve brave/browser-laptop#13982 I compiled this change in release mode + ran with 25 tabs (switching tabs with mouse/keyboard). I quit, relaunched, etc. Also turned off tab preview + used debug menu to manually discard tabs and switch back to them. Didn't notice any of the webviews get locked Not sure if this solves the problem, but this patch might not be needed anymore Auditors: @bridiver, @petemill
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
0.22.x-single-webview
Issue first seen on single-webview build against v0.22.x branch
QA/checked-Linux
QA/checked-macOS
QA/checked-Win64
QA/test-plan-specified
release-notes/exclude
Test plan
Description
Sometimes a switched-to Tab does not scroll via mouse wheel or via keyboard (arrows or page-up, etc). In this state, whilst links on the page do get the correct hover state, and text is selectable, the mouse cursor does not get pointer over links.
The only step to rectify is to re-attach (either by switching away and back again) or via
display: none
on webview.Steps to Reproduce
Not consistent...
Brave Version
about:brave info:
0.22.700
Reproducible on current live release:
No
The text was updated successfully, but these errors were encountered: