Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

'Include site in Brave Payments' not available for bookmarks without http/https #13997

Closed
LaurenWags opened this issue May 2, 2018 · 3 comments

Comments

@LaurenWags
Copy link
Member

Description

If a bookmark doesn't have http or https in the URL (Location), then the option to 'Include Site in Brave Payments' does not appear on the context menu

Steps to Reproduce

  1. Clean install 0.22.701
  2. Enable payments, visit a couple of sites so you have some data in your ledger table.
  3. Open about:bookmarks.
  4. Click on the star+ icon.
  5. Enter title and location (be sure to include http or https as appropriate) and save.
  6. Right click on the newly added bookmark, you will see the 'Include in Brave Payments' option.
  7. Click on the star+ icon.
  8. Enter title and location (do not include http or https this time) and save.
  9. Right click on the newly added bookmark.

Actual result:
'Include in Brave Payments' option does not display:
screen shot 2018-05-02 at 4 29 12 pm

Expected result:
Include in Brave Payments option should display as it does when you have http or https
screen shot 2018-05-02 at 4 29 24 pm

Reproduces how often:
easily

Brave Version

about:brave info:
Brave | 0.22.701
V8 | 6.6.346.26
rev | 339ffd6
Muon | 6.0.7
OS Release | 16.7.0
Update Channel | Beta
OS Architecture | x64
OS Platform | macOS
Node.js | 7.9.0
Brave Sync | v1.4.2
libchromiumcontent | 66.0.3359.139

Reproducible on current live release:
n/a

Additional Information

Found while testing #6547
Reproduced on Win by @srirambv

@LaurenWags LaurenWags added this to the 0.22.x Release 3 (Beta channel) milestone May 2, 2018
@LaurenWags LaurenWags changed the title bookmarks without http/https cannot be added to ledger table via manual right click option 'Include site in Brave Payments' not available for bookmarks without http/https May 2, 2018
@diracdeltas
Copy link
Member

discussed with @ryanml in slack and we decided to remove the context menu item when the bookmark doesn't have a protocol because the ledger info key requires a protocol. i guess the importance of this depends on how many users enter a URL without a protocol as a bookmark.

@bsclifton
Copy link
Member

Per comment from @diracdeltas, I'm going to remove the milestone from this issue. Unfortunately, there isn't a clean way to solve this without resolving the bookmark

@bsclifton bsclifton modified the milestones: 0.22.x Release 3 (Beta channel), Triage Backlog May 3, 2018
@LaurenWags
Copy link
Member Author

sounds good, thanks @diracdeltas and @bsclifton

@bsclifton bsclifton removed this from the Triage Backlog milestone Oct 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants