You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
If a bookmark doesn't have http or https in the URL (Location), then the option to 'Include Site in Brave Payments' does not appear on the context menu
Steps to Reproduce
Clean install 0.22.701
Enable payments, visit a couple of sites so you have some data in your ledger table.
Open about:bookmarks.
Click on the star+ icon.
Enter title and location (be sure to include http or https as appropriate) and save.
Right click on the newly added bookmark, you will see the 'Include in Brave Payments' option.
Click on the star+ icon.
Enter title and location (do not include http or https this time) and save.
Right click on the newly added bookmark.
Actual result:
'Include in Brave Payments' option does not display:
Expected result:
Include in Brave Payments option should display as it does when you have http or https
LaurenWags
changed the title
bookmarks without http/https cannot be added to ledger table via manual right click option
'Include site in Brave Payments' not available for bookmarks without http/https
May 2, 2018
discussed with @ryanml in slack and we decided to remove the context menu item when the bookmark doesn't have a protocol because the ledger info key requires a protocol. i guess the importance of this depends on how many users enter a URL without a protocol as a bookmark.
Per comment from @diracdeltas, I'm going to remove the milestone from this issue. Unfortunately, there isn't a clean way to solve this without resolving the bookmark
Description
If a bookmark doesn't have http or https in the URL (Location), then the option to 'Include Site in Brave Payments' does not appear on the context menu
Steps to Reproduce
Actual result:
'Include in Brave Payments' option does not display:
Expected result:
Include in Brave Payments option should display as it does when you have http or https
Reproduces how often:
easily
Brave Version
about:brave info:
Brave | 0.22.701
V8 | 6.6.346.26
rev | 339ffd6
Muon | 6.0.7
OS Release | 16.7.0
Update Channel | Beta
OS Architecture | x64
OS Platform | macOS
Node.js | 7.9.0
Brave Sync | v1.4.2
libchromiumcontent | 66.0.3359.139
Reproducible on current live release:
n/a
Additional Information
Found while testing #6547
Reproduced on Win by @srirambv
The text was updated successfully, but these errors were encountered: