Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Add a new option to right-click for history and bookmarks #6547

Closed
mrose17 opened this issue Jan 5, 2017 · 7 comments
Closed

Add a new option to right-click for history and bookmarks #6547

mrose17 opened this issue Jan 5, 2017 · 7 comments
Assignees
@ryanml
Labels
feature/rewards priority/P4 Minor loss of function. Workaround usually present. QA/checked-Linux QA/checked-macOS QA/checked-Win64 release-notes/include suggestion
Milestone
0.22.x Release 3 ...

Comments

@mrose17
Copy link
Member

mrose17 commented Jan 5, 2017

when in the "Bookmark Manager" or in "Show History", when right-clicking on a URL, add a new option: "Add to Publisher list". if selected, then the URL is given to the ledger middleware for inclusion in the "synopsis"
@bsclifton bsclifton added this to the 1.0.0 milestone Jan 6, 2017
@mrose17 mrose17 modified the milestones: 1.0.1, 1.0.0 Jan 31, 2017
@mrose17 mrose17 added this to the 1.0.1 milestone Mar 7, 2017
@ghost ghost removed this from the 1.0.1 milestone Sep 26, 2017
@ghost ghost added suggestion priority/P4 Minor loss of function. Workaround usually present. labels Sep 26, 2017
@cezaraugusto cezaraugusto added this to the Triage Backlog milestone Nov 8, 2017
@bsclifton bsclifton modified the milestones: Triage Backlog, Prioritized Backlog Nov 21, 2017
@ryanml
Copy link
Contributor

ryanml commented Feb 25, 2018

@NejcZdovc could I grab this one? Thanks!

@NejcZdovc
Copy link
Contributor

@ryanml sure

@NejcZdovc NejcZdovc self-assigned this Feb 25, 2018
@NejcZdovc NejcZdovc removed their assignment Feb 25, 2018
@NejcZdovc
Copy link
Contributor

@ryanml just to check quickly. Are you working on this one?

@ryanml
Copy link
Contributor

ryanml commented Apr 12, 2018

@NejcZdovc

I have a possible approach for this one that I used to solve another issue (the base issue being able to manually include sites that don't meet the minimum criteria in to the synopsis) so tentatively, yes. Let's discuss this one next week if possible

Cc: @mrose17

@ryanml ryanml mentioned this issue Apr 18, 2018
Merged
10 tasks
@NejcZdovc NejcZdovc modified the milestones: Backlog (Prioritized), 0.22.x Release 3 (Beta channel) Apr 25, 2018
@srirambv
Copy link
Collaborator

srirambv commented May 2, 2018

Right click on some entries in about:history doesn't bring up the Include in Brave payments option. Second attempt shows up the option. Happens on random links not specific ones.

cc: @kjozwiak @LaurenWags @GeetaSarvadnya

@srirambv
Copy link
Collaborator

srirambv commented May 2, 2018 •
edited
Loading

Also nested bookmarks inside folders don't show the option. Is this expected? @ryanml

Edit: works as expected

@srirambv srirambv mentioned this issue May 2, 2018
Closed
@LaurenWags LaurenWags mentioned this issue May 2, 2018
Closed
This was referenced May 3, 2018
Closed
Closed
Closed
Closed
Closed
Closed
@btlechowski
Copy link
Contributor

btlechowski commented May 8, 2018 •
edited by LaurenWags
Loading

Verified on Ubuntu 17.10 x64

  • 0.22.703 903b8d0
  • libchromiumcontent 66.0.3359.139
  • muon: 6.0.8

Verified on Windows x64

  • 0.22.703 903b8d0
  • libchromiumcontent 66.0.3359.139
  • muon: 6.0.8

Verified with macOS 10.12.6 using

  • 0.22.703 903b8d0
  • muon 6.0.8
  • libchromiumcontent 66.0.3359.139

@kjozwiak kjozwiak mentioned this issue May 16, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ryanml ryanml

Labels
feature/rewards priority/P4 Minor loss of function. Workaround usually present. QA/checked-Linux QA/checked-macOS QA/checked-Win64 release-notes/include suggestion
Projects
None yet
Milestone
0.22.x Release 3 (Release Channel)
Development

No branches or pull requests
9 participants
@mrose17 @kjozwiak @cezaraugusto @bsclifton @ryanml @NejcZdovc @srirambv @LaurenWags @btlechowski