Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Payment button not shown in URL for included pdf pages #14025

Closed
srirambv opened this issue May 4, 2018 · 1 comment
Closed

Payment button not shown in URL for included pdf pages #14025

srirambv opened this issue May 4, 2018 · 1 comment
Assignees
@jasonrsadler
Labels
0.22.x-single-webview Issue first seen on single-webview build against v0.22.x branch bug feature/rewards initiative/bat-payments QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Milestone
0.22.x Release 3 ...

Comments

@srirambv
Copy link
Collaborator

srirambv commented May 4, 2018

Description

Payment button not shown in URL for included pdf pages

Steps to Reproduce

  1. Enable payments
  2. Visit any pdf link in a new tab and complete the min time check requirement
  3. Ensure domain is added to the ledger table
  4. Switch back to pdf, URL bar doesn't have payment button

Actual result:
image

Expected result:
Should enable the payment include/exclude button in URL for PDF's as well

Reproduces how often:
100%

Brave Version

about:brave info:

Brave 0.22.702
V8 6.6.346.26
rev e4a853d
Muon 6.0.7
OS Release 10.0.16299
Update Channel Beta
OS Architecture x64
OS Platform Microsoft Windows
Node.js 7.9.0
Brave Sync v1.4.2
libchromiumcontent 66.0.3359.139

Reproducible on current live release:
N/A

Additional Information

#12792
cc: @diracdeltas
@srirambv srirambv added bug feature/rewards release-notes/exclude initiative/bat-payments 0.22.x-single-webview Issue first seen on single-webview build against v0.22.x branch labels May 4, 2018
@srirambv srirambv added this to the 0.22.x Release 3 (Beta channel) milestone May 4, 2018
@jasonrsadler jasonrsadler mentioned this issue May 4, 2018
Merged
10 tasks
jasonrsadler pushed a commit that referenced this issue May 4, 2018
Merge pull request #14028 from jasonrsadler/fix/#14025-pdf-payment
507839d 
Implemented fix to show publisher toggle for PDFs
jasonrsadler pushed a commit that referenced this issue May 4, 2018
Merge pull request #14028 from jasonrsadler/fix/#14025-pdf-payment
0eef9e1 
Implemented fix to show publisher toggle for PDFs
jasonrsadler pushed a commit that referenced this issue May 4, 2018
Merge pull request #14028 from jasonrsadler/fix/#14025-pdf-payment
80ec523 
Implemented fix to show publisher toggle for PDFs
This was referenced May 8, 2018
Closed
Closed
Closed
@btlechowski
Copy link
Contributor

btlechowski commented May 8, 2018 •
edited by srirambv
Loading

Verified on Ubuntu 17.10 x64

  • 0.22.703 903b8d0
  • libchromiumcontent 66.0.3359.139
  • muon: 6.0.8

Verified on macOS 10.13.3 x64 using the following build:

  • 0.22.703 903b8d0
  • libchromiumcontent: 66.0.3359.139
  • muon: 6.0.8

Verified on Windows x64

  • 0.22.703 903b8d0
  • libchromiumcontent 66.0.3359.139
  • muon: 6.0.8

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jasonrsadler jasonrsadler

Labels
0.22.x-single-webview Issue first seen on single-webview build against v0.22.x branch bug feature/rewards initiative/bat-payments QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Projects
None yet
Milestone
0.22.x Release 3 (Release Channel)
Development

No branches or pull requests
6 participants
@kjozwiak @NejcZdovc @srirambv @jasonrsadler @LaurenWags @btlechowski