Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

entire div for 'What do these policies mean?' is clickable #14059

Closed
LaurenWags opened this issue May 8, 2018 · 6 comments
Closed

entire div for 'What do these policies mean?' is clickable #14059

LaurenWags opened this issue May 8, 2018 · 6 comments
Labels
0.22.x issue first seen in 0.22.x bug/good-first-bug help wanted The PR/issue opener needs help to complete/report the task. polish Nice to have — usually related to front-end/visual tasks. priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). QA/checked-Linux QA/checked-macOS QA/checked-Win64 release-notes/include

Comments

@LaurenWags
Copy link
Member

Description

On about:preferences#security there is a link below the WebRTC setting for 'What do these policies mean?' Only the link should be clickable, but the entire div is clickable.

Steps to Reproduce

  1. Navigate to about:preferences#security
  2. Hover over 'What do these policies mean?' div and click anywhere on the div
  3. WebRTC wiki page is opened.

Actual result:
Entire div is clickable

Expected result:
Only the link should be clickable.

Reproduces how often:
easily

Brave Version

about:brave info:
0.22.703

Reproducible on current live release:
n/a

Additional Information

Similar to #12137

@LaurenWags LaurenWags added polish Nice to have — usually related to front-end/visual tasks. 0.22.x issue first seen in 0.22.x labels May 8, 2018
@LaurenWags LaurenWags added this to the Triage Backlog milestone May 8, 2018
@LaurenWags LaurenWags changed the title only 'What do these policies mean?' link should be clickable entire div for 'What do these policies mean?' is clickable May 8, 2018
@kjozwiak
Copy link
Member

kjozwiak commented May 8, 2018

@bsclifton should we move this into 0.23.x? I know we were moving issues out of 0.23.x during the triage call but we already have #12137 fixed which is similar. Might as well fix all these cases if we can. Should be a trivial fix as well. Thoughts?

@bsclifton
Copy link
Member

@kjozwiak since it's such a small one, I think we can skip on including it with 0.23.x. However, this would be a great first bug for somebody (and we can pull into 0.23.x if it's done sooner than later)

@bsclifton bsclifton added bug/good-first-bug priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). labels May 8, 2018
@bsclifton bsclifton modified the milestones: Triage Backlog, Backlog (Prioritized) May 8, 2018
@bsclifton
Copy link
Member

Here's a picture showing the issue; the entire div is clickable, rather than using a span (or inline-blocking it, etc)
screen shot 2018-05-08 at 4 40 22 pm

@NejcZdovc NejcZdovc added the help wanted The PR/issue opener needs help to complete/report the task. label May 9, 2018
thelostone-mc pushed a commit to thelostone-mc/browser-laptop that referenced this issue May 11, 2018
Ensure that only "What do these policies mean is clickable"
Fixes: brave#14059
@thelostone-mc
Copy link

Hey first time contributor here!

Had a few questions :

  • Since this is a html tag change -> I believe there aren't tests which I can write up for this
  • I added a gif to show the difference
  • Whom do I reach out to add labels for my PR to state it's ready for review ? (cause I don't have permissions)

@bsclifton
Copy link
Member

Hi there @thelostone-mc

  • you are correct; no tests available and none required
  • gif capturing it is great!
  • I can help you with the review! 😄 👍

@GeetaSarvadnya
Copy link
Collaborator

GeetaSarvadnya commented Jun 20, 2018

Verified on Windows 10 x64

  • 0.23.11 6565c06
  • Muon 7.1.0
  • libchromiumcontent 67.0.3396.87

Verified on macOS 10.13.4 x64 using the following build:

  • 0.23.11 6565c06
  • muon: 7.1.0
  • libchromiumcontent: 67.0.3396.87

Verified on Ubuntu 17.10 x64

  • 0.23.11 - 6565c06
  • Muon - 7.1.0
  • libchromiumcontent - 67.0.3396.87

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
0.22.x issue first seen in 0.22.x bug/good-first-bug help wanted The PR/issue opener needs help to complete/report the task. polish Nice to have — usually related to front-end/visual tasks. priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). QA/checked-Linux QA/checked-macOS QA/checked-Win64 release-notes/include
Projects
None yet
Development

No branches or pull requests

7 participants