Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Disappearing Bookmark Folder #14093

Closed
btlechowski opened this issue May 10, 2018 · 7 comments
Closed

Disappearing Bookmark Folder #14093

btlechowski opened this issue May 10, 2018 · 7 comments
Labels
bug feature/bookmarks fixed-with-brave-core This issue will automatically resolved with the replacement of Muon with Brave Core. wontfix

Comments

@btlechowski
Copy link
Contributor

Steps to Reproduce

Note: Best to watch the video

  1. Clean install
  2. Create Bookmark folder
  3. Drag the bookmark folder onto its content modal
    disappearing_content_modal

Actual result:
The bookmark folder disappears with all its content(will not be shown after restart).
The bookmarks under the bookmark folder still exist because the pages are marked as bookmarked.
For end user this will look like bookmarks randomly disappear.

Expected result:
Cannot drag bookmark folder onto its content modal

Reproduces how often:
100%

Brave Version

Brave: 0.22.669 
V8: 6.6.346.24 
rev: 6cda2e84f749e66409e9e3bca63f5796422e7edf 
Muon: 5.2.7 
OS Release: 6.1.7601 
Update Channel: Release 
OS Architecture: x64 
OS Platform: Microsoft Windows 
Node.js: 7.9.0 
Brave Sync: v1.4.2 
libchromiumcontent: 66.0.3359.117

Reproduced on Win and Lin.
@LaurenWags Could you check Mac?

Reproducible on current live release:
Yes, 0.22.669

Cc @kjozwiak @srirambv @LaurenWags @petemill @bsclifton

@LaurenWags
Copy link
Member

Reproduces on macOS using 0.22.669

@btlechowski
Copy link
Contributor Author

@bsclifton bsclifton added this to the Triage Backlog milestone May 14, 2018
@ajohnsen
Copy link

I had this same thing happen on my mac too.. I checked the session-store1 json file and in there the bookmarkfolder referenced itself in the parendId attribute.

This issue might be related/fixed earlier for the about:bookmark page: #4751

@misterjib
Copy link

misterjib commented Jun 22, 2018

Thanks for reporting this, curiously although the bookmark link is no longer present in the dropdown / bookmark manager, if you navigate to URL that is affected the bookmark star is still present and lit in nav bar.

Does anyone know how I can restore? is there an xml file somewhere maybe?

Exporting does not include affected.

This bug is a proper nause.

Brave | 0.22.810
V8 | 6.7.288.43
rev | 8f30eeb
Muon | 7.0.6
OS Release | 10.0.17134
Update Channel | Release
OS Architecture | x64
OS Platform | Microsoft Windows
Node.js | 7.9.0
Brave Sync | v1.4.2
libchromiumcontent | 67.0.3396.71

@Balancingrock
Copy link

I experience something slightly worse: I have several bookmarks in a folder. When I select one of these and keep the mouse key down so the link is dragged just a little, it will disappear when the mouse key is released.
However after that, I am unable to create a new bookmark for the same website. (It seems as if brave still knows the bookmark exists, so it does not add a new one, but at the same time also will not display the old one)

I have tried looking for a bookmarks file, but have not found any.

Brave 0.23.39
V8 6.7.288.46
rev 3ee14b0
Muon 7.1.6
OS Release 15.6.0
Update Channel Release
OS Architecture x64
OS Platform macOS
Node.js 7.9.0
Brave Sync v1.4.2
libchromiumcontent 67.0.3396.103

@ghost
Copy link

ghost commented Aug 28, 2018

I have lost 3 folders to this bug so +1 from me.

Sync has never worked properly for me either. I wonder if the two bugs are related. I sync and almost none of the folders sync properly, maybe 1 or 2 do and even then all the links aren't downloaded properly.

Brave 0.23.79
V8 6.8.275.24
rev 51b4905
Muon 8.0.7
OS Release 10.0.17134
Update Channel Release
OS Architecture x64
OS Platform Microsoft Windows
Node.js 7.9.0
Brave Sync v1.4.2
libchromiumcontent 68.0.3440.84

@bsclifton bsclifton added wontfix fixed-with-brave-core This issue will automatically resolved with the replacement of Muon with Brave Core. labels Sep 3, 2018
@bsclifton bsclifton removed this from the Triage Backlog milestone Sep 3, 2018
@bsclifton
Copy link
Member

Confirmed fixed with brave-core

For folks having this issue: for a work-around, you can go to the bookmarks manager and search for one of the bookmarks you know was lost (even if you don't remember full name, just type a letter). You should then be able to find/drag it back into the root folder

A second work-around would be to manually open the session-store-1 file which is stored at %APPDATA%\brave / ~/.config/brave/ / ~Libraries/Application Support/brave and find the bookmarks in the session JSON (make sure to close browser before editing- backing up this file is a good idea too)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug feature/bookmarks fixed-with-brave-core This issue will automatically resolved with the replacement of Muon with Brave Core. wontfix
Projects
None yet
Development

No branches or pull requests

6 participants