Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Bookmark folder disappears after drag and drop in about:bookmarks #4751

Closed
bsclifton opened this issue Oct 13, 2016 · 0 comments
Closed

Bookmark folder disappears after drag and drop in about:bookmarks #4751

bsclifton opened this issue Oct 13, 2016 · 0 comments

Comments

@bsclifton
Copy link
Member

bsclifton commented Oct 13, 2016

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
I was drag and dropping in the new about:bookmarks screen and one of my folder disappeared. No matter what I did, I could not find the folder. The bookmarks are still there; you can search and find them. I opened the session file up and saw the the folder in question had it's parentFolderId set to the same number as the folderId (which should be impossible)

JSON from the session:

{
  "lastAccessedTime": 1475044276843,
  "tags": [
    "bookmark-folder"
  ],
  "folderId": 1,
  "customTitle": "favorites",
  "parentFolderId": 1
},

Expected behavior:
You should never be able to move a folder onto itself

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Mac, but @alexwykoff had it occur on Windows
  • Brave Version:
    HEAD of master
  • Steps to reproduce:
    I cannot reliably reproduce, but @alexwykoff had encountered the issue too
  • Screenshot if needed:
    windows_folder_drag_poof
  • Any related issues:
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants