Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Twitter and other publishers are included even though the auto-include is disabled #14245

Closed
GeetaSarvadnya opened this issue May 24, 2018 · 4 comments
Closed

Twitter and other publishers are included even though the auto-include is disabled #14245

GeetaSarvadnya opened this issue May 24, 2018 · 4 comments
Assignees
@NejcZdovc
Labels
bug feature/rewards QA/checked-Linux QA/checked-macOS QA/checked-Win64 release-notes/include
Milestone
0.22.x Release 5 ...

Comments

@GeetaSarvadnya
Copy link
Collaborator

Description

Twitter and other publishers are included even though the auto-include is disabled

Steps to Reproduce

  1. Launch Brave with clean profile from CLI
  2. Enable payment
  3. Open twitter in new tab and click on Add to payments icon in the url bar
  4. Verify twitter publisher is included in ledger list
  5. Delete twitter from ledger list ( delete from show deleted list as well)
  6. Disable auto-include
  7. Open twitter in new tab, spend default 8 sec in viewing the video

Actual result:

Twitter publishers are included even though the auto-include is disabled

Expected result:

Twitter publishers should be listed instead of include when the auto-include is disabled

Reproduces how often:
100%

Brave Version

about:brave info:
0.22.801

Reproducible on current live release:
Yes

Additional Information

Able to reproduce the issue on twitter consistently
@GeetaSarvadnya GeetaSarvadnya added this to the Triage Backlog milestone May 24, 2018
@GeetaSarvadnya
Copy link
Collaborator Author

ledger issue

@NejcZdovc NejcZdovc self-assigned this May 28, 2018
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue May 28, 2018
@NejcZdovc
Removes site settings for delete sites
02195c6 
Resolves brave#14245

Auditors:

Test Plan:
@NejcZdovc NejcZdovc mentioned this issue May 28, 2018
Merged
10 tasks
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue May 29, 2018
@NejcZdovc
Removes site settings for delete sites
062b87a 
Resolves brave#14245

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue May 29, 2018
@NejcZdovc
Removes site settings for delete sites
6a80fd7 
Resolves brave#14245

Auditors:

Test Plan:
@jasonrsadler
Copy link
Contributor

Duplicate of #13283?

@NejcZdovc
Copy link
Contributor

not sure

cc @LaurenWags

NejcZdovc added a commit that referenced this issue May 29, 2018
@NejcZdovc
Merge pull request #14260 from NejcZdovc/fix/#14245-autoinclude
21f24d0 
Removes site settings for delete sites
NejcZdovc added a commit that referenced this issue May 29, 2018
@NejcZdovc
Merge pull request #14260 from NejcZdovc/fix/#14245-autoinclude
116e53f 
Removes site settings for delete sites
NejcZdovc added a commit that referenced this issue May 29, 2018
@NejcZdovc
Merge pull request #14260 from NejcZdovc/fix/#14245-autoinclude
84183b0 
Removes site settings for delete sites
This was referenced May 30, 2018
Closed
Closed
Closed
@LaurenWags
Copy link
Member

LaurenWags commented May 30, 2018 •
edited by btlechowski
Loading

Verified with macOS 10.12.6 using

  • 0.22.723 edb3e88
  • muon 6.0.12
  • libchromiumcontent 66.0.3359.170

Verified with Windows 10 x64 using

  • 0.22.723 edb3e88
  • muon 6.0.12
  • libchromiumcontent 66.0.3359.170

Verified on Ubuntu 17.10 x64

  • 0.22.723 edb3e88
  • muon 6.0.12
  • libchromiumcontent 66.0.3359.170

@kjozwiak kjozwiak mentioned this issue Jun 4, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
bug feature/rewards QA/checked-Linux QA/checked-macOS QA/checked-Win64 release-notes/include
Projects
None yet
Milestone
0.22.x Release 5 (Release channel)
Development

No branches or pull requests
5 participants
@NejcZdovc @jasonrsadler @LaurenWags @btlechowski @GeetaSarvadnya