Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Ledger entries should not be allowed to delete when reconcile is going on #14278

Closed
srirambv opened this issue May 30, 2018 · 1 comment
Closed

Ledger entries should not be allowed to delete when reconcile is going on #14278

srirambv opened this issue May 30, 2018 · 1 comment
Assignees
@jasonrsadler
Labels
bug feature/rewards
Milestone
0.24.x-legacy

Comments

@srirambv
Copy link
Collaborator

Description

Ledger entries should not be allowed to delete when reconcile is going on

Steps to Reproduce

  1. Install 0.22.723 and enable payments
  2. Visit sites to add in ledger table
  3. Change reconcilestamp to older date to trigger reconcile
  4. Ledger table entries can be deleted while reconcile is in progress

Actual result:
Ledger entries should not be allowed to delete when reconcile is going on

Expected result:
Should not be allowed to delete ledger entries

Reproduces how often:
100%

Brave Version

about:brave info:

Brave 0.22.723
V8 6.6.346.32
rev edb3e88
Muon 6.0.12
OS Release 10.0.17134
Update Channel Release
OS Architecture x64
OS Platform Microsoft Windows
Node.js 7.9.0
Brave Sync v1.4.2
libchromiumcontent 66.0.3359.170

Reproducible on current live release:
Yes

Additional Information

Behaviour should be similar to #8537
@srirambv srirambv added bug feature/rewards 0.22.x issue first seen in 0.22.x labels May 30, 2018
@NejcZdovc NejcZdovc removed the 0.22.x issue first seen in 0.22.x label May 30, 2018
@srirambv
Copy link
Collaborator Author

srirambv commented Jun 6, 2018

Delete wallet button should also be disabled while contribution is in progress. Currently its enabled during reconcile.

@jasonrsadler jasonrsadler mentioned this issue Jun 10, 2018
Merged
10 tasks
@NejcZdovc NejcZdovc modified the milestones: Triage Backlog, Completed work Jun 11, 2018
@alexwykoff alexwykoff modified the milestones: Completed work, 0.24.x (Developer Channel) Jun 19, 2018
bsclifton added a commit that referenced this issue Jun 21, 2018
@bsclifton
Merge pull request #14368 from jasonrsadler/fix/#14278-no-del-recon
5f5cbc8 
Sites and wallet now cannot be deleted when payment is in progress
bsclifton added a commit that referenced this issue Jun 21, 2018
@bsclifton
Merge pull request #14368 from jasonrsadler/fix/#14278-no-del-recon
c08a89c 
Sites and wallet now cannot be deleted when payment is in progress
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jasonrsadler jasonrsadler

Labels
bug feature/rewards
Projects
None yet
Milestone
0.24.x-legacy
Development

No branches or pull requests
5 participants
@alexwykoff @bsclifton @NejcZdovc @srirambv @jasonrsadler