Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Payments show mins time not met message even though ledger table contains more than 30mins of usage #14310

Closed
srirambv opened this issue Jun 1, 2018 · 2 comments · Fixed by #14314

Comments

@srirambv
Copy link
Collaborator

srirambv commented Jun 1, 2018

Test plan

Description

Payments show mins time not met message even though table contains more than 30mins of usage

Steps to Reproduce

  1. Enable payments and set Budget to 100BAT
  2. View a variety of pages(Twitch/YT/Browsing) to add to ledger table
  3. Ensure its more than 30 mins
  4. Change reconcileStamp to older date to trigger payment
  5. Relaunch browser shows min time not met message even ledger table shows more than 30 mins of usage

Actual result:
image

Expected result:
Should not show message if min time criteria is met

Reproduces how often:
Unsure. @davidtemkin had seen this on his profile as well.

Brave Version

about:brave info:

Brave 0.22.725
V8 6.6.346.32
rev e6dd17f
Muon 6.0.12
OS Release 10.0.17134
Update Channel Release
OS Architecture x64
OS Platform Microsoft Windows
Node.js 7.9.0
Brave Sync v1.4.2
libchromiumcontent 66.0.3359.170

Reproducible on current live release:
Maybe

Additional Information

cc: @jasonrsadler @ryanml @NejcZdovc

@NejcZdovc NejcZdovc self-assigned this Jun 1, 2018
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jun 2, 2018
Resolves brave#14310

Auditors:

Test Plan:
@NejcZdovc
Copy link
Contributor

Some publishers could be older then 30 days and this are excluded from this 30min monthly browsing time. Problem is that we don't update table to reflect that. So you could be seeing ledger table with a lot of publishers that are old

NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jun 2, 2018
Resolves brave#14310

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jun 2, 2018
Resolves brave#14310

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jun 2, 2018
Resolves brave#14310

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jun 2, 2018
Resolves brave#14310

Auditors:

Test Plan:
NejcZdovc added a commit that referenced this issue Jun 3, 2018
Clears old entries from the table
NejcZdovc added a commit that referenced this issue Jun 3, 2018
Clears old entries from the table
NejcZdovc added a commit that referenced this issue Jun 3, 2018
Clears old entries from the table
@GeetaSarvadnya
Copy link
Collaborator

GeetaSarvadnya commented Jun 4, 2018

Verified with Windows 10 x64 using

0.22.727 2c94bba
muon 6.0.12
libchromiumcontent 66.0.3359.170

Verified with macOS 10.12.6 using

  • 0.22.727 2c94bba
  • muon 6.0.12
  • libchromiumcontent 66.0.3359.170

Verified on Ubuntu 17.10 x64

  • 0.22.727 2c94bba
  • muon 6.0.12
  • libchromiumcontent 66.0.3359.170

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.