Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Brave crashes on launch for some users who have Brave Payments enabled #14370

Closed
LaurenWags opened this issue Jun 11, 2018 · 6 comments
Closed
Assignees
Labels
bug crash feature/rewards priority/P1 Blocks development or testing. Product cannot run. Must be fixed immediately, shipped next release. QA/no-qa-needed release-notes/include

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Jun 11, 2018

Description

Some users are still reporting unable to use Brave after updating to 0.22.727:
https://community.brave.com/t/brave-crashes-upon-launching-on-macbook/23505
https://community.brave.com/t/browser-crashes-seconds-after-launch/22438/25
https://community.brave.com/t/brave-does-not-lauch-at-all-windows-10-latest-update/23618/1
https://community.brave.com/t/new-brave-update-v0-22-727-hangs-indefinitely-on-startup-with-or-without-any-tabs-open/23451

Was reported with earlier versions with #14202

Steps to Reproduce

Unknown - users are reporting they launch and have issues.

Actual result:
Brave crashes/becomes unresponsive after launch.

Expected result:
Brave should operate normally.

Reproduces how often:
Unknown.

Brave Version

about:brave info:
0.22.727

Reproducible on current live release:
Yes

Additional Information

@alexwykoff alexwykoff added needs-investigation A bug not 100% confirmed/fixed that needs QA to better audit. priority/P1 Blocks development or testing. Product cannot run. Must be fixed immediately, shipped next release. labels Jun 12, 2018
@alexwykoff alexwykoff added this to the 0.23.x (Beta Channel) milestone Jun 12, 2018
@bsclifton
Copy link
Member

Reproduced using a user profile - looking into this now...

@bsclifton
Copy link
Member

Problem is here (only affects folks w/ Brave Payments):
https://github.com/brave-intl/bat-publisher/blob/35714c83ebb94eaf3dd5129478ddeffab6785657/index.js#L409-L424

There's no end condition for this while loop given the data I have in this profile

@bsclifton bsclifton added feature/rewards and removed needs-investigation A bug not 100% confirmed/fixed that needs QA to better audit. labels Jun 15, 2018
@ryanml
Copy link
Contributor

ryanml commented Jun 15, 2018

Pending: brave-intl/bat-publisher#35

@kjozwiak
Copy link
Member

@bsclifton can we use the profile you mentioned in #14370 (comment) to verify this on the different platforms? Seems like there's not much QA can do here without a reproducible profile.

@bsclifton
Copy link
Member

@kjozwiak unfortunately, I no longer have the profile. We can ask the user again, but after finding the root cause and writing the failing unit tests, I deleted all copies of the profile

Since there are unit tests covering this (and because it would need a profile that we don't have), I'll mark this as no-qa-needed

@bsclifton bsclifton changed the title Brave crashes on launch for some users Brave crashes on launch for some users who have Brave Payments enabled Jun 25, 2018
@kjozwiak
Copy link
Member

Awesome, much appreciated @bsclifton 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug crash feature/rewards priority/P1 Blocks development or testing. Product cannot run. Must be fixed immediately, shipped next release. QA/no-qa-needed release-notes/include
Projects
None yet
Development

No branches or pull requests

5 participants