Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Torrent/Magnet link should show unsupported message on TOR tab #14374

Closed
GeetaSarvadnya opened this issue Jun 11, 2018 · 4 comments
Closed

Torrent/Magnet link should show unsupported message on TOR tab #14374

GeetaSarvadnya opened this issue Jun 11, 2018 · 4 comments

Comments

@GeetaSarvadnya
Copy link
Collaborator

GeetaSarvadnya commented Jun 11, 2018

Description

Torrent file and magnet links are redirecting to empty TOR pages, there is no message indication to state that the page cannot be displayed

Steps to Reproduce

  1. Enable TOR
  2. Open the link in private tor tab https://webtorrent.io/free-torrents
  3. Open the links (torrent file) (magnet link) in private tab

Actual result:
Torrent file and magnet links are redirecting to empty TOR pages there is no message indication to state that the page cannot be displayed

image

Expected result:
Page should be displayed with appropriate message.

Reproduces how often:
Easy

Brave Version

0.23.8

Reproducible on current live release:

Additional Information

@GeetaSarvadnya GeetaSarvadnya added priority/P4 Minor loss of function. Workaround usually present. feature/tor labels Jun 11, 2018
@GeetaSarvadnya GeetaSarvadnya changed the title Torrent file and magnet links are redirecting to empty TOR pages there is no message indication to state that the page cannot be displayed Torrent file and magnet links are redirecting to empty TOR pages, there is no message indication to state that the page cannot be displayed Jun 11, 2018
@diracdeltas
Copy link
Member

We disable torrent content in Tor for privacy reasons, so it should probably show some kind of error message ("Torrent cannot be loaded over Tor for privacy reasons.")

@jumde jumde self-assigned this Jun 11, 2018
@srirambv srirambv changed the title Torrent file and magnet links are redirecting to empty TOR pages, there is no message indication to state that the page cannot be displayed Torrent/Magnet link should show unsupported message on TOR tab Jun 11, 2018
@diracdeltas
Copy link
Member

fixed by 51caf52

@srirambv
Copy link
Collaborator

srirambv commented Jun 20, 2018

@bsclifton @diracdeltas This doesn't seem to be included in 0.23.11. I still see empty tab without any warning when opening a torrent in Tor tab.

Edit: Testing on a new profile shows the error message

@srirambv
Copy link
Collaborator

srirambv commented Jun 21, 2018

Verified on Windows 10 x64 using

  • 0.23.12 - 88f6f07
  • Muon - 7.1.1
  • libchromiumcontent - 67.0.3396.87

Verified with macOS 10.12.6 using

  • 0.23.14 f4da855
  • Muon 7.1.1
  • libchromiumcontent 67.0.3396.87
    screen shot 2018-06-22 at 11 35 53 am

Verified on Ubuntu 17.10 x64

  • 0.23.14 - f4da855
  • Muon - 7.1.1
  • libchromiumcontent - 67.0.3396.87

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants