Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Closing the last tab on full tabstrip and moving mouse away does not restore tab width #14477

Closed
petemill opened this issue Jun 20, 2018 · 4 comments · Fixed by #14478
Closed

Closing the last tab on full tabstrip and moving mouse away does not restore tab width #14477

petemill opened this issue Jun 20, 2018 · 4 comments · Fixed by #14478
Assignees
@petemill
Labels
0.23.x issue first seen in 0.23.x QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release-notes/exclude
Milestone
0.23.x (Release C...

Comments

@petemill
Copy link
Member

Description

There is a feature whereby the tab width is forced to not changed whilst closing tabs, so that the close tab icon (x) stays in the same position for each tab. The new tab width should then take effect when the mouse leaves the tab bar. However, there's a bug in 0.23.x beta currently whereby the mouseleave event is not received, due to new display: contents property.

Steps to Reproduce

From @kjozwiak at #7001 (comment)

STR:

  • open about ~15 new tabs using 0.23.11 6565c06
  • close the tab that's all the way at the end of the tab toolbar and drag the mouse onto the page
  • notice that the animation isn't triggered
  • move the mouse over one of the already created tabs and you'll notice the animation triggering.

Example of issue:

animationexample

Reproduces how often:
100%

Brave Version

0.23.11

Reproducible on current live release:
No

Additional Information
@petemill petemill added regression 0.23.x issue first seen in 0.23.x labels Jun 20, 2018
@petemill petemill added this to the 0.23.x (Beta Channel) milestone Jun 20, 2018
@petemill petemill self-assigned this Jun 20, 2018
@petemill petemill mentioned this issue Jun 20, 2018
Closed
petemill added a commit that referenced this issue Jun 20, 2018
@petemill
Move tabs toolbar mouseleave handler to parent element which does not…
36a658d 
… use 'contents' value for display style property

Since a `display: contents` container will essentially be the width of its children, and the child was being removed on tab close, the width of the parent element was narrowing so that the mouse was no longer on top, but the mouseleave event did not fire. Moving this handler to a parent element fixes it. It encompasses the pinned tabs but this should not be an issue as the intention of the feature is to relate to the tabs bar as a whole.

Fix #14477
@petemill petemill mentioned this issue Jun 20, 2018
Merged
10 tasks
@petemill petemill changed the title Closing the last tab on full tabstrip and moving mouse away does not restor tab width Closing the last tab on full tabstrip and moving mouse away does not restore tab width Jun 20, 2018
This was referenced Jun 21, 2018
Closed
Closed
Closed
Closed
Closed
Closed
@srirambv
Copy link
Collaborator

The animation looks pretty bad. The new tab buttons hides when tabs resize and then shows up.
tabsbar

@bsclifton
Copy link
Member

@srirambv looks like that happens with our existing live build too (0.22.810). We can create another issue for that if you'd like

@petemill petemill mentioned this issue Jun 22, 2018
Merged
10 tasks
@petemill
Copy link
Member Author

I think the issue @srirambv is showing is a new regression with #7001 which is a 0.23.x issue. By the way, none of it is to do with this issue which was fixing a different regression. I have addressed the problem with #14516

This was referenced Jun 25, 2018
Closed
Closed
Closed
@btlechowski
Copy link
Contributor

btlechowski commented Jun 25, 2018 •
edited by LaurenWags
Loading

Verified on Ubuntu 17.10 x64

  • 0.23.16 - 2042c45
  • Muon - 7.1.1
  • libchromiumcontent - 67.0.3396.87

Verified on Windows 10 x64 using

  • 0.23.16 - 2042c45
  • Muon - 7.1.1
  • libchromiumcontent - 67.0.3396.87

Verified with macOS 10.12.6 using

  • 0.23.16 2042c45
  • Muon 7.1.1
  • libchromiumcontent 67.0.3396.87

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@petemill petemill

Labels
0.23.x issue first seen in 0.23.x QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release-notes/exclude
Projects
None yet
Milestone
0.23.x (Release Channel)
Development

Successfully merging a pull request may close this issue.

Move tabs toolbar mouseleave handler to parent element brave/browser-laptop
5 participants
@petemill @bsclifton @srirambv @LaurenWags @btlechowski