Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Allow $SITE to run flash notifications should not appear on tor tabs #14480

Closed
diracdeltas opened this issue Jun 21, 2018 · 2 comments
Closed

Allow $SITE to run flash notifications should not appear on tor tabs #14480

diracdeltas opened this issue Jun 21, 2018 · 2 comments
Assignees
@diracdeltas
Labels
feature/tor QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release/blocking release-notes/exclude
Milestone
0.23.x (Release C...

Comments

@diracdeltas
Copy link
Member

Since Flash is not runnable on Tor tabs (#13396), the "Allow SITE to run flash" notification bar should not appear on Tor tabs.

STR:

  1. go to a tor tab and open http://www.ultrasounds.com/
  2. notice the "Allow Flash to run" notification bar appears

Expected behavior: No notification bars should appear
@diracdeltas diracdeltas self-assigned this Jun 21, 2018
@diracdeltas diracdeltas added this to the 0.23.x (Beta Channel) milestone Jun 21, 2018
diracdeltas added a commit that referenced this issue Jun 21, 2018
@diracdeltas
defense in depth against Flash/ledger running on tor tabs
0d01710 
use the new torEnabled content script settings to block content scripts that
shouldn't be runnning in Tor tabs

fix #14480

Test Plan:
1. open tor tab
2. go to http://www.ultrasounds.com/
3. you should not see a notification to run flash
@diracdeltas diracdeltas mentioned this issue Jun 21, 2018
Merged
10 tasks
diracdeltas added a commit that referenced this issue Jun 21, 2018
@diracdeltas
defense in depth against Flash/ledger running on tor tabs
a59bc1b 
use the new torEnabled content script settings to block content scripts that
shouldn't be runnning in Tor tabs

fix #14480

Test Plan:
1. open tor tab
2. go to http://www.ultrasounds.com/
3. you should not see a notification to run flash
diracdeltas added a commit that referenced this issue Jun 21, 2018
@diracdeltas
defense in depth against Flash/ledger running on tor tabs
48e0943 
use the new torEnabled content script settings to block content scripts that
shouldn't be runnning in Tor tabs

fix #14480

Test Plan:
1. open tor tab
2. go to http://www.ultrasounds.com/
3. you should not see a notification to run flash
diracdeltas added a commit that referenced this issue Jun 21, 2018
@diracdeltas
defense in depth against Flash/ledger running on tor tabs (#14482)
48fcfb9 
use the new torEnabled content script settings to block content scripts that
shouldn't be runnning in Tor tabs

fix #14480

Test Plan:
1. open tor tab
2. go to http://www.ultrasounds.com/
3. you should not see a notification to run flash
@diracdeltas
Copy link
Member Author

fixed by #14482

bsclifton pushed a commit that referenced this issue Jun 22, 2018
@diracdeltas @bsclifton
defense in depth against Flash/ledger running on tor tabs (#14482)
2e33fed 
use the new torEnabled content script settings to block content scripts that
shouldn't be runnning in Tor tabs

fix #14480

Test Plan:
1. open tor tab
2. go to http://www.ultrasounds.com/
3. you should not see a notification to run flash
diracdeltas added a commit that referenced this issue Jun 22, 2018
@diracdeltas
defense in depth against Flash/ledger running on tor tabs (#14482)
c2580db 
use the new torEnabled content script settings to block content scripts that
shouldn't be runnning in Tor tabs

fix #14480

Test Plan:
1. open tor tab
2. go to http://www.ultrasounds.com/
3. you should not see a notification to run flash
bsclifton pushed a commit that referenced this issue Jun 23, 2018
@diracdeltas @bsclifton
defense in depth against Flash/ledger running on tor tabs (#14482)
aeff0d5 
use the new torEnabled content script settings to block content scripts that
shouldn't be runnning in Tor tabs

fix #14480

Test Plan:
1. open tor tab
2. go to http://www.ultrasounds.com/
3. you should not see a notification to run flash
This was referenced Jun 25, 2018
Closed
Closed
Closed
@srirambv
Copy link
Collaborator

srirambv commented Jun 25, 2018 •
edited by kjozwiak
Loading

Verified on Windows 10 x64 using

  • 0.23.16 - 2042c45
  • Muon - 7.1.1
  • libchromiumcontent - 67.0.3396.87

Verified with macOS 10.12.6 using

  • 0.23.17 bc754eb
  • Muon 7.1.2
  • libchromiumcontent 67.0.3396.87

Verified on Ubuntu 18.04 x64 using the following build:

  • 0.23.17 bc754eb
  • muon: 7.1.2
  • libchromiumcontent: 67.0.3396.87

bsclifton pushed a commit that referenced this issue Jun 25, 2018
@diracdeltas @bsclifton
defense in depth against Flash/ledger running on tor tabs (#14482)
503c06f 
use the new torEnabled content script settings to block content scripts that
shouldn't be runnning in Tor tabs

fix #14480

Test Plan:
1. open tor tab
2. go to http://www.ultrasounds.com/
3. you should not see a notification to run flash
This was referenced Jun 25, 2018
Closed
Closed
bsclifton pushed a commit that referenced this issue Jun 26, 2018
@diracdeltas @bsclifton
defense in depth against Flash/ledger running on tor tabs (#14482)
62938c1 
use the new torEnabled content script settings to block content scripts that
shouldn't be runnning in Tor tabs

fix #14480

Test Plan:
1. open tor tab
2. go to http://www.ultrasounds.com/
3. you should not see a notification to run flash
bsclifton pushed a commit that referenced this issue Jun 27, 2018
@diracdeltas @bsclifton
defense in depth against Flash/ledger running on tor tabs (#14482)
3a3f0cd 
use the new torEnabled content script settings to block content scripts that
shouldn't be runnning in Tor tabs

fix #14480

Test Plan:
1. open tor tab
2. go to http://www.ultrasounds.com/
3. you should not see a notification to run flash
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@diracdeltas diracdeltas

Labels
feature/tor QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release/blocking release-notes/exclude
Projects
None yet
Milestone
0.23.x (Release Channel)
Development

No branches or pull requests
4 participants
@diracdeltas @kjozwiak @srirambv @LaurenWags