Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

external protocol prompt does not appear on about: pages #14679

Closed
diracdeltas opened this issue Jul 6, 2018 · 9 comments
Closed

external protocol prompt does not appear on about: pages #14679

diracdeltas opened this issue Jul 6, 2018 · 9 comments
Assignees
@diracdeltas @riastradh-brave
Labels
feature/tor QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release/blocking release-notes/include security
Milestone
0.23.x Hotfix (Re...

Comments

@diracdeltas
Copy link
Member

diracdeltas commented Jul 6, 2018 •
edited
Loading

STR:

  1. go to about:newtab (or just open a new tab)
  2. enter 'mailto:test' in the url bar
  3. note that the mail app opens without showing a permission prompt

whereas if you do step 2 on a page such as google.com, the permission prompt appears as expected.

EDIT: marked as tor due to https://hackerone.com/bugs?subject=brave&report_id=388494
@diracdeltas diracdeltas self-assigned this Jul 6, 2018
@diracdeltas diracdeltas mentioned this issue Jul 6, 2018
Closed
@diracdeltas
Copy link
Member Author

i thought we fixed this at some point so maybe this is a regression. can't find the original issue though.

@btlechowski
Copy link
Contributor

Original issue: #13643.

@diracdeltas
Copy link
Member Author

https://hackerone.com/bugs?subject=brave&report_id=388494 makes this more of a serious issue

@diracdeltas
Copy link
Member Author

I don't think #13643 is the original issue since that STR was for URLs entered on a remote site like google.com whereas this bug only happens on about: pages.

@riastradh-brave
Copy link
Contributor

Can sites do this or do you have to type it into the URL bar?

@diracdeltas
Copy link
Member Author

@riastradh-brave sites can do it via a redirect to a custom protocol (ssh://...) apparently

diracdeltas added a commit that referenced this issue Jul 31, 2018
@diracdeltas
Remove permission exception for brave and pdf viewer
2b16a49 
quick fix for
#14679 (comment)
by just removing the special exception for these origins. this probably
breaks something but i'm not sure what.
@diracdeltas
Copy link
Member Author

#14681 is related, probably fixed by the same muon fix

riastradh-brave pushed a commit that referenced this issue Jul 31, 2018
@diracdeltas @riastradh-brave
Remove permission exception for brave and pdf viewer
156d971 
quick fix for
#14679 (comment)
by just removing the special exception for these origins. this probably
breaks something but i'm not sure what.
@riastradh-brave riastradh-brave mentioned this issue Jul 31, 2018
Merged
10 tasks
@riastradh-brave riastradh-brave mentioned this issue Aug 1, 2018
Closed
@riastradh-brave
Copy link
Contributor

Immediate symptom is fixed by #14887, but may be other latent issues, for which see #14897.

This was referenced Aug 2, 2018
Closed
Closed
Closed
@srirambv
Copy link
Collaborator

srirambv commented Aug 2, 2018 •
edited by LaurenWags
Loading

Verified on Windows10 x64 ysing

  • 0.23.74 b508fa7
  • Muon 8.0.4
  • libchromiumcontent 68.0.3440.84
  • Verified on normal/private/Tor tabs

Verified on Ubuntu 17.10 x64

  • 0.23.74 c3d448a
  • Muon 8.0.4
  • libchromiumcontent 68.0.3440.84

Verified with macOS 10.12.6 using

  • 0.23.74 b508fa7
  • Muon 8.0.4
  • libchromiumcontent 68.0.3440.84

@kjozwiak kjozwiak mentioned this issue Aug 3, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@diracdeltas diracdeltas

@riastradh-brave riastradh-brave

Labels
feature/tor QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release/blocking release-notes/include security
Projects
None yet
Milestone
0.23.x Hotfix (Release Channel)
Development

No branches or pull requests
8 participants
@diracdeltas @alexwykoff @kjozwiak @bsclifton @srirambv @LaurenWags @riastradh-brave @btlechowski